From: Conor Dooley <conor@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding
Date: Mon, 10 Jul 2023 18:08:39 +0100 [thread overview]
Message-ID: <20230710-mahogany-unequal-91830352ffc5@spud> (raw)
In-Reply-To: <20230707115302.3491-1-zajec5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
On Fri, Jul 07, 2023 at 01:53:02PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM53573 is a family derived from Northstar with some important
> differences:
> 1. Cortex-A9 replaced by Cortex-A7
> 2. XHCI controller dropped
> 3. Two Ethernet interfaces removed
> 4. Two 802.11ac cores embedded
>
> Linux already contains DTS files for some on those devices so add a
> proper binding for it.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/arm/bcm/brcm,bcm53573.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
> new file mode 100644
> index 000000000000..6e502d718518
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0
How come this is not dual licensed?
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm53573.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM53573 SoCs family
Title seems a little odd given the description.
"Broadcom Northstar derived Wi-Fi SoCs"?
Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-07-10 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 11:53 [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding Rafał Miłecki
2023-07-10 17:08 ` Conor Dooley [this message]
2023-07-10 17:24 ` Rafał Miłecki
2023-07-10 17:27 ` Rafał Miłecki
2023-07-10 17:38 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710-mahogany-unequal-91830352ffc5@spud \
--to=conor@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox