* [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding
@ 2023-07-07 11:53 Rafał Miłecki
2023-07-10 17:08 ` Conor Dooley
0 siblings, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2023-07-07 11:53 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM53573 is a family derived from Northstar with some important
differences:
1. Cortex-A9 replaced by Cortex-A7
2. XHCI controller dropped
3. Two Ethernet interfaces removed
4. Two 802.11ac cores embedded
Linux already contains DTS files for some on those devices so add a
proper binding for it.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../bindings/arm/bcm/brcm,bcm53573.yaml | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
new file mode 100644
index 000000000000..6e502d718518
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm53573.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM53573 SoCs family
+
+description:
+ Broadcom BCM53573 / BCM47189 Wi-Fi SoCs derived from Northstar.
+
+maintainers:
+ - Rafał Miłecki <rafal@milecki.pl>
+
+properties:
+ $nodename:
+ const: '/'
+ compatible:
+ oneOf:
+ - description: BCM53573 based boards
+ items:
+ - enum:
+ - tenda,ac6
+ - tenda,w15e
+ - const: brcm,bcm53573
+
+ - description: BCM47189 based boards
+ items:
+ - enum:
+ - brcm,bcm947189acdbmr
+ - luxul,xap-810-v1
+ - luxul,xap-1440-v1
+ - tenda,ac9
+ - const: brcm,bcm47189
+ - const: brcm,bcm53573
+
+additionalProperties: true
+
+...
--
2.35.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding
2023-07-07 11:53 [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding Rafał Miłecki
@ 2023-07-10 17:08 ` Conor Dooley
2023-07-10 17:24 ` Rafał Miłecki
0 siblings, 1 reply; 5+ messages in thread
From: Conor Dooley @ 2023-07-10 17:08 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
On Fri, Jul 07, 2023 at 01:53:02PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM53573 is a family derived from Northstar with some important
> differences:
> 1. Cortex-A9 replaced by Cortex-A7
> 2. XHCI controller dropped
> 3. Two Ethernet interfaces removed
> 4. Two 802.11ac cores embedded
>
> Linux already contains DTS files for some on those devices so add a
> proper binding for it.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/arm/bcm/brcm,bcm53573.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
> new file mode 100644
> index 000000000000..6e502d718518
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0
How come this is not dual licensed?
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm53573.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom BCM53573 SoCs family
Title seems a little odd given the description.
"Broadcom Northstar derived Wi-Fi SoCs"?
Otherwise,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding
2023-07-10 17:08 ` Conor Dooley
@ 2023-07-10 17:24 ` Rafał Miłecki
2023-07-10 17:27 ` Rafał Miłecki
0 siblings, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2023-07-10 17:24 UTC (permalink / raw)
To: Conor Dooley
Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
On 10.07.2023 19:08, Conor Dooley wrote:
> On Fri, Jul 07, 2023 at 01:53:02PM +0200, Rafał Miłecki wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> BCM53573 is a family derived from Northstar with some important
>> differences:
>> 1. Cortex-A9 replaced by Cortex-A7
>> 2. XHCI controller dropped
>> 3. Two Ethernet interfaces removed
>> 4. Two 802.11ac cores embedded
>>
>> Linux already contains DTS files for some on those devices so add a
>> proper binding for it.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
>> .../bindings/arm/bcm/brcm,bcm53573.yaml | 39 +++++++++++++++++++
>> 1 file changed, 39 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
>> new file mode 100644
>> index 000000000000..6e502d718518
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
>> @@ -0,0 +1,39 @@
>> +# SPDX-License-Identifier: GPL-2.0
>
> How come this is not dual licensed?
Somehow I got inspired by other Broadocm SoCs here. I'll relicense it though.
FWIW:
$ grep "SPDX-License-Identifier" Documentation/devicetree/bindings/arm/bcm/*.yaml
Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,bcm11351.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,bcm23550.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml:# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
Documentation/devicetree/bindings/arm/bcm/brcm,cygnus.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,hr2.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,ns2.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,stingray.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/brcm,vulcan-soc.yaml:# SPDX-License-Identifier: GPL-2.0
Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml:# SPDX-License-Identifier: GPL-2.0
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm53573.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Broadcom BCM53573 SoCs family
>
> Title seems a little odd given the description.
> "Broadcom Northstar derived Wi-Fi SoCs"?
Some team at Broadcom took Northstar family design, added their changes
and they reference those SoCs as BCM53573 family. So I thought I should
just stick with the name they chose.
> Otherwise,
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding
2023-07-10 17:24 ` Rafał Miłecki
@ 2023-07-10 17:27 ` Rafał Miłecki
2023-07-10 17:38 ` Conor Dooley
0 siblings, 1 reply; 5+ messages in thread
From: Rafał Miłecki @ 2023-07-10 17:27 UTC (permalink / raw)
To: Conor Dooley
Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
On 10.07.2023 19:24, Rafał Miłecki wrote:
> On 10.07.2023 19:08, Conor Dooley wrote:
>> On Fri, Jul 07, 2023 at 01:53:02PM +0200, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> BCM53573 is a family derived from Northstar with some important
>>> differences:
>>> 1. Cortex-A9 replaced by Cortex-A7
>>> 2. XHCI controller dropped
>>> 3. Two Ethernet interfaces removed
>>> 4. Two 802.11ac cores embedded
>>>
>>> Linux already contains DTS files for some on those devices so add a
>>> proper binding for it.
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>> ---
>>> .../bindings/arm/bcm/brcm,bcm53573.yaml | 39 +++++++++++++++++++
>>> 1 file changed, 39 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
>>> new file mode 100644
>>> index 000000000000..6e502d718518
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
>>> @@ -0,0 +1,39 @@
>>> +# SPDX-License-Identifier: GPL-2.0
>>
>> How come this is not dual licensed?
>
> Somehow I got inspired by other Broadocm SoCs here. I'll relicense it though.
>
> FWIW:
> $ grep "SPDX-License-Identifier" Documentation/devicetree/bindings/arm/bcm/*.yaml
> Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm11351.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm23550.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml:# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> Documentation/devicetree/bindings/arm/bcm/brcm,cygnus.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,hr2.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,ns2.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,stingray.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/brcm,vulcan-soc.yaml:# SPDX-License-Identifier: GPL-2.0
> Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml:# SPDX-License-Identifier: GPL-2.0
>
>
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm53573.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Broadcom BCM53573 SoCs family
>>
>> Title seems a little odd given the description.
>> "Broadcom Northstar derived Wi-Fi SoCs"?
>
> Some team at Broadcom took Northstar family design, added their changes
> and they reference those SoCs as BCM53573 family. So I thought I should
> just stick with the name they chose.
I'm wondering if "derived" is a correct word in this case. I'm not
familiar with hardware design terminology. Maybe that is what causes a
confusion here?
>> Otherwise,
>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding
2023-07-10 17:27 ` Rafał Miłecki
@ 2023-07-10 17:38 ` Conor Dooley
0 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2023-07-10 17:38 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-kernel, devicetree, bcm-kernel-feedback-list,
Rafał Miłecki
[-- Attachment #1: Type: text/plain, Size: 3943 bytes --]
On Mon, Jul 10, 2023 at 07:27:12PM +0200, Rafał Miłecki wrote:
> On 10.07.2023 19:24, Rafał Miłecki wrote:
> > On 10.07.2023 19:08, Conor Dooley wrote:
> > > On Fri, Jul 07, 2023 at 01:53:02PM +0200, Rafał Miłecki wrote:
> > > > From: Rafał Miłecki <rafal@milecki.pl>
> > > >
> > > > BCM53573 is a family derived from Northstar with some important
> > > > differences:
> > > > 1. Cortex-A9 replaced by Cortex-A7
> > > > 2. XHCI controller dropped
> > > > 3. Two Ethernet interfaces removed
> > > > 4. Two 802.11ac cores embedded
> > > >
> > > > Linux already contains DTS files for some on those devices so add a
> > > > proper binding for it.
> > > >
> > > > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> > > > ---
> > > > .../bindings/arm/bcm/brcm,bcm53573.yaml | 39 +++++++++++++++++++
> > > > 1 file changed, 39 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
> > > > new file mode 100644
> > > > index 000000000000..6e502d718518
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml
> > > > @@ -0,0 +1,39 @@
> > > > +# SPDX-License-Identifier: GPL-2.0
> > >
> > > How come this is not dual licensed?
> >
> > Somehow I got inspired by other Broadocm SoCs here. I'll relicense it though.
> >
> > FWIW:
> > $ grep "SPDX-License-Identifier" Documentation/devicetree/bindings/arm/bcm/*.yaml
> > Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,bcm11351.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,bcm21664.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,bcm23550.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,bcm53573.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml:# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> > Documentation/devicetree/bindings/arm/bcm/brcm,cygnus.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,hr2.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,ns2.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,nsp.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,stingray.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/brcm,vulcan-soc.yaml:# SPDX-License-Identifier: GPL-2.0
> > Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml:# SPDX-License-Identifier: GPL-2.0
> >
> >
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/arm/bcm/brcm,bcm53573.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Broadcom BCM53573 SoCs family
> > >
> > > Title seems a little odd given the description.
> > > "Broadcom Northstar derived Wi-Fi SoCs"?
> >
> > Some team at Broadcom took Northstar family design, added their changes
> > and they reference those SoCs as BCM53573 family. So I thought I should
> > just stick with the name they chose.
>
> I'm wondering if "derived" is a correct word in this case. I'm not
> familiar with hardware design terminology. Maybe that is what causes a
> confusion here?
I dunno. It's not that important really. I just found it odd for the
title to say "XYZ family" and then have the description say "XYZ / QPR
SoCs". You don't need to change it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-10 17:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-07 11:53 [PATCH] dt-bindings: arm: bcm: add BCM53573 SoCs family binding Rafał Miłecki
2023-07-10 17:08 ` Conor Dooley
2023-07-10 17:24 ` Rafał Miłecki
2023-07-10 17:27 ` Rafał Miłecki
2023-07-10 17:38 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).