From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3D05EB64D9 for ; Wed, 12 Jul 2023 11:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232562AbjGLLJu (ORCPT ); Wed, 12 Jul 2023 07:09:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232486AbjGLLJt (ORCPT ); Wed, 12 Jul 2023 07:09:49 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54E5310CB for ; Wed, 12 Jul 2023 04:09:48 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6686c74183cso6042799b3a.1 for ; Wed, 12 Jul 2023 04:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1689160188; x=1691752188; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=WbKFLGGxnO5TsvoMTajzHD0NXptuvXCtrTMuAdwT1mY=; b=XXLfuSnhT9hjGYE+SPfEcjSdPv40QUS+tTjfpr6MX/dToYh9QpBQ/kyZv/5PnHxqRG AzwfrV87nVqIpApe8T+59F5ngK1reElykSPE0NVp46eTotAVpfcpxnZfGQ8NWjNXVPi1 No627XMUFrkD0+FBRViBI4zuRa9wOezxXq/qI5EFJgd5LZXuwjWgNjBx4JqoaHvvLIMy miVDRnNK4LRl+SmdevpV69x5nGiH7sU9UxlYxaAfIKEkfY3WkmhBpGO4GRSCTwlQhGUA EBPEp9+jxMDfmMimgIMUVCQqdDDSA/2Jx9jQhmgEpaIZ7pQXnGh/6aZInncrG32LM+5p Yxwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689160188; x=1691752188; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WbKFLGGxnO5TsvoMTajzHD0NXptuvXCtrTMuAdwT1mY=; b=CPKwGuLCsi4sQ3q8sltXtBheOVx+Mpd/JUBixXAnJm2AGjk7JoRFXKfeQX0Zi25UU+ wd5WmHCVNPyXW7IAvfl9ldW95Ph2XEJNwO/4s7OdIpW437yNR1+CfqGjUUDvubAF1qgy KSQLu8erD91V4V9o6cOdytBzDCrLZLWiH803Do6CGsGEqO7zK2ShTmFYgeNlIuUBsZn3 Jf8+B0aJFzXYkZso5J+Q1vZJa+FmtTHkCDnx10XZKJULyXHOxZdHM2IF8yBatgC84Ltg N5ApEVk6Z41bUQGH27/8sWWYv+S5WsL8vD/M5WaQSbOpzR46BCL6EN3nuPXp2niokxJl R8hg== X-Gm-Message-State: ABy/qLZKvEYAiN+1DP9/+P6BTGuzMUydBX/yAc9UGYvG3hwiAdqY66DJ V7htH9PwZED9W181OB8OtBS2qA== X-Google-Smtp-Source: APBJJlEkj+4MqB2CPiTfqApDhEK6QrNrJLvp3vE6L50wX4eg7NswLMhoNs9Gwav0qsQEF28PHRA1CQ== X-Received: by 2002:a17:903:11c8:b0:1b8:3601:9bf7 with SMTP id q8-20020a17090311c800b001b836019bf7mr22217656plh.24.1689160187849; Wed, 12 Jul 2023 04:09:47 -0700 (PDT) Received: from hsinchu16 (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id w15-20020a1709027b8f00b001b9df74ba5asm3674375pll.210.2023.07.12.04.09.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jul 2023 04:09:47 -0700 (PDT) Date: Wed, 12 Jul 2023 19:09:43 +0800 From: Eric Lin To: Krzysztof Kozlowski Cc: conor@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dslin1010@gmail.com, Zong Li , vincent.chen@sifive.com, Greentime Hu , Palmer Dabbelt , Paul Walmsley Subject: Re: [PATCH 3/3] dt-bindings: riscv: sifive: Add SiFive Private L2 cache controller Message-ID: <20230712110908.GA23216@hsinchu16> References: <20230616063210.19063-1-eric.lin@sifive.com> <20230616063210.19063-4-eric.lin@sifive.com> <2437bda9-bbdb-ad80-7201-1e16e1388890@linaro.org> <8c9ed2d4-83ab-ecc0-a300-e6bc8e2047b6@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Jul 01, 2023 at 10:22:25AM +0200, Krzysztof Kozlowski wrote: > On 28/06/2023 18:31, Eric Lin wrote: > > >>>> > >>>>> + - enum: > >>>>> + - sifive,pL2Cache0 > >>>>> + - sifive,pL2Cache1 > >>>> > >>>> What is "0" and "1" here? What do these compatibles represent? Why they > >>>> do not have any SoC related part? > >>> > >>> The pL2Cache1 has minor changes in hardware, but it can use the same > >>> pl2 cache driver. > >> > >> Then why aren't they compatible? > >> > > > > The pL2Cache1 has removed some unused bits in the register compared to > > pl2Cache0. > > From the hardware perspective, they are not compatible but they can > > share the same pl2 cache driver in software. > > So they are compatible... If they were not compatible, you wouldn't be > able to use the same match in the driver. > > > Thus, we would like to keep both. It would be great if you can provide > > some suggestions. Thanks. > > I propose to make them compatible, like every other piece of SoC. I > don't see any benefit of having them separate. > Hi Krzysztof, Sorry for the late reply. The pl2 cache is our internal platform IP and is not part of any SoC. The reason why this driver is compatible with the hardware "pl2cache0" and hardware "pl2cache1" is that it doesn't program the different parts of the config register However, our internal software (e.g., bare-metal software) will program these different parts, so it needs to rely on the different compatible string to identify the hardware. Additionally, we would like the compatible strings to reflect which hardware is being used Thanks. Best regards, Eric Lin > Best regards, > Krzysztof >