From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A129EB64DD for ; Thu, 13 Jul 2023 07:30:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233860AbjGMHaJ (ORCPT ); Thu, 13 Jul 2023 03:30:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233027AbjGMHaH (ORCPT ); Thu, 13 Jul 2023 03:30:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B923F10E2; Thu, 13 Jul 2023 00:30:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D8B261A2F; Thu, 13 Jul 2023 07:30:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB979C433C8; Thu, 13 Jul 2023 07:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689233405; bh=D6/DZxem2Z8WYv9kYkbX6koNWaeI10YYdIaXvSp15oQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DXuZI0sHGu1nc4xsTQdvxGS2RHO1NYThF++rBLoskt54NvSkaVjBxHL5XXdMkRXLm FigvPaBEW/+OjQLYop1LWDUJV2CIKhbM36N7/F4eLxJSA0tp0YcdDfVyF/MODrygPh GpRrS8DablUq3K0W32ST/54rOVzw32rHEVpYZH9mrrQmbo/jrZpkCCzYRytAzWTHWF KYU+TgkHGHfwWDW8DSYpUmxPHmbgrbWEv7mSNVAIqRSAjs9G5NlMikswZpPI9rCz/s saTqRp7W8z0TTiL/ul4hZJgffsLn7j4IEe80zTHb/ar3vGs/ZHz3P5Xk8RH8hKs3oM e0nHawYv+JNOw== Date: Thu, 13 Jul 2023 00:30:03 -0700 From: Eric Biggers To: Manivannan Sadhasivam Cc: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_asutoshd@quicinc.com, quic_cang@quicinc.com, quic_nitirawa@quicinc.com, quic_narepall@quicinc.com, quic_bhaskarv@quicinc.com, quic_richardp@quicinc.com, quic_nguyenb@quicinc.com, quic_ziqichen@quicinc.com, bmasney@redhat.com, krzysztof.kozlowski@linaro.org Subject: Re: [PATCH 04/14] arm64: dts: qcom: sdm845: Fix the min frequency of "ice_core_clk" Message-ID: <20230713073003.GE2199@sol.localdomain> References: <20230712103213.101770-1-manivannan.sadhasivam@linaro.org> <20230712103213.101770-5-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230712103213.101770-5-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jul 12, 2023 at 04:01:59PM +0530, Manivannan Sadhasivam wrote: > Minimum frequency of the "ice_core_clk" should be 75MHz as specified in the > downstream vendor devicetree. So fix it! > > https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.7.3.r1-09300-sdm845.0/arch/arm64/boot/dts/qcom/sdm845.dtsi > > Fixes: cc16687fbd74 ("arm64: dts: qcom: sdm845: add UFS controller") > Signed-off-by: Manivannan Sadhasivam > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 9ed74bf72d05..89520a9fe1e3 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -2614,7 +2614,7 @@ ufs_mem_hc: ufshc@1d84000 { > <0 0>, > <0 0>, > <0 0>, > - <0 300000000>; > + <75000000 300000000>; Thanks for fixing this! What was the visible effect of this bug, if any? Do you know why the minimum has that particular value? The Fixes tag is wrong; it should be: Fixes: 433f9a57298f ("arm64: dts: sdm845: add Inline Crypto Engine registers and clock") - Eric