* [PATCH] arc: Explicitly include correct DT includes
@ 2023-07-14 17:39 Rob Herring
2023-08-23 17:00 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2023-07-14 17:39 UTC (permalink / raw)
To: Alexey Brodkin, Vineet Gupta; +Cc: devicetree, linux-snps-arc, linux-kernel
The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arc/plat-axs10x/axs10x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
index b821df7b0089..1feb990a56bc 100644
--- a/arch/arc/plat-axs10x/axs10x.c
+++ b/arch/arc/plat-axs10x/axs10x.c
@@ -6,7 +6,6 @@
*/
#include <linux/of_fdt.h>
-#include <linux/of_platform.h>
#include <linux/libfdt.h>
#include <asm/asm-offsets.h>
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arc: Explicitly include correct DT includes
2023-07-14 17:39 [PATCH] arc: Explicitly include correct DT includes Rob Herring
@ 2023-08-23 17:00 ` Rob Herring
2023-08-23 20:43 ` Alexey Brodkin
2023-08-24 1:04 ` Vineet Gupta
0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring @ 2023-08-23 17:00 UTC (permalink / raw)
To: Alexey Brodkin, Vineet Gupta; +Cc: devicetree, linux-snps-arc, linux-kernel
On Fri, Jul 14, 2023 at 11:39:49AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arc/plat-axs10x/axs10x.c | 1 -
> 1 file changed, 1 deletion(-)
Ping!
>
> diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> index b821df7b0089..1feb990a56bc 100644
> --- a/arch/arc/plat-axs10x/axs10x.c
> +++ b/arch/arc/plat-axs10x/axs10x.c
> @@ -6,7 +6,6 @@
> */
>
> #include <linux/of_fdt.h>
> -#include <linux/of_platform.h>
> #include <linux/libfdt.h>
>
> #include <asm/asm-offsets.h>
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arc: Explicitly include correct DT includes
2023-08-23 17:00 ` Rob Herring
@ 2023-08-23 20:43 ` Alexey Brodkin
2023-08-24 1:04 ` Vineet Gupta
1 sibling, 0 replies; 4+ messages in thread
From: Alexey Brodkin @ 2023-08-23 20:43 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org,
linux-kernel@vger.kernel.org, Vineet Gupta
Hi Rob,
> On Fri, Jul 14, 2023 at 11:39:49AM -0600, Rob Herring wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > arch/arc/plat-axs10x/axs10x.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Ping!
Thanks for the enhancement!
Tested-by: Alexey Brodkin <abrodkin@synopsys.com>
>
> >
> > diff --git a/arch/arc/plat-axs10x/axs10x.c b/arch/arc/plat-axs10x/axs10x.c
> > index b821df7b0089..1feb990a56bc 100644
> > --- a/arch/arc/plat-axs10x/axs10x.c
> > +++ b/arch/arc/plat-axs10x/axs10x.c
> > @@ -6,7 +6,6 @@
> > */
> >
> > #include <linux/of_fdt.h>
> > -#include <linux/of_platform.h>
> > #include <linux/libfdt.h>
> >
> > #include <asm/asm-offsets.h>
> > --
> > 2.40.1
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arc: Explicitly include correct DT includes
2023-08-23 17:00 ` Rob Herring
2023-08-23 20:43 ` Alexey Brodkin
@ 2023-08-24 1:04 ` Vineet Gupta
1 sibling, 0 replies; 4+ messages in thread
From: Vineet Gupta @ 2023-08-24 1:04 UTC (permalink / raw)
To: Rob Herring, Alexey Brodkin, Vineet Gupta
Cc: devicetree, linux-snps-arc, linux-kernel
On 8/23/23 10:00, Rob Herring wrote:
> On Fri, Jul 14, 2023 at 11:39:49AM -0600, Rob Herring wrote:
>> The DT of_device.h and of_platform.h date back to the separate
>> of_platform_bus_type before it as merged into the regular platform bus.
>> As part of that merge prepping Arm DT support 13 years ago, they
>> "temporarily" include each other. They also include platform_device.h
>> and of.h. As a result, there's a pretty much random mix of those include
>> files used throughout the tree. In order to detangle these headers and
>> replace the implicit includes with struct declarations, users need to
>> explicitly include the correct includes.
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> arch/arc/plat-axs10x/axs10x.c | 1 -
>> 1 file changed, 1 deletion(-)
> Ping!
Sorry this fell through cracks, added to for-curr now !
Thx,
-Vineet
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-24 1:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-14 17:39 [PATCH] arc: Explicitly include correct DT includes Rob Herring
2023-08-23 17:00 ` Rob Herring
2023-08-23 20:43 ` Alexey Brodkin
2023-08-24 1:04 ` Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).