devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] counter: Explicitly include correct DT includes
@ 2023-07-14 17:43 Rob Herring
  2023-07-24 15:10 ` William Breathitt Gray
  0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring @ 2023-07-14 17:43 UTC (permalink / raw)
  To: Kamel Bouhara, William Breathitt Gray
  Cc: devicetree, linux-arm-kernel, linux-iio, linux-kernel

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 drivers/counter/microchip-tcb-capture.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/counter/microchip-tcb-capture.c b/drivers/counter/microchip-tcb-capture.c
index e2d1dc6ca668..975e431d1590 100644
--- a/drivers/counter/microchip-tcb-capture.c
+++ b/drivers/counter/microchip-tcb-capture.c
@@ -10,7 +10,6 @@
 #include <linux/module.h>
 #include <linux/mutex.h>
 #include <linux/of.h>
-#include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <soc/at91/atmel_tcb.h>
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] counter: Explicitly include correct DT includes
  2023-07-14 17:43 [PATCH] counter: Explicitly include correct DT includes Rob Herring
@ 2023-07-24 15:10 ` William Breathitt Gray
  0 siblings, 0 replies; 2+ messages in thread
From: William Breathitt Gray @ 2023-07-24 15:10 UTC (permalink / raw)
  To: Rob Herring
  Cc: Kamel Bouhara, devicetree, linux-arm-kernel, linux-iio,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 728 bytes --]

On Fri, Jul 14, 2023 at 11:43:57AM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Queued for counter-next.

Thanks,

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-24 15:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-14 17:43 [PATCH] counter: Explicitly include correct DT includes Rob Herring
2023-07-24 15:10 ` William Breathitt Gray

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).