* Re: [PATCH] thermal: Explicitly include correct DT includes
2023-07-14 17:50 ` [PATCH] thermal: Explicitly include correct DT includes Rob Herring
@ 2023-07-14 18:54 ` Rafael J. Wysocki
2023-07-14 19:52 ` Rob Herring
2023-07-17 11:45 ` Alim Akhtar
2023-08-24 15:16 ` Florian Fainelli
2 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2023-07-14 18:54 UTC (permalink / raw)
To: Rob Herring
Cc: Guillaume La Roque, Rafael J. Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Florian Fainelli,
Broadcom internal kernel review list, Markus Mayer, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Thara Gopinath, Niklas Söderlund, Bartlomiej Zolnierkiewicz,
Krzysztof Kozlowski, Alim Akhtar, Orson Zhai, Baolin Wang,
Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
Vasily Khoruzhick, Yangtao Li, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Thierry Reding, Jonathan Hunter, Kunihiko Hayashi,
Masami Hiramatsu, Matthias Brugger, AngeloGioacchino Del Regno,
devicetree, linux-pm, linux-amlogic, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-arm-msm,
linux-renesas-soc, linux-samsung-soc, linux-stm32, linux-sunxi,
linux-tegra, linux-mediatek
On Fri, Jul 14, 2023 at 7:51 PM Rob Herring <robh@kernel.org> wrote:
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
or please let me know if you want me to pick this up.
Thanks!
> ---
> drivers/thermal/amlogic_thermal.c | 2 --
> drivers/thermal/broadcom/bcm2711_thermal.c | 2 +-
> drivers/thermal/broadcom/brcmstb_thermal.c | 2 +-
> drivers/thermal/hisi_thermal.c | 2 +-
> drivers/thermal/imx8mm_thermal.c | 1 -
> drivers/thermal/imx_sc_thermal.c | 1 -
> drivers/thermal/imx_thermal.c | 2 +-
> drivers/thermal/k3_bandgap.c | 2 +-
> drivers/thermal/k3_j72xx_bandgap.c | 2 +-
> drivers/thermal/mediatek/auxadc_thermal.c | 1 -
> drivers/thermal/mediatek/lvts_thermal.c | 2 +-
> drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 1 -
> drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 -
> drivers/thermal/rcar_gen3_thermal.c | 2 +-
> drivers/thermal/rcar_thermal.c | 2 +-
> drivers/thermal/rzg2l_thermal.c | 2 +-
> drivers/thermal/samsung/exynos_tmu.c | 2 +-
> drivers/thermal/sprd_thermal.c | 2 +-
> drivers/thermal/st/stm_thermal.c | 2 --
> drivers/thermal/sun8i_thermal.c | 2 +-
> drivers/thermal/tegra/tegra30-tsensor.c | 2 +-
> drivers/thermal/thermal_of.c | 3 +--
> drivers/thermal/uniphier_thermal.c | 1 -
> 23 files changed, 15 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
> index 756b218880a7..81ebbf6de0de 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -22,8 +22,6 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_address.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/broadcom/bcm2711_thermal.c b/drivers/thermal/broadcom/bcm2711_thermal.c
> index c243a76a3471..03ac2d02e9d4 100644
> --- a/drivers/thermal/broadcom/bcm2711_thermal.c
> +++ b/drivers/thermal/broadcom/bcm2711_thermal.c
> @@ -15,8 +15,8 @@
> #include <linux/kernel.h>
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> -#include <linux/of_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
>
> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> index 72d1dbe60b8f..0b73abdaa792 100644
> --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -17,8 +17,8 @@
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> -#include <linux/of_device.h>
> #include <linux/thermal.h>
>
> #define AVS_TMON_STATUS 0x00
> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
> index 3f09ef8be41a..fb54ed4bf6f0 100644
> --- a/drivers/thermal/hisi_thermal.c
> +++ b/drivers/thermal/hisi_thermal.c
> @@ -13,9 +13,9 @@
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/io.h>
> -#include <linux/of_device.h>
> #include <linux/thermal.h>
>
> #define HI6220_TEMP0_LAG (0x0)
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index d4b40869c7d7..e89b11b3f2b9 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -12,7 +12,6 @@
> #include <linux/module.h>
> #include <linux/nvmem-consumer.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c
> index 8d6b4ef23746..7224f8d21db9 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -8,7 +8,6 @@
> #include <linux/firmware/imx/sci.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index a94ec0a0c9dd..826358cbe810 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -11,7 +11,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> #include <linux/nvmem-consumer.h>
> diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c
> index 1c3e590157ec..68f59b3735d3 100644
> --- a/drivers/thermal/k3_bandgap.c
> +++ b/drivers/thermal/k3_bandgap.c
> @@ -11,7 +11,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/thermal.h>
> #include <linux/types.h>
> diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c
> index 5be1f09eeb2c..a5a0fc9b9356 100644
> --- a/drivers/thermal/k3_j72xx_bandgap.c
> +++ b/drivers/thermal/k3_j72xx_bandgap.c
> @@ -10,10 +10,10 @@
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/kernel.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/err.h>
> #include <linux/types.h>
> -#include <linux/of_platform.h>
> #include <linux/io.h>
> #include <linux/thermal.h>
> #include <linux/of.h>
> diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> index f59d36de20a0..c537aed71017 100644
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -15,7 +15,6 @@
> #include <linux/nvmem-consumer.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/io.h>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index b693fac2d677..054c965ae5e1 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -13,7 +13,7 @@
> #include <linux/iopoll.h>
> #include <linux/kernel.h>
> #include <linux/nvmem-consumer.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/reset.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> index 5ddc39b2be32..756ac6842ff9 100644
> --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> @@ -14,7 +14,6 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> index 0e8ebfcd84c5..78c5cfe6a0c0 100644
> --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> @@ -10,7 +10,6 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
> index 9029d01e029b..bd2fb8c2e968 100644
> --- a/drivers/thermal/rcar_gen3_thermal.c
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -11,7 +11,7 @@
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index b8571f7090aa..293f8dd9fe0a 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -11,7 +11,7 @@
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/reboot.h>
> diff --git a/drivers/thermal/rzg2l_thermal.c b/drivers/thermal/rzg2l_thermal.c
> index b56981f85306..6b2bf3426f52 100644
> --- a/drivers/thermal/rzg2l_thermal.c
> +++ b/drivers/thermal/rzg2l_thermal.c
> @@ -9,8 +9,8 @@
> #include <linux/io.h>
> #include <linux/iopoll.h>
> #include <linux/math.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/reset.h>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 45e5c840d130..58f4d8f7a3fd 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -15,7 +15,7 @@
> #include <linux/io.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_irq.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index 2fb90fdad76e..e27c4bdc8912 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -6,7 +6,7 @@
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/nvmem-consumer.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/st/stm_thermal.c b/drivers/thermal/st/stm_thermal.c
> index 903fcf1763f1..142a7e5d12f4 100644
> --- a/drivers/thermal/st/stm_thermal.c
> +++ b/drivers/thermal/st/stm_thermal.c
> @@ -14,8 +14,6 @@
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_address.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/thermal.h>
>
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 195f3c5d0b38..cca16d632d9f 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -14,7 +14,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/nvmem-consumer.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/tegra/tegra30-tsensor.c
> index c243e9d76d3c..d911fa60f100 100644
> --- a/drivers/thermal/tegra/tegra30-tsensor.c
> +++ b/drivers/thermal/tegra/tegra30-tsensor.c
> @@ -18,7 +18,7 @@
> #include <linux/iopoll.h>
> #include <linux/math.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm.h>
> #include <linux/reset.h>
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> index 6fb14e521197..c36c7d235cba 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -10,8 +10,7 @@
>
> #include <linux/err.h>
> #include <linux/export.h>
> -#include <linux/of_device.h>
> -#include <linux/of_platform.h>
> +#include <linux/of.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
> #include <linux/types.h>
> diff --git a/drivers/thermal/uniphier_thermal.c b/drivers/thermal/uniphier_thermal.c
> index aef6119cc004..6f32ab61d174 100644
> --- a/drivers/thermal/uniphier_thermal.c
> +++ b/drivers/thermal/uniphier_thermal.c
> @@ -12,7 +12,6 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] thermal: Explicitly include correct DT includes
2023-07-14 18:54 ` Rafael J. Wysocki
@ 2023-07-14 19:52 ` Rob Herring
2023-07-20 18:50 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2023-07-14 19:52 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Guillaume La Roque, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Florian Fainelli, Broadcom internal kernel review list,
Markus Mayer, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Thara Gopinath, Niklas Söderlund,
Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski, Alim Akhtar,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Vasily Khoruzhick, Yangtao Li, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Thierry Reding, Jonathan Hunter,
Kunihiko Hayashi, Masami Hiramatsu, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-pm, linux-amlogic,
linux-kernel, linux-rpi-kernel, linux-arm-kernel, linux-arm-msm,
linux-renesas-soc, linux-samsung-soc, linux-stm32, linux-sunxi,
linux-tegra, linux-mediatek
On Fri, Jul 14, 2023 at 12:54 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Fri, Jul 14, 2023 at 7:51 PM Rob Herring <robh@kernel.org> wrote:
> >
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Acked-by: Rafael J. Wysocki <rafael@kernel.org>
>
> or please let me know if you want me to pick this up.
Single patch in your subsystem with no dependencies. Please pick it up.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] thermal: Explicitly include correct DT includes
2023-07-14 19:52 ` Rob Herring
@ 2023-07-20 18:50 ` Rafael J. Wysocki
2023-08-22 22:38 ` Rob Herring
0 siblings, 1 reply; 8+ messages in thread
From: Rafael J. Wysocki @ 2023-07-20 18:50 UTC (permalink / raw)
To: Rob Herring
Cc: Rafael J. Wysocki, Guillaume La Roque, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Florian Fainelli,
Broadcom internal kernel review list, Markus Mayer, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Thara Gopinath, Niklas Söderlund, Bartlomiej Zolnierkiewicz,
Krzysztof Kozlowski, Alim Akhtar, Orson Zhai, Baolin Wang,
Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
Vasily Khoruzhick, Yangtao Li, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Thierry Reding, Jonathan Hunter, Kunihiko Hayashi,
Masami Hiramatsu, Matthias Brugger, AngeloGioacchino Del Regno,
devicetree, linux-pm, linux-amlogic, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-arm-msm,
linux-renesas-soc, linux-samsung-soc, linux-stm32, linux-sunxi,
linux-tegra, linux-mediatek
On Fri, Jul 14, 2023 at 9:53 PM Rob Herring <robh@kernel.org> wrote:
>
> On Fri, Jul 14, 2023 at 12:54 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Fri, Jul 14, 2023 at 7:51 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > The DT of_device.h and of_platform.h date back to the separate
> > > of_platform_bus_type before it as merged into the regular platform bus.
> > > As part of that merge prepping Arm DT support 13 years ago, they
> > > "temporarily" include each other. They also include platform_device.h
> > > and of.h. As a result, there's a pretty much random mix of those include
> > > files used throughout the tree. In order to detangle these headers and
> > > replace the implicit includes with struct declarations, users need to
> > > explicitly include the correct includes.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> >
> > or please let me know if you want me to pick this up.
>
> Single patch in your subsystem with no dependencies. Please pick it up.
Done, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] thermal: Explicitly include correct DT includes
2023-07-20 18:50 ` Rafael J. Wysocki
@ 2023-08-22 22:38 ` Rob Herring
2023-08-23 12:31 ` Rafael J. Wysocki
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2023-08-22 22:38 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Guillaume La Roque, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Florian Fainelli, Broadcom internal kernel review list,
Markus Mayer, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Thara Gopinath, Niklas Söderlund,
Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski, Alim Akhtar,
Orson Zhai, Baolin Wang, Chunyan Zhang, Maxime Coquelin,
Alexandre Torgue, Vasily Khoruzhick, Yangtao Li, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Thierry Reding, Jonathan Hunter,
Kunihiko Hayashi, Masami Hiramatsu, Matthias Brugger,
AngeloGioacchino Del Regno, devicetree, linux-pm, linux-amlogic,
linux-kernel, linux-rpi-kernel, linux-arm-kernel, linux-arm-msm,
linux-renesas-soc, linux-samsung-soc, linux-stm32, linux-sunxi,
linux-tegra, linux-mediatek
On Thu, Jul 20, 2023 at 1:50 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Fri, Jul 14, 2023 at 9:53 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Fri, Jul 14, 2023 at 12:54 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> > >
> > > On Fri, Jul 14, 2023 at 7:51 PM Rob Herring <robh@kernel.org> wrote:
> > > >
> > > > The DT of_device.h and of_platform.h date back to the separate
> > > > of_platform_bus_type before it as merged into the regular platform bus.
> > > > As part of that merge prepping Arm DT support 13 years ago, they
> > > > "temporarily" include each other. They also include platform_device.h
> > > > and of.h. As a result, there's a pretty much random mix of those include
> > > > files used throughout the tree. In order to detangle these headers and
> > > > replace the implicit includes with struct declarations, users need to
> > > > explicitly include the correct includes.
> > > >
> > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > >
> > > Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> > >
> > > or please let me know if you want me to pick this up.
> >
> > Single patch in your subsystem with no dependencies. Please pick it up.
>
> Done, thanks!
I'm not seeing this in linux-next.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] thermal: Explicitly include correct DT includes
2023-08-22 22:38 ` Rob Herring
@ 2023-08-23 12:31 ` Rafael J. Wysocki
0 siblings, 0 replies; 8+ messages in thread
From: Rafael J. Wysocki @ 2023-08-23 12:31 UTC (permalink / raw)
To: Rob Herring
Cc: Rafael J. Wysocki, Guillaume La Roque, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Florian Fainelli,
Broadcom internal kernel review list, Markus Mayer, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Thara Gopinath, Niklas Söderlund, Bartlomiej Zolnierkiewicz,
Krzysztof Kozlowski, Alim Akhtar, Orson Zhai, Baolin Wang,
Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
Vasily Khoruzhick, Yangtao Li, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Thierry Reding, Jonathan Hunter, Kunihiko Hayashi,
Masami Hiramatsu, Matthias Brugger, AngeloGioacchino Del Regno,
devicetree, linux-pm, linux-amlogic, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-arm-msm,
linux-renesas-soc, linux-samsung-soc, linux-stm32, linux-sunxi,
linux-tegra, linux-mediatek
On Wed, Aug 23, 2023 at 12:38 AM Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Jul 20, 2023 at 1:50 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Fri, Jul 14, 2023 at 9:53 PM Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Fri, Jul 14, 2023 at 12:54 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> > > >
> > > > On Fri, Jul 14, 2023 at 7:51 PM Rob Herring <robh@kernel.org> wrote:
> > > > >
> > > > > The DT of_device.h and of_platform.h date back to the separate
> > > > > of_platform_bus_type before it as merged into the regular platform bus.
> > > > > As part of that merge prepping Arm DT support 13 years ago, they
> > > > > "temporarily" include each other. They also include platform_device.h
> > > > > and of.h. As a result, there's a pretty much random mix of those include
> > > > > files used throughout the tree. In order to detangle these headers and
> > > > > replace the implicit includes with struct declarations, users need to
> > > > > explicitly include the correct includes.
> > > > >
> > > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > >
> > > > Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> > > >
> > > > or please let me know if you want me to pick this up.
> > >
> > > Single patch in your subsystem with no dependencies. Please pick it up.
> >
> > Done, thanks!
>
> I'm not seeing this in linux-next.
f6a756e8fb12 thermal: Explicitly include correct DT includes
It's there in my linux-next branch (and in my thermal branch) and it
should be there in linux-next too.
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] thermal: Explicitly include correct DT includes
2023-07-14 17:50 ` [PATCH] thermal: Explicitly include correct DT includes Rob Herring
2023-07-14 18:54 ` Rafael J. Wysocki
@ 2023-07-17 11:45 ` Alim Akhtar
2023-08-24 15:16 ` Florian Fainelli
2 siblings, 0 replies; 8+ messages in thread
From: Alim Akhtar @ 2023-07-17 11:45 UTC (permalink / raw)
To: 'Rob Herring', 'Guillaume La Roque',
'Rafael J. Wysocki', 'Daniel Lezcano',
'Amit Kucheria', 'Zhang Rui',
'Florian Fainelli',
'Broadcom internal kernel review list',
'Markus Mayer', 'Shawn Guo',
'Sascha Hauer', 'Pengutronix Kernel Team',
'Fabio Estevam', 'NXP Linux Team',
'Andy Gross', 'Bjorn Andersson',
'Konrad Dybcio', 'Thara Gopinath',
'Niklas Söderlund',
'Bartlomiej Zolnierkiewicz',
'Krzysztof Kozlowski', 'Orson Zhai',
'Baolin Wang', 'Chunyan Zhang',
'Maxime Coquelin', 'Alexandre Torgue',
'Vasily Khoruzhick', 'Yangtao Li',
'Chen-Yu Tsai', 'Jernej Skrabec',
'Samuel Holland', 'Thierry Reding',
'Jonathan Hunter', 'Kunihiko Hayashi',
'Masami Hiramatsu', 'Matthias Brugger',
'AngeloGioacchino Del Regno'
Cc: devicetree, linux-pm, linux-amlogic, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-arm-msm,
linux-renesas-soc, linux-samsung-soc, linux-stm32, linux-sunxi,
linux-tegra, linux-mediatek
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, July 14, 2023 11:20 PM
> To: Guillaume La Roque <glaroque@baylibre.com>; Rafael J. Wysocki
> <rafael@kernel.org>; Daniel Lezcano <daniel.lezcano@linaro.org>; Amit
> Kucheria <amitk@kernel.org>; Zhang Rui <rui.zhang@intel.com>; Florian Fainelli
> <florian.fainelli@broadcom.com>; Broadcom internal kernel review list <bcm-
> kernel-feedback-list@broadcom.com>; Markus Mayer
> <mmayer@broadcom.com>; Shawn Guo <shawnguo@kernel.org>; Sascha
> Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; NXP Linux
> Team <linux-imx@nxp.com>; Andy Gross <agross@kernel.org>; Bjorn Andersson
> <andersson@kernel.org>; Konrad Dybcio <konrad.dybcio@linaro.org>; Thara
> Gopinath <thara.gopinath@gmail.com>; Niklas Söderlund
> <niklas.soderlund@ragnatech.se>; Bartlomiej Zolnierkiewicz
> <bzolnier@gmail.com>; Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>;
> Alim Akhtar <alim.akhtar@samsung.com>; Orson Zhai <orsonzhai@gmail.com>;
> Baolin Wang <baolin.wang@linux.alibaba.com>; Chunyan Zhang
> <zhang.lyra@gmail.com>; Maxime Coquelin <mcoquelin.stm32@gmail.com>;
> Alexandre Torgue <alexandre.torgue@foss.st.com>; Vasily Khoruzhick
> <anarsoul@gmail.com>; Yangtao Li <tiny.windzz@gmail.com>; Chen-Yu Tsai
> <wens@csie.org>; Jernej Skrabec <jernej.skrabec@gmail.com>; Samuel Holland
> <samuel@sholland.org>; Thierry Reding <thierry.reding@gmail.com>; Jonathan
> Hunter <jonathanh@nvidia.com>; Kunihiko Hayashi
> <hayashi.kunihiko@socionext.com>; Masami Hiramatsu
> <mhiramat@kernel.org>; Matthias Brugger <matthias.bgg@gmail.com>;
> AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Cc: devicetree@vger.kernel.org; linux-pm@vger.kernel.org; linux-
> amlogic@lists.infradead.org; linux-kernel@vger.kernel.org; linux-rpi-
> kernel@lists.infradead.org; linux-arm-kernel@lists.infradead.org; linux-arm-
> msm@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-samsung-
> soc@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; linux-
> sunxi@lists.linux.dev; linux-tegra@vger.kernel.org; linux-
> mediatek@lists.infradead.org
> Subject: [PATCH] thermal: Explicitly include correct DT includes
>
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they "temporarily"
> include each other. They also include platform_device.h and of.h. As a result,
> there's a pretty much random mix of those include files used throughout the
> tree. In order to detangle these headers and replace the implicit includes with
> struct declarations, users need to explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/thermal/amlogic_thermal.c | 2 --
> drivers/thermal/broadcom/bcm2711_thermal.c | 2 +-
> drivers/thermal/broadcom/brcmstb_thermal.c | 2 +-
> drivers/thermal/hisi_thermal.c | 2 +-
> drivers/thermal/imx8mm_thermal.c | 1 -
> drivers/thermal/imx_sc_thermal.c | 1 -
> drivers/thermal/imx_thermal.c | 2 +-
> drivers/thermal/k3_bandgap.c | 2 +-
> drivers/thermal/k3_j72xx_bandgap.c | 2 +-
> drivers/thermal/mediatek/auxadc_thermal.c | 1 -
> drivers/thermal/mediatek/lvts_thermal.c | 2 +-
> drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 1 -
> drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 -
> drivers/thermal/rcar_gen3_thermal.c | 2 +-
> drivers/thermal/rcar_thermal.c | 2 +-
> drivers/thermal/rzg2l_thermal.c | 2 +-
> drivers/thermal/samsung/exynos_tmu.c | 2 +-
For Samsung/ Exynos
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/thermal/sprd_thermal.c | 2 +-
> drivers/thermal/st/stm_thermal.c | 2 --
> drivers/thermal/sun8i_thermal.c | 2 +-
> drivers/thermal/tegra/tegra30-tsensor.c | 2 +-
> drivers/thermal/thermal_of.c | 3 +--
> drivers/thermal/uniphier_thermal.c | 1 -
> 23 files changed, 15 insertions(+), 26 deletions(-)
>
> diff --git a/drivers/thermal/amlogic_thermal.c
> b/drivers/thermal/amlogic_thermal.c
> index 756b218880a7..81ebbf6de0de 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -22,8 +22,6 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_address.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/broadcom/bcm2711_thermal.c
> b/drivers/thermal/broadcom/bcm2711_thermal.c
> index c243a76a3471..03ac2d02e9d4 100644
> --- a/drivers/thermal/broadcom/bcm2711_thermal.c
> +++ b/drivers/thermal/broadcom/bcm2711_thermal.c
> @@ -15,8 +15,8 @@
> #include <linux/kernel.h>
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> -#include <linux/of_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
>
> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c
> b/drivers/thermal/broadcom/brcmstb_thermal.c
> index 72d1dbe60b8f..0b73abdaa792 100644
> --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -17,8 +17,8 @@
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> -#include <linux/of_device.h>
> #include <linux/thermal.h>
>
> #define AVS_TMON_STATUS 0x00
> diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
> index 3f09ef8be41a..fb54ed4bf6f0 100644
> --- a/drivers/thermal/hisi_thermal.c
> +++ b/drivers/thermal/hisi_thermal.c
> @@ -13,9 +13,9 @@
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/io.h>
> -#include <linux/of_device.h>
> #include <linux/thermal.h>
>
> #define HI6220_TEMP0_LAG (0x0)
> diff --git a/drivers/thermal/imx8mm_thermal.c
> b/drivers/thermal/imx8mm_thermal.c
> index d4b40869c7d7..e89b11b3f2b9 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -12,7 +12,6 @@
> #include <linux/module.h>
> #include <linux/nvmem-consumer.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/imx_sc_thermal.c
> b/drivers/thermal/imx_sc_thermal.c
> index 8d6b4ef23746..7224f8d21db9 100644
> --- a/drivers/thermal/imx_sc_thermal.c
> +++ b/drivers/thermal/imx_sc_thermal.c
> @@ -8,7 +8,6 @@
> #include <linux/firmware/imx/sci.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
> index a94ec0a0c9dd..826358cbe810 100644
> --- a/drivers/thermal/imx_thermal.c
> +++ b/drivers/thermal/imx_thermal.c
> @@ -11,7 +11,7 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> #include <linux/nvmem-consumer.h>
> diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c index
> 1c3e590157ec..68f59b3735d3 100644
> --- a/drivers/thermal/k3_bandgap.c
> +++ b/drivers/thermal/k3_bandgap.c
> @@ -11,7 +11,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/thermal.h>
> #include <linux/types.h>
> diff --git a/drivers/thermal/k3_j72xx_bandgap.c
> b/drivers/thermal/k3_j72xx_bandgap.c
> index 5be1f09eeb2c..a5a0fc9b9356 100644
> --- a/drivers/thermal/k3_j72xx_bandgap.c
> +++ b/drivers/thermal/k3_j72xx_bandgap.c
> @@ -10,10 +10,10 @@
> #include <linux/module.h>
> #include <linux/init.h>
> #include <linux/kernel.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/err.h>
> #include <linux/types.h>
> -#include <linux/of_platform.h>
> #include <linux/io.h>
> #include <linux/thermal.h>
> #include <linux/of.h>
> diff --git a/drivers/thermal/mediatek/auxadc_thermal.c
> b/drivers/thermal/mediatek/auxadc_thermal.c
> index f59d36de20a0..c537aed71017 100644
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -15,7 +15,6 @@
> #include <linux/nvmem-consumer.h>
> #include <linux/of.h>
> #include <linux/of_address.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/io.h>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c
> b/drivers/thermal/mediatek/lvts_thermal.c
> index b693fac2d677..054c965ae5e1 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -13,7 +13,7 @@
> #include <linux/iopoll.h>
> #include <linux/kernel.h>
> #include <linux/nvmem-consumer.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/reset.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> index 5ddc39b2be32..756ac6842ff9 100644
> --- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> +++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
> @@ -14,7 +14,6 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> index 0e8ebfcd84c5..78c5cfe6a0c0 100644
> --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> @@ -10,7 +10,6 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/rcar_gen3_thermal.c
> b/drivers/thermal/rcar_gen3_thermal.c
> index 9029d01e029b..bd2fb8c2e968 100644
> --- a/drivers/thermal/rcar_gen3_thermal.c
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -11,7 +11,7 @@
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index b8571f7090aa..293f8dd9fe0a 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -11,7 +11,7 @@
> #include <linux/interrupt.h>
> #include <linux/io.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/reboot.h>
> diff --git a/drivers/thermal/rzg2l_thermal.c b/drivers/thermal/rzg2l_thermal.c
> index b56981f85306..6b2bf3426f52 100644
> --- a/drivers/thermal/rzg2l_thermal.c
> +++ b/drivers/thermal/rzg2l_thermal.c
> @@ -9,8 +9,8 @@
> #include <linux/io.h>
> #include <linux/iopoll.h>
> #include <linux/math.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <linux/reset.h>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c
> b/drivers/thermal/samsung/exynos_tmu.c
> index 45e5c840d130..58f4d8f7a3fd 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -15,7 +15,7 @@
> #include <linux/io.h>
> #include <linux/interrupt.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/of_address.h>
> #include <linux/of_irq.h>
> #include <linux/platform_device.h>
> diff --git a/drivers/thermal/sprd_thermal.c b/drivers/thermal/sprd_thermal.c
> index 2fb90fdad76e..e27c4bdc8912 100644
> --- a/drivers/thermal/sprd_thermal.c
> +++ b/drivers/thermal/sprd_thermal.c
> @@ -6,7 +6,7 @@
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/nvmem-consumer.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
> diff --git a/drivers/thermal/st/stm_thermal.c
> b/drivers/thermal/st/stm_thermal.c
> index 903fcf1763f1..142a7e5d12f4 100644
> --- a/drivers/thermal/st/stm_thermal.c
> +++ b/drivers/thermal/st/stm_thermal.c
> @@ -14,8 +14,6 @@
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_address.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/thermal.h>
>
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 195f3c5d0b38..cca16d632d9f 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -14,7 +14,7 @@
> #include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/nvmem-consumer.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> diff --git a/drivers/thermal/tegra/tegra30-tsensor.c
> b/drivers/thermal/tegra/tegra30-tsensor.c
> index c243e9d76d3c..d911fa60f100 100644
> --- a/drivers/thermal/tegra/tegra30-tsensor.c
> +++ b/drivers/thermal/tegra/tegra30-tsensor.c
> @@ -18,7 +18,7 @@
> #include <linux/iopoll.h>
> #include <linux/math.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm.h>
> #include <linux/reset.h>
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c index
> 6fb14e521197..c36c7d235cba 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -10,8 +10,7 @@
>
> #include <linux/err.h>
> #include <linux/export.h>
> -#include <linux/of_device.h>
> -#include <linux/of_platform.h>
> +#include <linux/of.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
> #include <linux/types.h>
> diff --git a/drivers/thermal/uniphier_thermal.c
> b/drivers/thermal/uniphier_thermal.c
> index aef6119cc004..6f32ab61d174 100644
> --- a/drivers/thermal/uniphier_thermal.c
> +++ b/drivers/thermal/uniphier_thermal.c
> @@ -12,7 +12,6 @@
> #include <linux/mfd/syscon.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> #include <linux/thermal.h>
> --
> 2.40.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] thermal: Explicitly include correct DT includes
2023-07-14 17:50 ` [PATCH] thermal: Explicitly include correct DT includes Rob Herring
2023-07-14 18:54 ` Rafael J. Wysocki
2023-07-17 11:45 ` Alim Akhtar
@ 2023-08-24 15:16 ` Florian Fainelli
2 siblings, 0 replies; 8+ messages in thread
From: Florian Fainelli @ 2023-08-24 15:16 UTC (permalink / raw)
To: Rob Herring, Guillaume La Roque, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui,
Broadcom internal kernel review list, Markus Mayer, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Thara Gopinath, Niklas Söderlund, Bartlomiej Zolnierkiewicz,
Krzysztof Kozlowski, Alim Akhtar, Orson Zhai, Baolin Wang,
Chunyan Zhang, Maxime Coquelin, Alexandre Torgue,
Vasily Khoruzhick, Yangtao Li, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Thierry Reding, Jonathan Hunter, Kunihiko Hayashi,
Masami Hiramatsu, Matthias Brugger, AngeloGioacchino Del Regno
Cc: devicetree, linux-pm, linux-amlogic, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-arm-msm,
linux-renesas-soc, linux-samsung-soc, linux-stm32, linux-sunxi,
linux-tegra, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
On 7/14/2023 10:50 AM, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/thermal/amlogic_thermal.c | 2 --
> drivers/thermal/broadcom/bcm2711_thermal.c | 2 +-
> drivers/thermal/broadcom/brcmstb_thermal.c | 2 +-
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> # broadcom
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread