devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	 linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	 Konrad Dybcio <konrad.dybcio@linaro.org>,
	 Johan Hovold <johan+linaro@kernel.org>,
	 Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: [PATCH v4 01/12] clk: qcom: branch: Add a helper for setting the enable bit
Date: Sat, 30 Dec 2023 14:04:03 +0100	[thread overview]
Message-ID: <20230717-topic-branch_aon_cleanup-v4-1-32c293ded915@linaro.org> (raw)
In-Reply-To: <20230717-topic-branch_aon_cleanup-v4-0-32c293ded915@linaro.org>

We hardcode some clocks to be always-on, as they're essential to the
functioning of the SoC / some peripherals. Add a helper to do so
to make the writes less magic.

Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/clk/qcom/clk-branch.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/clk/qcom/clk-branch.h b/drivers/clk/qcom/clk-branch.h
index 8ffed603c050..0514bc43100b 100644
--- a/drivers/clk/qcom/clk-branch.h
+++ b/drivers/clk/qcom/clk-branch.h
@@ -64,6 +64,7 @@ struct clk_mem_branch {
 #define CBCR_FORCE_MEM_PERIPH_OFF	BIT(12)
 #define CBCR_WAKEUP			GENMASK(11, 8)
 #define CBCR_SLEEP			GENMASK(7, 4)
+#define CBCR_CLOCK_ENABLE		BIT(0)
 
 static inline void qcom_branch_set_force_mem_core(struct regmap *regmap,
 						  struct clk_branch clk, bool on)
@@ -98,6 +99,12 @@ static inline void qcom_branch_set_sleep(struct regmap *regmap, struct clk_branc
 			   FIELD_PREP(CBCR_SLEEP, val));
 }
 
+static inline void qcom_branch_set_clk_en(struct regmap *regmap, u32 cbcr)
+{
+	regmap_update_bits(regmap, cbcr, CBCR_CLOCK_ENABLE,
+			   CBCR_CLOCK_ENABLE);
+}
+
 extern const struct clk_ops clk_branch_ops;
 extern const struct clk_ops clk_branch2_ops;
 extern const struct clk_ops clk_branch_simple_ops;

-- 
2.43.0


  reply	other threads:[~2023-12-30 13:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-30 13:04 [PATCH v4 00/12] Unregister critical branch clocks + some RPM Konrad Dybcio
2023-12-30 13:04 ` Konrad Dybcio [this message]
2023-12-30 13:04 ` [PATCH v4 02/12] clk: qcom: Use qcom_branch_set_clk_en() Konrad Dybcio
2024-01-02 10:35   ` Johan Hovold
2024-01-02 14:27     ` Konrad Dybcio
2024-01-03 10:18       ` Johan Hovold
2023-12-30 13:04 ` [PATCH v4 03/12] clk: qcom: gcc-sm6375: Unregister critical clocks Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 04/12] clk: qcom: gpucc-sm6375: " Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 05/12] clk: qcom: gpucc-sm6115: " Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 06/12] clk: qcom: gpucc-sm6115: Add runtime PM Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 07/12] clk: qcom: gcc-sm6115: Unregister critical clocks Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 08/12] clk: qcom: gcc-qcm2290: " Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 09/12] arm64: dts: qcom: sm6375: Add VDD_CX to GCC Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 10/12] arm64: dts: qcom: qcm2290: " Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 11/12] arm64: dts: qcom: sm6115: " Konrad Dybcio
2023-12-30 13:04 ` [PATCH v4 12/12] arm64: dts: qcom: sm6115: Add VDD_CX to GPU_CC Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230717-topic-branch_aon_cleanup-v4-1-32c293ded915@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).