* [PATCH v2] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions
@ 2023-07-17 6:58 Dylan Hung
2023-07-17 18:42 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Dylan Hung @ 2023-07-17 6:58 UTC (permalink / raw)
To: mturquette, sboyd, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-clk, devicetree, linux-kernel
Cc: BMC-SW
Add reset definitions of AST2600 I3C and MAC controllers.
Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
---
include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
index e149eee61588..712782177c90 100644
--- a/include/dt-bindings/clock/ast2600-clock.h
+++ b/include/dt-bindings/clock/ast2600-clock.h
@@ -90,7 +90,19 @@
/* Only list resets here that are not part of a clock gate + reset pair */
#define ASPEED_RESET_ADC 55
#define ASPEED_RESET_JTAG_MASTER2 54
+
+#define ASPEED_RESET_MAC4 53
+#define ASPEED_RESET_MAC3 52
+
+#define ASPEED_RESET_I3C5 45
+#define ASPEED_RESET_I3C4 44
+#define ASPEED_RESET_I3C3 43
+#define ASPEED_RESET_I3C2 42
+#define ASPEED_RESET_I3C1 41
+#define ASPEED_RESET_I3C0 40
+#define ASPEED_RESET_I3C 39
#define ASPEED_RESET_I3C_DMA 39
+
#define ASPEED_RESET_PWM 37
#define ASPEED_RESET_PECI 36
#define ASPEED_RESET_MII 35
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions
2023-07-17 6:58 [PATCH v2] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions Dylan Hung
@ 2023-07-17 18:42 ` Conor Dooley
0 siblings, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2023-07-17 18:42 UTC (permalink / raw)
To: Dylan Hung
Cc: mturquette, sboyd, robh+dt, krzysztof.kozlowski+dt, conor+dt,
linux-clk, devicetree, linux-kernel, BMC-SW
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Mon, Jul 17, 2023 at 02:58:58PM +0800, Dylan Hung wrote:
> Add reset definitions of AST2600 I3C and MAC controllers.
>
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
> ---
> include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
What changed compared to v1?
Are there any users of the additional resets (eg, in a dts somewhere)?
Thanks,
Conor.
>
> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
> index e149eee61588..712782177c90 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -90,7 +90,19 @@
> /* Only list resets here that are not part of a clock gate + reset pair */
> #define ASPEED_RESET_ADC 55
> #define ASPEED_RESET_JTAG_MASTER2 54
> +
> +#define ASPEED_RESET_MAC4 53
> +#define ASPEED_RESET_MAC3 52
> +
> +#define ASPEED_RESET_I3C5 45
> +#define ASPEED_RESET_I3C4 44
> +#define ASPEED_RESET_I3C3 43
> +#define ASPEED_RESET_I3C2 42
> +#define ASPEED_RESET_I3C1 41
> +#define ASPEED_RESET_I3C0 40
> +#define ASPEED_RESET_I3C 39
> #define ASPEED_RESET_I3C_DMA 39
> +
> #define ASPEED_RESET_PWM 37
> #define ASPEED_RESET_PECI 36
> #define ASPEED_RESET_MII 35
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CAKohO550=Nq3HvGj_4_CxBHxBv+HjXQpBOHC9jZAGPgyseX=bA@mail.gmail.com>]
* Re: [PATCH v2] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions
[not found] <CAKohO550=Nq3HvGj_4_CxBHxBv+HjXQpBOHC9jZAGPgyseX=bA@mail.gmail.com>
@ 2023-07-18 2:07 ` Chih-Jen Hung
0 siblings, 0 replies; 3+ messages in thread
From: Chih-Jen Hung @ 2023-07-18 2:07 UTC (permalink / raw)
To: Conor Dooley
Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, BMC-SW, Chih-Jen Hung
Chih-Jen Hung <kobedylan@gmail.com> 於 2023年7月18日 週二 上午9:59寫道：
>
> On Mon, Jul 17, 2023 at 02:58:58PM +0800, Dylan Hung wrote:
>
> Add reset definitions of AST2600 I3C and MAC controllers.
>
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
> ---
> include/dt-bindings/clock/ast2600-clock.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>
> What changed compared to v1?
> Are there any users of the additional resets (eg, in a dts somewhere)?
>
> Thanks,
> Conor.
An existing macro, ASPEED_RESET_I3C_DMA, was removed in V1. However,
considering that this macro may be used somewhere, I have decided to
add it back in V2. I will ensure to include the changelog in V3.
>
>
> diff --git a/include/dt-bindings/clock/ast2600-clock.h
> b/include/dt-bindings/clock/ast2600-clock.h
> index e149eee61588..712782177c90 100644
> --- a/include/dt-bindings/clock/ast2600-clock.h
> +++ b/include/dt-bindings/clock/ast2600-clock.h
> @@ -90,7 +90,19 @@
> /* Only list resets here that are not part of a clock gate + reset pair */
> #define ASPEED_RESET_ADC 55
> #define ASPEED_RESET_JTAG_MASTER2 54
> +
> +#define ASPEED_RESET_MAC4 53
> +#define ASPEED_RESET_MAC3 52
> +
> +#define ASPEED_RESET_I3C5 45
> +#define ASPEED_RESET_I3C4 44
> +#define ASPEED_RESET_I3C3 43
> +#define ASPEED_RESET_I3C2 42
> +#define ASPEED_RESET_I3C1 41
> +#define ASPEED_RESET_I3C0 40
> +#define ASPEED_RESET_I3C 39
> #define ASPEED_RESET_I3C_DMA 39
This is the macro I added back in V2. There is no reset-line hardware
available for `ASPEED_RESET_I3C_DMA`, so I have added a new macro to
provide a better representation of the hardware design. I will include
the explanation in the commit message of V3.
> +
> #define ASPEED_RESET_PWM 37
> #define ASPEED_RESET_PECI 36
> #define ASPEED_RESET_MII 35
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-18 2:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 6:58 [PATCH v2] dt-bindings: clock: ast2600: Add I3C and MAC reset definitions Dylan Hung
2023-07-17 18:42 ` Conor Dooley
[not found] <CAKohO550=Nq3HvGj_4_CxBHxBv+HjXQpBOHC9jZAGPgyseX=bA@mail.gmail.com>
2023-07-18 2:07 ` Chih-Jen Hung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).