From: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Michal Simek <michal.simek@amd.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Tanmay Shah <tanmay.shah@amd.com>,
Ben Levinsky <ben.levinsky@amd.com>, Marek Vasut <marex@denx.de>,
Roman Gushchin <roman.gushchin@linux.dev>,
Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <saikrishna12468@gmail.com>,
<git@amd.com>,
Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Subject: [PATCH 0/4] ipinctrl: pinctrl-zynqmp: Add tri-state configuration support
Date: Mon, 17 Jul 2023 15:03:43 +0530 [thread overview]
Message-ID: <20230717093347.3869167-1-sai.krishna.potthuri@amd.com> (raw)
Add pinctrl driver support to handle 'output-enable' and
'bias-high-impedance' configurations with proper Configuration Set version
check. This will ensure system not to crash even if older Xilinx ZynqMP
Platform Management Firmware is used.
Initial Commit details:
Commit 133ad0d9af99bdca9070 ("dt-bindings: pinctrl-zynqmp: Add
output-enable configuration").
Commit ad2bea79ef0144043721 ("pinctrl: pinctrl-zynqmp: Add support
for output-enable and bias-high-impedance").
With the above patches, using these pinctrl properties in the device-tree
cause system hang issues with older Xilinx ZynqMP Platform Management
Firmware, hence reverted the patches.
Reverted Commit details:
Commit ff8356060e3a5e126abb ("Revert "dt-bindings: pinctrl-zynqmp: Add
output-enable configuration"").
Commit 9989bc33c4894e075167 ("Revert "pinctrl: pinctrl-zynqmp: Add support
for output-enable and bias-high-impedance"").
With the latest firmware and driver changes, driver will ask firmware if
that feature is supported or not by checking the version. This way it
works with all Xilinx firmwares.
Dhaval Shah (1):
firmware: xilinx: Add support to get platform information
Sai Krishna Potthuri (3):
firmware: xilinx: Add version check for TRISTATE configuration
dt-bindings: pinctrl-zynqmp: Add output-enable configuration
pinctrl: pinctrl-zynqmp: Add support for output-enable and bias-high
impedance
.../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml | 4 ++
drivers/firmware/xilinx/zynqmp.c | 51 +++++++++++++++++++
drivers/pinctrl/pinctrl-zynqmp.c | 9 ++++
include/linux/firmware/xlnx-zynqmp.h | 15 ++++++
4 files changed, 79 insertions(+)
--
2.25.1
next reply other threads:[~2023-07-17 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 9:33 Sai Krishna Potthuri [this message]
2023-07-17 9:33 ` [PATCH 1/4] firmware: xilinx: Add support to get platform information Sai Krishna Potthuri
2023-07-17 9:33 ` [PATCH 2/4] firmware: xilinx: Add version check for TRISTATE configuration Sai Krishna Potthuri
2023-07-17 9:33 ` [PATCH 3/4] dt-bindings: pinctrl-zynqmp: Add output-enable configuration Sai Krishna Potthuri
2023-07-18 15:50 ` Conor Dooley
2023-07-19 6:49 ` Potthuri, Sai Krishna
2023-07-19 16:02 ` Conor Dooley
2023-07-17 9:33 ` [PATCH 4/4] pinctrl: pinctrl-zynqmp: Add support for output-enable and bias-high impedance Sai Krishna Potthuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717093347.3869167-1-sai.krishna.potthuri@amd.com \
--to=sai.krishna.potthuri@amd.com \
--cc=arnd@arndb.de \
--cc=ben.levinsky@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=saikrishna12468@gmail.com \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox