From: Herve Codina <herve.codina@bootlin.com>
To: unlisted-recipients:; (no To-header on input)
Cc: shumingf@realtek.com, flatmax@flatmax.com,
ckeepax@opensource.cirrus.com, doug@schmorgal.com,
fido_max@inbox.ru, pierre-louis.bossart@linux.intel.com,
kiseok.jo@irondevice.com, liweilei@awinic.com,
colin.i.king@gmail.com, trix@redhat.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, yijiangtao@awinic.com,
zhangjianming@awinic.com
Subject: Re: [PATCH V1 0/5] ASoC: codecs: Add Awinic AW88261 audio amplifier driver
Date: Mon, 17 Jul 2023 15:03:51 +0200 [thread overview]
Message-ID: <20230717145456.5afee0cf@bootlin.com> (raw)
In-Reply-To: <20230717115845.297991-1-wangweidong.a@awinic.com>
Hi Weidong,
On Mon, 17 Jul 2023 19:58:40 +0800
wangweidong.a@awinic.com wrote:
> From: Weidong Wang <wangweidong.a@awinic.com>
>
> The AW88261 is an I2S/TDM input, high efficiency
> digital Smart K audio amplifier with an integrated 10.25V
> smart boost convert
>
> Add a DT schema for describing Awinic aw88261 audio amplifiers. They are
> controlled using I2C.
>
> Weidong Wang (5):
> ASoC: codecs: Add i2c and codec registration for aw88261 and their
> associated operation functions
> ASoC: codecs: aw88261 function for ALSA Audio Driver
> ASoC: codecs: ACF bin parsing and check library file for aw88261
> ASoC: codecs: aw88261 chip register file, data type file and Kconfig
> Makefile
> ASoC: dt-bindings: Add schema for "awinic,aw88261"
>
> .../bindings/sound/awinic,aw88261.yaml | 53 +
> sound/soc/codecs/Kconfig | 17 +
> sound/soc/codecs/Makefile | 5 +
> sound/soc/codecs/aw88261/aw88261.c | 539 ++++++++++
> sound/soc/codecs/aw88261/aw88261.h | 52 +
> sound/soc/codecs/aw88261/aw88261_data_type.h | 144 +++
> sound/soc/codecs/aw88261/aw88261_device.c | 959 +++++++++++++++++
> sound/soc/codecs/aw88261/aw88261_device.h | 114 ++
> sound/soc/codecs/aw88261/aw88261_lib.c | 997 ++++++++++++++++++
> sound/soc/codecs/aw88261/aw88261_lib.h | 91 ++
> sound/soc/codecs/aw88261/aw88261_reg.h | 377 +++++++
> 11 files changed, 3348 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/awinic,aw88261.yaml
> create mode 100644 sound/soc/codecs/aw88261/aw88261.c
> create mode 100644 sound/soc/codecs/aw88261/aw88261.h
> create mode 100644 sound/soc/codecs/aw88261/aw88261_data_type.h
> create mode 100644 sound/soc/codecs/aw88261/aw88261_device.c
> create mode 100644 sound/soc/codecs/aw88261/aw88261_device.h
> create mode 100644 sound/soc/codecs/aw88261/aw88261_lib.c
> create mode 100644 sound/soc/codecs/aw88261/aw88261_lib.h
> create mode 100644 sound/soc/codecs/aw88261/aw88261_reg.h
>
>
> base-commit: 8d7868c41df58edabc4e408d119a1aef58a54d9d
A lot of code looks pretty similar (the same ?) to what was done for aw88395
sound/soc/codecs/aw88395/
Is there a way to use common code instead of duplication ?
Best regards,
Hervé Codina
prev parent reply other threads:[~2023-07-17 13:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 11:58 [PATCH V1 0/5] ASoC: codecs: Add Awinic AW88261 audio amplifier driver wangweidong.a
2023-07-17 11:58 ` [PATCH V1 1/5] ASoC: codecs: Add i2c and codec registration for aw88261 and their associated operation functions wangweidong.a
2023-07-17 20:33 ` Krzysztof Kozlowski
2023-07-19 3:06 ` wangweidong.a
2023-07-17 11:58 ` [PATCH V1 2/5] ASoC: codecs: aw88261 function for ALSA Audio Driver wangweidong.a
2023-07-17 20:39 ` Krzysztof Kozlowski
2023-07-19 3:09 ` wangweidong.a
2023-07-19 6:24 ` Krzysztof Kozlowski
2023-07-17 11:58 ` [PATCH V1 3/5] ASoC: codecs: ACF bin parsing and check library file for aw88261 wangweidong.a
2023-07-17 20:40 ` Krzysztof Kozlowski
2023-07-19 3:12 ` wangweidong.a
2023-07-19 6:23 ` Krzysztof Kozlowski
2023-07-17 11:58 ` [PATCH V1 4/5] ASoC: codecs: aw88261 chip register file, data type file and Kconfig Makefile wangweidong.a
2023-07-17 12:33 ` Randy Dunlap
2023-07-19 2:59 ` wangweidong.a
2023-07-17 11:58 ` [PATCH V1 5/5] ASoC: dt-bindings: Add schema for "awinic,aw88261" wangweidong.a
2023-07-17 20:23 ` Krzysztof Kozlowski
2023-07-19 3:02 ` wangweidong.a
2023-07-17 13:03 ` Herve Codina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717145456.5afee0cf@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=colin.i.king@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=doug@schmorgal.com \
--cc=fido_max@inbox.ru \
--cc=flatmax@flatmax.com \
--cc=kiseok.jo@irondevice.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shumingf@realtek.com \
--cc=trix@redhat.com \
--cc=yijiangtao@awinic.com \
--cc=zhangjianming@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).