From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C34EB64DC for ; Tue, 18 Jul 2023 03:31:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229525AbjGRDaz (ORCPT ); Mon, 17 Jul 2023 23:30:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229835AbjGRDa2 (ORCPT ); Mon, 17 Jul 2023 23:30:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83E391710; Mon, 17 Jul 2023 20:30:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1F3716141C; Tue, 18 Jul 2023 03:30:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A581C433C7; Tue, 18 Jul 2023 03:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689651026; bh=z+z9lW6mMexaY47FcTYWGmyseM0LmHw63WGw8AdFcCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m1LZVjPnDleC88cvMsPdvzalcfvzcb33HSio8liy2crAtXjJghJAKf1sACl1O4N9D Lcic5xV7hagW0s48QR7SLC707JC0zZ8gC0ZmbKAkixqHiJ9KtuAO+mXDm3QpHGqGdg FXMFsP0WUv4Sd3q/s9c+6Tz53jatEB7Aah9ePo2G6h8qaZBhjnifQD53Sib2rX0yi+ 7DrcgvbkxWH9j6nwM3Le3XfjAtvrzZFWy2JjLnYijKLLMBwMKB24LwMRS2VvVW0VXk 7x0IeRhmKKcshvKr6qQNu4O6TpgwLS7Zk5pw0tO7H+fSZ9l1J8hdGcMP3YOc83qmni 3waDHRMWSFHVQ== Date: Tue, 18 Jul 2023 11:30:15 +0800 From: Shawn Guo To: "Peng Fan (OSS)" Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai Subject: Re: [PATCH 03/10] arm64: dts: imx8ulp: add thermal node Message-ID: <20230718033015.GD9559@dragon> References: <20230625124238.4071717-1-peng.fan@oss.nxp.com> <20230625124238.4071717-4-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230625124238.4071717-4-peng.fan@oss.nxp.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Jun 25, 2023 at 08:42:31PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Add thermal node. Cooling map is not added, because frequency runtime > changing not supported for now. > > Reviewed-by: Jacky Bai > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > index ba0edb9a009b..fd30475a561d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > > #include "imx8ulp-pinfunc.h" > > @@ -78,6 +79,27 @@ psci { > method = "smc"; > }; > > + thermal-zones { > + cpu-thermal { > + polling-delay-passive = <250>; > + polling-delay = <2000>; > + thermal-sensors = <&scmi_sensor 0>; Have a newline between property list and child node. Shawn > + trips { > + cpu_alert0: trip0 { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu_crit0: trip1 { > + temperature = <95000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + }; > + > timer { > compatible = "arm,armv8-timer"; > interrupts = , /* Physical Secure */ > -- > 2.37.1 >