From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAC50EB64DC for ; Tue, 18 Jul 2023 06:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230356AbjGRGiG (ORCPT ); Tue, 18 Jul 2023 02:38:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231130AbjGRGiF (ORCPT ); Tue, 18 Jul 2023 02:38:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D71D10E2; Mon, 17 Jul 2023 23:37:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF2CE61484; Tue, 18 Jul 2023 06:37:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A2E2C433CA; Tue, 18 Jul 2023 06:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689662272; bh=lkqYV4xx86Ti2v26sOBZLYVym3rSZZUqRoPkM+IKoIw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ErVVeclVfGNmw++ELI2ou+/DJlthBIAb8F+aOVs2HNeAeXox2fhR4yU/63Vldz/Ho fX2HnwwDRgt44w5Hxp7h5qjarW2E4bzDoLsCzKwvckViiTKS8rRMXIT7lUpCmBiMQ4 cqvAv6Er76p9wv3yLZND7LmDKTf/V40xIEhm9ZE+4//X6h3x4rU8yb+OE/NhajahNH UtbKFVmFqB9NkvULpl+OBVFo66DEdz5hyu0yQ/nNktnKdWXttolPgyewitgThonTCs YxcLZLGCx3c4aEYC5K5N7/rQ7LRoM5fOVpYY7H0fdJ39deYqsa9Qp4FaGKCkH0SGjM W3IKaoLF/9IIg== Date: Tue, 18 Jul 2023 14:37:15 +0800 From: Shawn Guo To: Hugo Villeneuve Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Hugo Villeneuve , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: imx8mn-var-som-symphony: fix USB OTG Message-ID: <20230718063715.GL9559@dragon> References: <20230705174932.3652479-1-hugo@hugovil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705174932.3652479-1-hugo@hugovil.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jul 05, 2023 at 01:49:32PM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > USB OTG is currently broken on the Variscite Symphony EVK and imx8mn > nano SOM. > > The PTN5150 circuitry on newer versions of the Symphony EVK board has > a non-standard configuration in which the PTN5150 IRQ pin is left > unconnected, and the PTN5150 ID pin is connected to GPIO1_IO11. This > requires changes to the ptn5150 driver to support this new mode. > Variscite have indicated their intention to submit those changes > upstream. > > In the meantime, import device tree changes from linux-5.15 branch of > varigit repos to at least make the USB OTG port operate correctly in > host mode. > > Fixes: 7358e05bddca ("arm64: dts: imx8mn-var-som-symphony: Add Variscite Symphony board with VAR-SOM-MX8MN") Has USB OTG been ever worked at all? If the answer is no, it's not a fix but a new feature, and I would suggest you rework the patch subject and drop the Fixes tag. Shawn > Signed-off-by: Hugo Villeneuve > --- > Link: [v1] https://lkml.org/lkml/2023/7/4/702 > > Changes from v1: > - Add comments about PTN5150 IRQ/ID line connections > - Remove "typec1_con: connector" node > - Change IRQ type to IRQ_TYPE_EDGE_FALLING > > .../dts/freescale/imx8mn-var-som-symphony.dts | 32 +++++++++++++++++-- > 1 file changed, 30 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > index 406a711486da..a7a57442cb81 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony.dts > @@ -1,11 +1,14 @@ > // SPDX-License-Identifier: (GPL-2.0+ OR MIT) > /* > + * Supports Symphony evaluation board versions >= 1.4a. > + * > * Copyright 2019-2020 Variscite Ltd. > * Copyright (C) 2020 Krzysztof Kozlowski > */ > > /dts-v1/; > > +#include > #include "imx8mn-var-som.dtsi" > > / { > @@ -100,14 +103,26 @@ enet-sel-hog { > }; > }; > > + /* > + * For Symphony board version <= 1.4, the PTN5150 IRQ pin is connected > + * to GPIO1_IO11 on the SoM (R106 present, R132 absent). From Symphony > + * board version >= 1.4a, the PTN5150 ID pin is connected to GPIO1_IO11 > + * on the SoM (R106 absent, R132 present). > + */ > extcon_usbotg1: typec@3d { > compatible = "nxp,ptn5150"; > reg = <0x3d>; > interrupt-parent = <&gpio1>; > - interrupts = <11 IRQ_TYPE_LEVEL_LOW>; > + interrupts = <11 IRQ_TYPE_EDGE_FALLING>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_ptn5150>; > status = "okay"; > + > + port { > + typec1_dr_sw: endpoint { > + remote-endpoint = <&usb1_drd_sw>; > + }; > + }; > }; > }; > > @@ -148,8 +163,21 @@ &uart3 { > }; > > &usbotg1 { > + dr_mode = "otg"; > + hnp-disable; > + srp-disable; > + adp-disable; > + usb-role-switch; > disable-over-current; > - extcon = <&extcon_usbotg1>, <&extcon_usbotg1>; > + samsung,picophy-pre-emp-curr-control = <3>; > + samsung,picophy-dc-vol-level-adjust = <7>; > + status = "okay"; > + > + port { > + usb1_drd_sw: endpoint { > + remote-endpoint = <&typec1_dr_sw>; > + }; > + }; > }; > > &iomuxc { > > base-commit: d528014517f2b0531862c02865b9d4c908019dc4 > -- > 2.30.2 >