* [PATCHv3 0/2] update at91 usart compatible for sam9x60 @ 2023-07-18 6:57 Durai Manickam KR 2023-07-18 6:57 ` [PATCHv3 1/2] dt-bindings: serial: atmel,at91-usart: update " Durai Manickam KR 2023-07-18 6:57 ` [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection Durai Manickam KR 0 siblings, 2 replies; 4+ messages in thread From: Durai Manickam KR @ 2023-07-18 6:57 UTC (permalink / raw) To: Hari.PrasathGE, balamanikandan.gunasundar, manikandan.m, varshini.rajendran, dharma.b, nayabbasha.sayed, balakrishnan.s, cristian.birsan, nicolas.ferre, krzysztof.kozlowski, alexandre.belloni, davem, arnd, olof, soc, devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri, Horatiu.Vultur, robh+dt, andrew, michael, jerry.ray, conor+dt, jesper.nilsson, andre.przywara, ada, radu_nicolae.pirea, richard.genoud, gregkh, linux-spi, linux-serial Cc: Durai Manickam KR There is only one debug unit in the sam9x60 SOC and it has the chipid register. So defining these dbgu compatible strings to the flexcom usart is not correct and causes the SOC detection failure. So removing these dbgu compatible strings defined under the flexcom usart and updating the yaml file accordingly. --- v2 changes: 1. Updating the dt-bindings documentation and send one more patch for the yaml file. --- v3 change: 1. Explained the issue in the commit message rather than in the cover letter. Added the detailed commit message for the changes done. --- Durai Manickam KR (2): dt-bindings: serial: atmel,at91-usart: update compatible for sam9x60 ARM: dts: at91: sam9x60: fix the SOC detection .../bindings/serial/atmel,at91-usart.yaml | 4 ++- arch/arm/boot/dts/microchip/sam9x60.dtsi | 26 +++++++++---------- 2 files changed, 16 insertions(+), 14 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCHv3 1/2] dt-bindings: serial: atmel,at91-usart: update compatible for sam9x60 2023-07-18 6:57 [PATCHv3 0/2] update at91 usart compatible for sam9x60 Durai Manickam KR @ 2023-07-18 6:57 ` Durai Manickam KR 2023-07-18 6:57 ` [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection Durai Manickam KR 1 sibling, 0 replies; 4+ messages in thread From: Durai Manickam KR @ 2023-07-18 6:57 UTC (permalink / raw) To: Hari.PrasathGE, balamanikandan.gunasundar, manikandan.m, varshini.rajendran, dharma.b, nayabbasha.sayed, balakrishnan.s, cristian.birsan, nicolas.ferre, krzysztof.kozlowski, alexandre.belloni, davem, arnd, olof, soc, devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri, Horatiu.Vultur, robh+dt, andrew, michael, jerry.ray, conor+dt, jesper.nilsson, andre.przywara, ada, radu_nicolae.pirea, richard.genoud, gregkh, linux-spi, linux-serial Cc: Durai Manickam KR There is only one debug unit in the sam9x60 SOC and it has the chipid register. So, the dbgu compatible strings are valid only for debug usart. Defining these dbgu compatible strings are not valid for flexcom usart. So adding the items which is valid only for flexcom usart and removing the microchip,sam9x60-usart compatible string from the enum list as no usart node defines only this specific compatible string. Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com> --- .../devicetree/bindings/serial/atmel,at91-usart.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml index 30b2131b5860..65cb2e5c5eee 100644 --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml @@ -16,13 +16,15 @@ properties: - enum: - atmel,at91rm9200-usart - atmel,at91sam9260-usart - - microchip,sam9x60-usart - items: - const: atmel,at91rm9200-dbgu - const: atmel,at91rm9200-usart - items: - const: atmel,at91sam9260-dbgu - const: atmel,at91sam9260-usart + - items: + - const: microchip,sam9x60-usart + - const: atmel,at91sam9260-usart - items: - const: microchip,sam9x60-dbgu - const: microchip,sam9x60-usart -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection 2023-07-18 6:57 [PATCHv3 0/2] update at91 usart compatible for sam9x60 Durai Manickam KR 2023-07-18 6:57 ` [PATCHv3 1/2] dt-bindings: serial: atmel,at91-usart: update " Durai Manickam KR @ 2023-07-18 6:57 ` Durai Manickam KR 2023-07-31 13:35 ` Alexander Dahl 1 sibling, 1 reply; 4+ messages in thread From: Durai Manickam KR @ 2023-07-18 6:57 UTC (permalink / raw) To: Hari.PrasathGE, balamanikandan.gunasundar, manikandan.m, varshini.rajendran, dharma.b, nayabbasha.sayed, balakrishnan.s, cristian.birsan, nicolas.ferre, krzysztof.kozlowski, alexandre.belloni, davem, arnd, olof, soc, devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri, Horatiu.Vultur, robh+dt, andrew, michael, jerry.ray, conor+dt, jesper.nilsson, andre.przywara, ada, radu_nicolae.pirea, richard.genoud, gregkh, linux-spi, linux-serial Cc: Durai Manickam KR Defining the dbgu compatible strings in the UART submodule of the flexcom gives the below error log, AT91: Could not find matching SoC description This error arises due to defining the dbgu compatible strings to the flexcom usart which is not valid because there is only one debug unit in the sam9x60 SOC and it has the chipid register. The dbgu compatible strings are valid only for debug usart and not valid for flexcom usart. Thus removing the dbgu compatible strings in the UART submodule of the flexcom for the proper SOC detection. Fixes: 99c808335877 (ARM: dts: at91: sam9x60: Add missing flexcom definitions) Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com> --- arch/arm/boot/dts/microchip/sam9x60.dtsi | 26 ++++++++++++------------ 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi index 8b53997675e7..73d570a17269 100644 --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi @@ -172,7 +172,7 @@ flx4: flexcom@f0000000 { status = "disabled"; uart4: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -240,7 +240,7 @@ flx5: flexcom@f0004000 { status = "disabled"; uart5: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; atmel,usart-mode = <AT91_USART_MODE_SERIAL>; interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>; @@ -370,7 +370,7 @@ flx11: flexcom@f0020000 { status = "disabled"; uart11: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -419,7 +419,7 @@ flx12: flexcom@f0024000 { status = "disabled"; uart12: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -576,7 +576,7 @@ flx6: flexcom@f8010000 { status = "disabled"; uart6: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -625,7 +625,7 @@ flx7: flexcom@f8014000 { status = "disabled"; uart7: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -674,7 +674,7 @@ flx8: flexcom@f8018000 { status = "disabled"; uart8: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -723,7 +723,7 @@ flx0: flexcom@f801c000 { status = "disabled"; uart0: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -791,7 +791,7 @@ flx1: flexcom@f8020000 { status = "disabled"; uart1: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -859,7 +859,7 @@ flx2: flexcom@f8024000 { status = "disabled"; uart2: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -927,7 +927,7 @@ flx3: flexcom@f8028000 { status = "disabled"; uart3: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -1050,7 +1050,7 @@ flx9: flexcom@f8040000 { status = "disabled"; uart9: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 @@ -1099,7 +1099,7 @@ flx10: flexcom@f8044000 { status = "disabled"; uart10: serial@200 { - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; reg = <0x200 0x200>; interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>; dmas = <&dma0 -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection 2023-07-18 6:57 ` [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection Durai Manickam KR @ 2023-07-31 13:35 ` Alexander Dahl 0 siblings, 0 replies; 4+ messages in thread From: Alexander Dahl @ 2023-07-31 13:35 UTC (permalink / raw) To: Durai Manickam KR Cc: Hari.PrasathGE, balamanikandan.gunasundar, manikandan.m, varshini.rajendran, dharma.b, nayabbasha.sayed, balakrishnan.s, cristian.birsan, nicolas.ferre, krzysztof.kozlowski, alexandre.belloni, davem, arnd, olof, soc, devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri, Horatiu.Vultur, robh+dt, andrew, michael, jerry.ray, conor+dt, jesper.nilsson, andre.przywara, ada, radu_nicolae.pirea, richard.genoud, gregkh, linux-spi, linux-serial Hello Durai, Am Tue, Jul 18, 2023 at 12:27:35PM +0530 schrieb Durai Manickam KR: > Defining the dbgu compatible strings in the UART submodule of the > flexcom gives the below error log, > AT91: Could not find matching SoC description > This error arises due to defining the dbgu compatible strings to > the flexcom usart which is not valid because there is only one debug unit > in the sam9x60 SOC and it has the chipid register. The dbgu compatible > strings are valid only for debug usart and not valid for flexcom usart. > Thus removing the dbgu compatible strings in the UART submodule of the > flexcom for the proper SOC detection. > > Fixes: 99c808335877 (ARM: dts: at91: sam9x60: Add missing flexcom definitions) > Signed-off-by: Durai Manickam KR <durai.manickamkr@microchip.com> Acked-by: Alexander Dahl <ada@thorsis.com> (The diff of the patch is identical to the diff of a quick hacked patch I made weeks ago for my BSP which fixed the issue. SoC variant was reported correctly on serial console on boot again. However I did not actually test *your* patch on my hardware (sam9x60 curiosity), thus Acked-by and not Tested-by.) Greets Alex > --- > arch/arm/boot/dts/microchip/sam9x60.dtsi | 26 ++++++++++++------------ > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/arch/arm/boot/dts/microchip/sam9x60.dtsi b/arch/arm/boot/dts/microchip/sam9x60.dtsi > index 8b53997675e7..73d570a17269 100644 > --- a/arch/arm/boot/dts/microchip/sam9x60.dtsi > +++ b/arch/arm/boot/dts/microchip/sam9x60.dtsi > @@ -172,7 +172,7 @@ flx4: flexcom@f0000000 { > status = "disabled"; > > uart4: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <13 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -240,7 +240,7 @@ flx5: flexcom@f0004000 { > status = "disabled"; > > uart5: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > atmel,usart-mode = <AT91_USART_MODE_SERIAL>; > interrupts = <14 IRQ_TYPE_LEVEL_HIGH 7>; > @@ -370,7 +370,7 @@ flx11: flexcom@f0020000 { > status = "disabled"; > > uart11: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <32 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -419,7 +419,7 @@ flx12: flexcom@f0024000 { > status = "disabled"; > > uart12: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <33 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -576,7 +576,7 @@ flx6: flexcom@f8010000 { > status = "disabled"; > > uart6: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <9 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -625,7 +625,7 @@ flx7: flexcom@f8014000 { > status = "disabled"; > > uart7: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <10 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -674,7 +674,7 @@ flx8: flexcom@f8018000 { > status = "disabled"; > > uart8: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <11 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -723,7 +723,7 @@ flx0: flexcom@f801c000 { > status = "disabled"; > > uart0: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <5 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -791,7 +791,7 @@ flx1: flexcom@f8020000 { > status = "disabled"; > > uart1: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <6 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -859,7 +859,7 @@ flx2: flexcom@f8024000 { > status = "disabled"; > > uart2: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <7 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -927,7 +927,7 @@ flx3: flexcom@f8028000 { > status = "disabled"; > > uart3: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <8 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -1050,7 +1050,7 @@ flx9: flexcom@f8040000 { > status = "disabled"; > > uart9: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <15 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > @@ -1099,7 +1099,7 @@ flx10: flexcom@f8044000 { > status = "disabled"; > > uart10: serial@200 { > - compatible = "microchip,sam9x60-dbgu", "microchip,sam9x60-usart", "atmel,at91sam9260-dbgu", "atmel,at91sam9260-usart"; > + compatible = "microchip,sam9x60-usart", "atmel,at91sam9260-usart"; > reg = <0x200 0x200>; > interrupts = <16 IRQ_TYPE_LEVEL_HIGH 7>; > dmas = <&dma0 > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-31 13:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-07-18 6:57 [PATCHv3 0/2] update at91 usart compatible for sam9x60 Durai Manickam KR 2023-07-18 6:57 ` [PATCHv3 1/2] dt-bindings: serial: atmel,at91-usart: update " Durai Manickam KR 2023-07-18 6:57 ` [PATCHv3 2/2] ARM: dts: at91: sam9x60: fix the SOC detection Durai Manickam KR 2023-07-31 13:35 ` Alexander Dahl
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).