From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08515EB64DA for ; Tue, 18 Jul 2023 15:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233022AbjGRPsB (ORCPT ); Tue, 18 Jul 2023 11:48:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233105AbjGRPru (ORCPT ); Tue, 18 Jul 2023 11:47:50 -0400 Received: from mailrelay6-1.pub.mailoutpod2-cph3.one.com (mailrelay6-1.pub.mailoutpod2-cph3.one.com [46.30.211.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2E07BB for ; Tue, 18 Jul 2023 08:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=SPDU5kPWAAgPJ4oaKrt1JSYg4VjyFkkAo26/4HsJa04=; b=dLsM4dKkdPGEHfWhE3vOWnFlgqVcbUyXZFIoRiB/sV84rIprOtRr96GG5UiY7rQPW2Ga+rHh+MiZm OGndJTN+MK6X0+EncQLeUWmTInpQOJALijDi8u7SecoAqs+Nd5Sx6EhoSt1Xus1NTKsfKw/a6kCQNT 8dfK+wUCKqBJLVM1AMgGxEIhOZU6HT1HuzvQUlcbBfhTq9aTbimXYpbC4tLA6ZZsY871YPtEgk4pYY /advwv9+3ZzFLVjfrKdDKRoRb2pk3cMIwlOD7koEju4ysS7pFM/8q64GJXrGTsazm1+EfEJwccSxUD LkEQHA4RNjKEvAf/fNbe47i7J1S0YqA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=SPDU5kPWAAgPJ4oaKrt1JSYg4VjyFkkAo26/4HsJa04=; b=D8EVbIV6H9KKEcuAqA4UX2ud8rTkGapXb7xDfioVd2x2qEvtJTYdzfwETPQFuaCb0ZyBBXolk6RU2 ejcFqvTAA== X-HalOne-ID: 4bc5dc98-2582-11ee-b1c1-6f01c1d0a443 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay6 (Halon) with ESMTPSA id 4bc5dc98-2582-11ee-b1c1-6f01c1d0a443; Tue, 18 Jul 2023 15:46:45 +0000 (UTC) Date: Tue, 18 Jul 2023 17:46:44 +0200 From: Sam Ravnborg To: Ying Liu Cc: Alexander Stein , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "neil.armstrong@linaro.org" , "conor+dt@kernel.org" , "rfoss@kernel.org" , "andrzej.hajda@intel.com" , "jonas@kwiboo.se" , "s.hauer@pengutronix.de" , "jernej.skrabec@gmail.com" , "robh+dt@kernel.org" , "Laurent.pinchart@ideasonboard.com" , "krzysztof.kozlowski+dt@linaro.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" , dl-linux-imx Subject: Re: [PATCH 9/9] drm/bridge: imx: Add i.MX93 MIPI DSI support Message-ID: <20230718154644.GD688726@ravnborg.org> References: <20230717061831.1826878-1-victor.liu@nxp.com> <20230717061831.1826878-10-victor.liu@nxp.com> <3174425.5fSG56mABF@steina-w> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Ying Liu, On Tue, Jul 18, 2023 at 09:00:25AM +0000, Ying Liu wrote: > > > + if (IS_ERR(dsi->regmap)) { > > > + ret = PTR_ERR(dsi->regmap); > > > + DRM_DEV_ERROR(dev, "failed to get block ctrl regmap: > > %d\n", ret); > > > > Could you use dev_err_probe here instead? > > Maybe, it's better to keep using DRM_DEV_ERROR to achieve consistent > error log format across the driver which is implemented in drm_dev_printk(). > I see other DRM drivers do the same. All the DRM_* macros are deprecated. New code shall use drm_*, dev_* or pr_ as appropriate. The appropriate variant here is dev_err_probe(). Sam