* [PATCH 0/2] gpio: sifive: Module support
@ 2023-07-17 20:53 Samuel Holland
2023-07-17 20:53 ` [PATCH 1/2] of/irq: Export of_irq_count() Samuel Holland
2023-07-17 22:18 ` [PATCH 0/2] gpio: sifive: Module support Palmer Dabbelt
0 siblings, 2 replies; 5+ messages in thread
From: Samuel Holland @ 2023-07-17 20:53 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Frank Rowand
Cc: Samuel Holland, Palmer Dabbelt, Paul Walmsley, devicetree,
linux-gpio, linux-kernel, linux-riscv
With of_irq_count() exported, the SiFive GPIO driver can be built as a
module. This helps to minimize the size of a multiplatform kernel, and
is required by some downstream distributions (Android GKI).
Samuel Holland (2):
of/irq: Export of_irq_count()
gpio: sifive: Allow building the driver as a module
drivers/gpio/Kconfig | 2 +-
drivers/gpio/gpio-sifive.c | 4 +++-
drivers/of/irq.c | 1 +
3 files changed, 5 insertions(+), 2 deletions(-)
--
2.40.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] of/irq: Export of_irq_count()
2023-07-17 20:53 [PATCH 0/2] gpio: sifive: Module support Samuel Holland
@ 2023-07-17 20:53 ` Samuel Holland
2023-07-17 21:40 ` Andy Shevchenko
2023-07-17 22:18 ` [PATCH 0/2] gpio: sifive: Module support Palmer Dabbelt
1 sibling, 1 reply; 5+ messages in thread
From: Samuel Holland @ 2023-07-17 20:53 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Frank Rowand
Cc: Samuel Holland, devicetree, linux-kernel
This function is used by the SiFive GPIO driver. Export it so that
driver can be built as a module.
Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
---
drivers/of/irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 174900072c18..9cea7632dd6a 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -489,6 +489,7 @@ int of_irq_count(struct device_node *dev)
return nr;
}
+EXPORT_SYMBOL_GPL(of_irq_count);
/**
* of_irq_to_resource_table - Fill in resource table with node's IRQ info
--
2.40.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] of/irq: Export of_irq_count()
2023-07-17 20:53 ` [PATCH 1/2] of/irq: Export of_irq_count() Samuel Holland
@ 2023-07-17 21:40 ` Andy Shevchenko
2023-07-18 22:42 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2023-07-17 21:40 UTC (permalink / raw)
To: Samuel Holland
Cc: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Frank Rowand, devicetree, linux-kernel
On Mon, Jul 17, 2023 at 11:54 PM Samuel Holland
<samuel.holland@sifive.com> wrote:
>
> This function is used by the SiFive GPIO driver. Export it so that
> driver can be built as a module.
Can we rather reduce use of of_*() APIs?
For example, why not use platform_irq_count()?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] of/irq: Export of_irq_count()
2023-07-17 21:40 ` Andy Shevchenko
@ 2023-07-18 22:42 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2023-07-18 22:42 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Samuel Holland, Linus Walleij, Bartosz Golaszewski,
Andy Shevchenko, Frank Rowand, devicetree, linux-kernel
On Tue, Jul 18, 2023 at 12:40:53AM +0300, Andy Shevchenko wrote:
> On Mon, Jul 17, 2023 at 11:54 PM Samuel Holland
> <samuel.holland@sifive.com> wrote:
> >
> > This function is used by the SiFive GPIO driver. Export it so that
> > driver can be built as a module.
>
> Can we rather reduce use of of_*() APIs?
> For example, why not use platform_irq_count()?
+1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/2] gpio: sifive: Module support
2023-07-17 20:53 [PATCH 0/2] gpio: sifive: Module support Samuel Holland
2023-07-17 20:53 ` [PATCH 1/2] of/irq: Export of_irq_count() Samuel Holland
@ 2023-07-17 22:18 ` Palmer Dabbelt
1 sibling, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2023-07-17 22:18 UTC (permalink / raw)
To: samuel.holland
Cc: linus.walleij, brgl, andy, robh+dt, frowand.list, samuel.holland,
Paul Walmsley, devicetree, linux-gpio, linux-kernel, linux-riscv
On Mon, 17 Jul 2023 13:53:55 PDT (-0700), samuel.holland@sifive.com wrote:
> With of_irq_count() exported, the SiFive GPIO driver can be built as a
> module. This helps to minimize the size of a multiplatform kernel, and
> is required by some downstream distributions (Android GKI).
>
>
> Samuel Holland (2):
> of/irq: Export of_irq_count()
> gpio: sifive: Allow building the driver as a module
>
> drivers/gpio/Kconfig | 2 +-
> drivers/gpio/gpio-sifive.c | 4 +++-
> drivers/of/irq.c | 1 +
> 3 files changed, 5 insertions(+), 2 deletions(-)
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
I guess we probably should have just done that the first time around?
Either way it seems reasonable to me, aside from sorting out the OF
stuff.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-18 22:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-17 20:53 [PATCH 0/2] gpio: sifive: Module support Samuel Holland
2023-07-17 20:53 ` [PATCH 1/2] of/irq: Export of_irq_count() Samuel Holland
2023-07-17 21:40 ` Andy Shevchenko
2023-07-18 22:42 ` Rob Herring
2023-07-17 22:18 ` [PATCH 0/2] gpio: sifive: Module support Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).