From: Rob Herring <robh@kernel.org>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: krzysztof.kozlowskii+dt@linaro.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA
Date: Tue, 18 Jul 2023 16:45:30 -0600 [thread overview]
Message-ID: <20230718224530.GA2147915-robh@kernel.org> (raw)
In-Reply-To: <20230718204217.651081-1-dinguyen@kernel.org>
On Tue, Jul 18, 2023 at 03:42:17PM -0500, Dinh Nguyen wrote:
> The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA
> platforms, thus it not required for all platforms.
>
> While at it, update my email address.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> .../devicetree/bindings/reset/altr,rst-mgr.yaml | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
> index 4379cec6b35a..7796408d2545 100644
> --- a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
> +++ b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
> @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Altera SOCFPGA Reset Manager
>
> maintainers:
> - - Dinh Nguyen <dinguyen@altera.com>
> + - Dinh Nguyen <dinguyen@kernel.org>
>
> properties:
> compatible:
> @@ -32,9 +32,20 @@ properties:
> required:
> - compatible
> - reg
> - - altr,modrst-offset
> - '#reset-cells'
>
> +if:
> + properties:
> + compatible:
> + contains:
> + const: altr,stratix10-rst-mgr
> +then:
> + properties:
> + altr,modrst-offset: false
> +else:
> + properties:
> + altr,modrst-offset: true
You don't need the else clause. "altr,modrst-offset" is already allowed
by default.
Rob
prev parent reply other threads:[~2023-07-18 22:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 20:42 [PATCH] dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA Dinh Nguyen
2023-07-18 22:45 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718224530.GA2147915-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzysztof.kozlowskii+dt@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).