* [PATCH] dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA
@ 2023-07-18 20:42 Dinh Nguyen
2023-07-18 22:45 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Dinh Nguyen @ 2023-07-18 20:42 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowskii+dt, conor+dt; +Cc: dinguyen, devicetree
The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA
platforms, thus it not required for all platforms.
While at it, update my email address.
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
---
.../devicetree/bindings/reset/altr,rst-mgr.yaml | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
index 4379cec6b35a..7796408d2545 100644
--- a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
+++ b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
@@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
title: Altera SOCFPGA Reset Manager
maintainers:
- - Dinh Nguyen <dinguyen@altera.com>
+ - Dinh Nguyen <dinguyen@kernel.org>
properties:
compatible:
@@ -32,9 +32,20 @@ properties:
required:
- compatible
- reg
- - altr,modrst-offset
- '#reset-cells'
+if:
+ properties:
+ compatible:
+ contains:
+ const: altr,stratix10-rst-mgr
+then:
+ properties:
+ altr,modrst-offset: false
+else:
+ properties:
+ altr,modrst-offset: true
+
additionalProperties: false
examples:
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA
2023-07-18 20:42 [PATCH] dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA Dinh Nguyen
@ 2023-07-18 22:45 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-07-18 22:45 UTC (permalink / raw)
To: Dinh Nguyen; +Cc: krzysztof.kozlowskii+dt, conor+dt, devicetree
On Tue, Jul 18, 2023 at 03:42:17PM -0500, Dinh Nguyen wrote:
> The property "altr,modrst-offset" is only applicable to arm32 SoCFPGA
> platforms, thus it not required for all platforms.
>
> While at it, update my email address.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> .../devicetree/bindings/reset/altr,rst-mgr.yaml | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
> index 4379cec6b35a..7796408d2545 100644
> --- a/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
> +++ b/Documentation/devicetree/bindings/reset/altr,rst-mgr.yaml
> @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> title: Altera SOCFPGA Reset Manager
>
> maintainers:
> - - Dinh Nguyen <dinguyen@altera.com>
> + - Dinh Nguyen <dinguyen@kernel.org>
>
> properties:
> compatible:
> @@ -32,9 +32,20 @@ properties:
> required:
> - compatible
> - reg
> - - altr,modrst-offset
> - '#reset-cells'
>
> +if:
> + properties:
> + compatible:
> + contains:
> + const: altr,stratix10-rst-mgr
> +then:
> + properties:
> + altr,modrst-offset: false
> +else:
> + properties:
> + altr,modrst-offset: true
You don't need the else clause. "altr,modrst-offset" is already allowed
by default.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-18 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-18 20:42 [PATCH] dt-bindings: reset: altr,modrst-offset is not required for arm64 SoCFPGA Dinh Nguyen
2023-07-18 22:45 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).