From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FFBEB64DA for ; Thu, 20 Jul 2023 07:13:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbjGTHNd (ORCPT ); Thu, 20 Jul 2023 03:13:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231702AbjGTHNb (ORCPT ); Thu, 20 Jul 2023 03:13:31 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EF681719; Thu, 20 Jul 2023 00:13:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1689837210; x=1721373210; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=JqmIbHV6INwiceEQ+zwOlcaktt1kdVZIs4BjTMq3ya8=; b=A+IrXBVYVpxpEcYqeJVfNvsWAd+1yAdc4kz5Do42+fVsATYNpxcRBZGi 6q+nYzlwv8dpTw3SWZlEWMtsW5ASrG/8xtGYy29Jxl8ibULRKj5rr+HUc UytqL1JjKUSIL97cNFX/oJaZmbtnkvg3PJORRCojlhyJQrUnfTxZgm0wJ zhhPYRmII3Snh3efi8OlZpjTwhK4bFNKg3K++8l3F9793jpsCu4spZB49 vaSlnX8r2az3Jesg2/jPNuS5fkRCMFJBkK9GsiG4mQ3Fg/P6Gea+Bi63M eZFzbREQaIrOu+gzbSzFayI0JAXDhGdtTq0X1G6TUKDi8CCQDbqEuUukL w==; X-IronPort-AV: E=Sophos;i="6.01,218,1684825200"; d="asc'?scan'208";a="236654397" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 20 Jul 2023 00:13:29 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 20 Jul 2023 00:13:28 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 20 Jul 2023 00:13:27 -0700 Date: Thu, 20 Jul 2023 08:12:54 +0100 From: Conor Dooley To: Walker Chen CC: Rob Herring , Conor Dooley , , Subject: Re: [PATCH] soc: starfive: Explicitly include correct DT includes Message-ID: <20230720-captive-wife-8bdd341fa8f5@wendy> References: <20230714175149.4068174-1-robh@kernel.org> <6d503477-82eb-c201-129a-009bcde485d0@starfivetech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q61HPjpCze90uyKW" Content-Disposition: inline In-Reply-To: <6d503477-82eb-c201-129a-009bcde485d0@starfivetech.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --Q61HPjpCze90uyKW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 20, 2023 at 02:12:51PM +0800, Walker Chen wrote: > On 2023/7/15 1:51, Rob Herring wrote: > > The DT of_device.h and of_platform.h date back to the separate > > of_platform_bus_type before it as merged into the regular platform bus. > > As part of that merge prepping Arm DT support 13 years ago, they > > "temporarily" include each other. They also include platform_device.h > > and of.h. As a result, there's a pretty much random mix of those include > > files used throughout the tree. In order to detangle these headers and > > replace the implicit includes with struct declarations, users need to > > explicitly include the correct includes. > >=20 > > Signed-off-by: Rob Herring > > --- > > drivers/soc/starfive/jh71xx_pmu.c | 1 - > > 1 file changed, 1 deletion(-) > >=20 > > diff --git a/drivers/soc/starfive/jh71xx_pmu.c b/drivers/soc/starfive/j= h71xx_pmu.c > > index 7d5f50d71c0d..d3b78a619d40 100644 > > --- a/drivers/soc/starfive/jh71xx_pmu.c > > +++ b/drivers/soc/starfive/jh71xx_pmu.c > > @@ -10,7 +10,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include >=20 > Nice! Thank you for your careful discovery, this helps simplify the code. Huh, seems I missed this patch. Now applied, thanks! --Q61HPjpCze90uyKW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZLjedgAKCRB4tDGHoIJi 0vsDAQCuzaEOC//rMky0CIQbHRukRzUFHVoUi5eh/3WIk3BZPwD/f6kXwQ4NNyIS ZLj28G8IuwKFCpSF6f4Ac2+nAj8e4Qk= =LdIm -----END PGP SIGNATURE----- --Q61HPjpCze90uyKW--