From: Marco Felsch <m.felsch@pengutronix.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, peppe.cavallaro@st.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 2/2] net: stmmac: add support for phy-supply
Date: Thu, 20 Jul 2023 08:46:36 +0200 [thread overview]
Message-ID: <20230720064636.5l45ad64kwwgd2iw@pengutronix.de> (raw)
In-Reply-To: <20230719211235.1758bbc0@kernel.org>
Hi,
On 23-07-19, Jakub Kicinski wrote:
> On Tue, 18 Jul 2023 15:20:49 +0200 Marco Felsch wrote:
> > Add generic phy-supply handling support to control the phy regulator to
> > avoid handling it within the glue code. Use the generic stmmac_platform
> > code to register a possible phy-supply and the stmmac_main code to
> > handle the power on/off.
> >
> > Changelog
> > ---
> >
> > v2:
> > - adapt stmmac_phy_power
> > - move power-on/off into stmmac_main to handle WOL
> > - adapt commit message
> >
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
>
> Format should be:
>
> Bla bla bla
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Changelog
>
> v2:
> bla bla bla
>
>
> Please fix and rebase because the current version does not apply to
> net-next/main.
Sure, I thought the changelog should be part of the commit message in
net-dev therefore I included it. Unfortunately I used --- as underline
:/
I will fix this and rebase it on-top of net-next/main.
Regards,
Marco
> --
> pw-bot: cr
>
next prev parent reply other threads:[~2023-07-20 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 13:20 [PATCH net-next v2 1/2] dt-bindings: net: snps,dwmac: add phy-supply support Marco Felsch
2023-07-18 13:20 ` [PATCH net-next v2 2/2] net: stmmac: add support for phy-supply Marco Felsch
2023-07-20 4:12 ` Jakub Kicinski
2023-07-20 6:46 ` Marco Felsch [this message]
2023-07-20 15:19 ` Jakub Kicinski
2023-07-20 15:38 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720064636.5l45ad64kwwgd2iw@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).