From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 271CCEB64DC for ; Thu, 20 Jul 2023 08:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbjGTIHp (ORCPT ); Thu, 20 Jul 2023 04:07:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjGTIHo (ORCPT ); Thu, 20 Jul 2023 04:07:44 -0400 Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1A5C6213C; Thu, 20 Jul 2023 01:07:39 -0700 (PDT) X-MailGates: (SIP:2,PASS,NONE)(compute_score:DELIVER,40,3) Received: from 192.168.10.46 by mg.richtek.com with MailGates ESMTPS Server V6.0(2903814:0:AUTH_RELAY) (envelope-from ) (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256/256); Thu, 20 Jul 2023 16:07:29 +0800 (CST) Received: from ex3.rt.l (192.168.10.46) by ex3.rt.l (192.168.10.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Thu, 20 Jul 2023 16:07:28 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex3.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Thu, 20 Jul 2023 16:07:28 +0800 Date: Thu, 20 Jul 2023 16:07:28 +0800 From: Alina Yu To: Krzysztof Kozlowski CC: , , , , , , , Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC Message-ID: <20230720080728.GA10433@linuxcarl2.richtek.com> References: <1689758686-14409-1-git-send-email-alina_yu@richtek.com> <1689758686-14409-2-git-send-email-alina_yu@richtek.com> <44b50616-a6ee-76e4-21b8-3e39b1a2ccd1@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <44b50616-a6ee-76e4-21b8-3e39b1a2ccd1@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Krzysztof: On Wed, Jul 19, 2023 at 11:44:45AM +0200, Krzysztof Kozlowski wrote: > On 19/07/2023 11:24, alina_yu@richtek.com wrote: > > From: alinayu > > > > Add bindings for Richtek RTQ2208 IC controlled SubPMIC > > > > Signed-off-by: Alina Yu > > --- > > v4 > > - Modify filename to "richtek,rtq2208" > > - Add more desciptions for "regulator-allowed-modes" ... > > + > > + regulator-mode: > > + enum: [0, 1] > > + description: > > + describe buck initial operating mode in suspend state. > > There is no such property on this level. Aren't you mixing initial one? It's the initial mode in suspend-mem state, should I modify that like this ? patternProperties: "^regulator-state-(standby|mem|disk)$": type: object $ref: regulator.yaml# properties: regulator-mode: enum: [0, 1] description: describe byck initial operating mode in suspend state. ... > > > + enum: [ 900000, 1200000, 1800000, 3300000 ] > > + description: > > + the fixed voltage in micro volt which is decided at the factory. > > I don't understand this property. Why this is different from min/max Because ldo has fixed voltage, so I thinks I could use a property to represent the fixed voltage directly. Do you suggest me modifying that like this: regulator-min-microvolt = <900000>; regulator-max-microvolt = <900000>; Using min voltage equals to max voltage to represent fixed voltage, instead of self-defined property ? > microvolt? Plus, you use incorrect unit suffix. if I change "richtek,fixed-uV" to "richtek, fixed-microvolt", will it be a correct unit suffix ? Best regards, Alina