From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3378EB64DC for ; Thu, 20 Jul 2023 13:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231628AbjGTNxJ (ORCPT ); Thu, 20 Jul 2023 09:53:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231975AbjGTNxA (ORCPT ); Thu, 20 Jul 2023 09:53:00 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B341230C6; Thu, 20 Jul 2023 06:52:38 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 33664E0012; Thu, 20 Jul 2023 13:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1689861146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oQjwgP8NyAhjmDO+mDi8yi5oc9GjBls2NUUYZadye/k=; b=NOCwrt5yLMd025/qXCMrQZBKyitZGU/phqpgRJQmxaRbDcgwPdCM2gYvs5ya5Yc9vrgf8s d3lNaCv1ST9SGcmM1VJyDoemLKD4Xg3UoMTNwpHEuKcvH075SjTU9KVrNY8XcliymaB/LW vEcISNBI6flr0Q7dLuetw43OT0Q5Sgz4CxVTeTPQEgOtcazabOzO0EmQXZSYEfaLiYQvWT 7Zio2o1k3vgkAoHZiY+vTmR63m/rEYrD0D+9eDwc8T1fPI3/ys3pNgXgcHllQziEBBnEa7 x1Xxx9zjzy70d0aIDj73JEH5lGovbNdz03mluByJxeWF6bm+BFbbVEEAy8j1dw== Date: Thu, 20 Jul 2023 15:52:23 +0200 From: Luca Ceresoli To: Conor Dooley Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Paul Kocialkowski Subject: Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E Message-ID: <20230720155223.7f4da41a@booty> In-Reply-To: <20230719-sizing-ribbon-9e62a4afb5f6@spud> References: <20230719152147.355486-1-luca.ceresoli@bootlin.com> <20230719152147.355486-2-luca.ceresoli@bootlin.com> <20230719-sizing-ribbon-9e62a4afb5f6@spud> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello Conor, thanks for reviewing. On Wed, 19 Jul 2023 17:44:45 +0100 Conor Dooley wrote: > Hey Luca, > > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > > 480x800 panel based on it. > > > > Signed-off-by: Luca Ceresoli > > --- > > .../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++ > > MAINTAINERS | 6 ++ > > 2 files changed, 75 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > new file mode 100644 > > index 000000000000..42abc6923065 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Ilitek ILI9806E display panels > > + > > +maintainers: > > + - Luca Ceresoli > > + > > +description: > > + This binding is for display panels using an Ilitek ILI9806E controller in > > + SPI mode. > > I figure you explicitly mention SPI mode here because it also supports > D{P,S}I? Exactly, DSI is supported as well by the chip. > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD > > + - newdisplay,nds040480800-v3 > > + - const: ilitek,ili9806e > > + > > + reg: true > > + spi-max-frequency: true > > + reset-gpios: true > > + backlight: true > > + port: true > > + > > +required: > > + - compatible > > + - reg > > + - port > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + backlight: backlight { > > + compatible = "gpio-backlight"; > > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > > + }; > > + spi { > > Just a nit, a blank line between properties please. Clearly no > respinning needed for that... I agree. This comes from copy-paste from another bindings file so I'm probably sending a separate series to fix it and avoid the same issue in the future. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com