From: kernel test robot <lkp@intel.com>
To: Praveenkumar I <quic_ipkumar@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, amitk@kernel.org,
thara.gopinath@gmail.com, rafael@kernel.org,
daniel.lezcano@linaro.org, rui.zhang@intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
quic_varada@quicinc.com
Subject: Re: [PATCH v4 1/5] thermal/drivers/tsens: Add TSENS enable and calibration support for V2
Date: Fri, 21 Jul 2023 00:54:01 +0800 [thread overview]
Message-ID: <202307210014.qNnx99K8-lkp@intel.com> (raw)
In-Reply-To: <20230719104041.126718-2-quic_ipkumar@quicinc.com>
Hi Praveenkumar,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on robh/for-next linus/master v6.5-rc2 next-20230720]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Praveenkumar-I/thermal-drivers-tsens-Add-TSENS-enable-and-calibration-support-for-V2/20230719-184436
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link: https://lore.kernel.org/r/20230719104041.126718-2-quic_ipkumar%40quicinc.com
patch subject: [PATCH v4 1/5] thermal/drivers/tsens: Add TSENS enable and calibration support for V2
config: arm-randconfig-r001-20230720 (https://download.01.org/0day-ci/archive/20230721/202307210014.qNnx99K8-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20230721/202307210014.qNnx99K8-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307210014.qNnx99K8-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/thermal/qcom/tsens-v2.c:153:9: error: implicit declaration of function 'FIELD_PREP' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
val = FIELD_PREP(CONVERSION_SHIFT_MASK, V2_SHIFT_DEFAULT) |
^
1 error generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for SM_GCC_8450
Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
Selected by [y]:
- SM_VIDEOCC_8450 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
WARNING: unmet direct dependencies detected for SM_GCC_8550
Depends on [n]: COMMON_CLK [=y] && COMMON_CLK_QCOM [=y] && (ARM64 || COMPILE_TEST [=n])
Selected by [y]:
- SM_GPUCC_8550 [=y] && COMMON_CLK [=y] && COMMON_CLK_QCOM [=y]
vim +/FIELD_PREP +153 drivers/thermal/qcom/tsens-v2.c
129
130 static int tsens_v2_calibrate_sensor(struct device *dev, struct tsens_sensor *sensor,
131 struct regmap *map, u32 mode, u32 base0, u32 base1)
132 {
133 u32 slope, czero, val;
134 char name[8];
135 int ret;
136
137 /* Read offset value */
138 ret = snprintf(name, sizeof(name), "s%d", sensor->hw_id);
139 if (ret < 0)
140 return ret;
141
142 ret = nvmem_cell_read_variable_le_u32(dev, name, &sensor->offset);
143 if (ret)
144 return ret;
145
146 /* Based on calib mode, program SHIFT, SLOPE and CZERO */
147 switch (mode) {
148 case TWO_PT_CALIB:
149 slope = (TWO_PT_SHIFTED_GAIN / (base1 - base0));
150
151 czero = (base0 + sensor->offset - ((base1 - base0) / 3));
152
> 153 val = FIELD_PREP(CONVERSION_SHIFT_MASK, V2_SHIFT_DEFAULT) |
154 FIELD_PREP(CONVERSION_SLOPE_MASK, slope) |
155 FIELD_PREP(CONVERSION_CZERO_MASK, czero);
156
157 fallthrough;
158 case ONE_PT_CALIB2:
159 czero = base0 + sensor->offset - ONE_PT_CZERO_CONST;
160
161 val = FIELD_PREP(CONVERSION_SHIFT_MASK, V2_SHIFT_DEFAULT) |
162 FIELD_PREP(CONVERSION_SLOPE_MASK, ONE_PT_SLOPE) |
163 FIELD_PREP(CONVERSION_CZERO_MASK, czero);
164
165 break;
166 default:
167 dev_dbg(dev, "calibrationless mode\n");
168
169 val = FIELD_PREP(CONVERSION_SHIFT_MASK, V2_SHIFT_DEFAULT) |
170 FIELD_PREP(CONVERSION_SLOPE_MASK, V2_SLOPE_DEFAULT) |
171 FIELD_PREP(CONVERSION_CZERO_MASK, V2_CZERO_DEFAULT);
172 }
173
174 regmap_write(map, SENSOR_CONVERSION(sensor->hw_id), val);
175
176 return 0;
177 }
178
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-07-20 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 10:40 [PATCH v4 0/5] Add IPQ5332 TSENS support Praveenkumar I
2023-07-19 10:40 ` [PATCH v4 1/5] thermal/drivers/tsens: Add TSENS enable and calibration support for V2 Praveenkumar I
2023-07-20 16:54 ` kernel test robot [this message]
2023-07-19 10:40 ` [PATCH v4 2/5] dt-bindings: thermal: tsens: Add ipq5332 compatible Praveenkumar I
2023-07-19 10:40 ` [PATCH v4 3/5] arm64: dts: qcom: ipq5332: Add tsens node Praveenkumar I
2023-07-19 10:40 ` [PATCH v4 4/5] arm64: dts: qcom: ipq5332: Add thermal zone nodes Praveenkumar I
2023-07-19 10:40 ` [PATCH v4 5/5] thermal/drivers/tsens: Add IPQ5332 support Praveenkumar I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307210014.qNnx99K8-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).