[PATCH v2 0/3] riscv: Add BeagleV Ahead board support

[PATCH v2 0/3] riscv: Add BeagleV Ahead board support

[Drew Fustini]

The BeagleV Ahead single board computer [1] features the T-Head TH1520
SoC. Similar to the Lichee Pi 4A series from Jisheng [2], this adds a
minimal device tree file to support booting to a basic shell [3].

Changes since v1:
- Add dual license to dts file as Conor noted this is typical
- Move the bindings patch before dts patch so patchwork bot is happy
- Reorder new entry in thead.yaml to maintain alphabetical order per
  suggestion by Krzysztof
- Add A-b's and R-b's from v1

[1] https://beagleboard.org/beaglev-ahead
[2] https://lore.kernel.org/linux-riscv/20230617161529.2092-1-jszhang@kernel.org/
[3] https://gist.github.com/pdp7/91b98f5b8a632802e669d8c359f4f498

To: Jisheng Zhang <jszhang@kernel.org>
To: Guo Ren <guoren@kernel.org>
To: Fu Wei <wefu@redhat.com>
To: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Paul Walmsley <paul.walmsley@sifive.com>
To: Palmer Dabbelt <palmer@dabbelt.com>
To: Albert Ou <aou@eecs.berkeley.edu>
To: Conor Dooley <conor@kernel.org>
Cc: linux-riscv@lists.infradead.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Robert Nelson <robertcnelson@beagleboard.org>
Cc: Jason Kridner <jkridner@beagleboard.org>

Signed-off-by: Drew Fustini <dfustini@baylibre.com>
---
Drew Fustini (3):
      dt-bindings: riscv: Add BeagleV Ahead board compatibles
      riscv: dts: thead: add BeagleV Ahead board device tree
      MAINTAINERS: add reviewer for T-Head RISC-V SoC support

 Documentation/devicetree/bindings/riscv/thead.yaml |  4 ++
 MAINTAINERS                                        |  1 +
 arch/riscv/boot/dts/thead/Makefile                 |  2 +-
 arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 61 ++++++++++++++++++++++
 4 files changed, 67 insertions(+), 1 deletion(-)
---
base-commit: 295e1388de2d5c0c354adbd65d0319c5d636c222
change-id: 20230722-upstream-beaglev-ahead-dts-d651af307fa6

Best regards,
-- 
Drew Fustini <dfustini@baylibre.com>

[PATCH v2 1/3] dt-bindings: riscv: Add BeagleV Ahead board compatibles

[Drew Fustini]

Document the compatible strings for the BeagleV Ahead board which uses
the T-Head TH1520 SoC.

Link: https://beagleboard.org/beaglev-ahead
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Guo Ren <guoren@kernel.org>
Signed-off-by: Drew Fustini <dfustini@baylibre.com>
---
 Documentation/devicetree/bindings/riscv/thead.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/riscv/thead.yaml b/Documentation/devicetree/bindings/riscv/thead.yaml
index e62f6821372e..301912dcd290 100644
--- a/Documentation/devicetree/bindings/riscv/thead.yaml
+++ b/Documentation/devicetree/bindings/riscv/thead.yaml
@@ -17,6 +17,10 @@ properties:
     const: '/'
   compatible:
     oneOf:
+      - description: BeagleV Ahead single board computer
+        items:
+          - const: beagle,beaglev-ahead
+          - const: thead,th1520
       - description: Sipeed Lichee Pi 4A board for the Sipeed Lichee Module 4A
         items:
           - enum:

-- 
2.34.1

[PATCH v2 2/3] riscv: dts: thead: add BeagleV Ahead board device tree

[Drew Fustini]

The BeagleV Ahead single board computer uses the T-Head TH1520 SoC.
Add a minimal device tree to support basic uart/gpio/dmac drivers so
that a user can boot to a basic shell.

Link: https://beagleboard.org/beaglev-ahead
Reviewed-by: Guo Ren <guoren@kernel.org>
Signed-off-by: Drew Fustini <dfustini@baylibre.com>
---
 arch/riscv/boot/dts/thead/Makefile                 |  2 +-
 arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts | 61 ++++++++++++++++++++++
 2 files changed, 62 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/boot/dts/thead/Makefile b/arch/riscv/boot/dts/thead/Makefile
index e311fc9a5939..b55a17127c2b 100644
--- a/arch/riscv/boot/dts/thead/Makefile
+++ b/arch/riscv/boot/dts/thead/Makefile
@@ -1,2 +1,2 @@
 # SPDX-License-Identifier: GPL-2.0
-dtb-$(CONFIG_ARCH_THEAD) += th1520-lichee-pi-4a.dtb
+dtb-$(CONFIG_ARCH_THEAD) += th1520-lichee-pi-4a.dtb th1520-beaglev-ahead.dtb
diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
new file mode 100644
index 000000000000..70e8042c8304
--- /dev/null
+++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
@@ -0,0 +1,61 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright (C) 2023 Jisheng Zhang <jszhang@kernel.org>
+ * Copyright (C) 2023 Drew Fustini <dfustini@baylibre.com>
+ */
+
+/dts-v1/;
+
+#include "th1520.dtsi"
+
+/ {
+	model = "BeagleV Ahead";
+	compatible = "beagle,beaglev-ahead", "thead,th1520";
+
+	aliases {
+		gpio0 = &gpio0;
+		gpio1 = &gpio1;
+		gpio2 = &gpio2;
+		gpio3 = &gpio3;
+		serial0 = &uart0;
+		serial1 = &uart1;
+		serial2 = &uart2;
+		serial3 = &uart3;
+		serial4 = &uart4;
+		serial5 = &uart5;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@0 {
+		device_type = "memory";
+		reg = <0x0  0x00000000  0x1 0x00000000>;
+
+	};
+};
+
+&osc {
+	clock-frequency = <24000000>;
+};
+
+&osc_32k {
+	clock-frequency = <32768>;
+};
+
+&apb_clk {
+	clock-frequency = <62500000>;
+};
+
+&uart_sclk {
+	clock-frequency = <100000000>;
+};
+
+&dmac0 {
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};

-- 
2.34.1

[PATCH v2 3/3] MAINTAINERS: add reviewer for T-Head RISC-V SoC support

[Drew Fustini]

I will maintain support for the TH1520-based BeagleV Ahead board so
adding myself as a reviewer for T-Head SoC patches.

Acked-by: Guo Ren <guoren@kernel.org>
Signed-off-by: Drew Fustini <dfustini@baylibre.com>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index d516295978a4..eaec3333f2ed 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18326,6 +18326,7 @@ RISC-V THEAD SoC SUPPORT
 M:	Jisheng Zhang <jszhang@kernel.org>
 M:	Guo Ren <guoren@kernel.org>
 M:	Fu Wei <wefu@redhat.com>
+R:	Drew Fustini <dfustini@baylibre.com>
 L:	linux-riscv@lists.infradead.org
 S:	Maintained
 F:	arch/riscv/boot/dts/thead/

-- 
2.34.1

Re: [PATCH v2 3/3] MAINTAINERS: add reviewer for T-Head RISC-V SoC support

[Jisheng Zhang]

On Mon, Jul 24, 2023 at 10:20:40AM -0700, Drew Fustini wrote:
> I will maintain support for the TH1520-based BeagleV Ahead board so
> adding myself as a reviewer for T-Head SoC patches.

Hi Drew,

Thanks for your interest in maintaining the SoC support part. However,
maintainership involves active reviewing and maintaining the whole SoC
support part and not just specific board part, although currently, the
SoC support in mainline is minimal. I'd like to see your patch
reviewing, testing and so on.

Thanks
> 
> Acked-by: Guo Ren <guoren@kernel.org>
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d516295978a4..eaec3333f2ed 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18326,6 +18326,7 @@ RISC-V THEAD SoC SUPPORT
>  M:	Jisheng Zhang <jszhang@kernel.org>
>  M:	Guo Ren <guoren@kernel.org>
>  M:	Fu Wei <wefu@redhat.com>
> +R:	Drew Fustini <dfustini@baylibre.com>
>  L:	linux-riscv@lists.infradead.org
>  S:	Maintained
>  F:	arch/riscv/boot/dts/thead/
> 
> -- 
> 2.34.1
> 

Re: [PATCH v2 3/3] MAINTAINERS: add reviewer for T-Head RISC-V SoC support

[Drew Fustini]

On Tue, Jul 25, 2023 at 5:30 PM Jisheng Zhang <jszhang@kernel.org> wrote:
>
> On Mon, Jul 24, 2023 at 10:20:40AM -0700, Drew Fustini wrote:
> > I will maintain support for the TH1520-based BeagleV Ahead board so
> > adding myself as a reviewer for T-Head SoC patches.
>
> Hi Drew,
>
> Thanks for your interest in maintaining the SoC support part. However,
> maintainership involves active reviewing and maintaining the whole SoC
> support part and not just specific board part, although currently, the
> SoC support in mainline is minimal. I'd like to see your patch
> reviewing, testing and so on.

Yes, that is understandable. I was just adding a Reviewer entry as I
am supporting the BeagleV Ahead and I would like to test patches
related to the th1520.  But it is not too big of a deal as I am also
subscribed to all the relevant mailing lists that would receive
patches.

Thanks,
Drew

Re: [PATCH v2 3/3] MAINTAINERS: add reviewer for T-Head RISC-V SoC support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1142 bytes --]

On Tue, Jul 25, 2023 at 06:38:16PM -0700, Drew Fustini wrote:
> On Tue, Jul 25, 2023 at 5:30 PM Jisheng Zhang <jszhang@kernel.org> wrote:
> >
> > On Mon, Jul 24, 2023 at 10:20:40AM -0700, Drew Fustini wrote:
> > > I will maintain support for the TH1520-based BeagleV Ahead board so
> > > adding myself as a reviewer for T-Head SoC patches.
> >
> > Hi Drew,
> >
> > Thanks for your interest in maintaining the SoC support part. However,
> > maintainership involves active reviewing and maintaining the whole SoC
> > support part and not just specific board part, although currently, the
> > SoC support in mainline is minimal. I'd like to see your patch
> > reviewing, testing and so on.
> 
> Yes, that is understandable. I was just adding a Reviewer entry as I
> am supporting the BeagleV Ahead and I would like to test patches
> related to the th1520.  But it is not too big of a deal as I am also
> subscribed to all the relevant mailing lists that would receive
> patches.

You can always add a new MAINTAINERS entry that matches only the
th1520-beaglev stuff, if being added to the main entry is not
acceptable.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 0/3] riscv: Add BeagleV Ahead board support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On Mon, Jul 24, 2023 at 10:20:37AM -0700, Drew Fustini wrote:
> The BeagleV Ahead single board computer [1] features the T-Head TH1520
> SoC. Similar to the Lichee Pi 4A series from Jisheng [2], this adds a
> minimal device tree file to support booting to a basic shell [3].
> 
> Changes since v1:

> - Add dual license to dts file as Conor noted this is typical

I figure the dual licensing of the dtsi & sipeed board will be done
separately?

What's here is 
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 0/3] riscv: Add BeagleV Ahead board support

[Drew Fustini]

On Mon, Jul 24, 2023 at 06:36:34PM +0100, Conor Dooley wrote:
> On Mon, Jul 24, 2023 at 10:20:37AM -0700, Drew Fustini wrote:
> > The BeagleV Ahead single board computer [1] features the T-Head TH1520
> > SoC. Similar to the Lichee Pi 4A series from Jisheng [2], this adds a
> > minimal device tree file to support booting to a basic shell [3].
> > 
> > Changes since v1:
> 
> > - Add dual license to dts file as Conor noted this is typical
> 
> I figure the dual licensing of the dtsi & sipeed board will be done
> separately?
> 
> What's here is 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks for the review.

Yes, I was thinking that would be a different series as a followup
to the original patch series that added th1520 and lpi4a.

Drew

Re: [PATCH v2 0/3] riscv: Add BeagleV Ahead board support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

Hey,

On Mon, Jul 24, 2023 at 10:20:37AM -0700, Drew Fustini wrote:
> The BeagleV Ahead single board computer [1] features the T-Head TH1520
> SoC. Similar to the Lichee Pi 4A series from Jisheng [2], this adds a
> minimal device tree file to support booting to a basic shell [3].

What is the status of this series?
Does Drew need to repost with the MAINTAINERS patch removed?
Do you want me to queue this with the MAINTAIERS patch removed Jisheng?
If so, I'd like to do so soon so I can get my PRs into Arnd a reasonable
amount of time before the merge window opens.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 0/3] riscv: Add BeagleV Ahead board support

[Drew Fustini]

On Fri, Aug 11, 2023 at 06:49:16PM +0100, Conor Dooley wrote:
> Hey,
> 
> On Mon, Jul 24, 2023 at 10:20:37AM -0700, Drew Fustini wrote:
> > The BeagleV Ahead single board computer [1] features the T-Head TH1520
> > SoC. Similar to the Lichee Pi 4A series from Jisheng [2], this adds a
> > minimal device tree file to support booting to a basic shell [3].
> 
> What is the status of this series?
> Does Drew need to repost with the MAINTAINERS patch removed?
> Do you want me to queue this with the MAINTAIERS patch removed Jisheng?
> If so, I'd like to do so soon so I can get my PRs into Arnd a reasonable
> amount of time before the merge window opens.
> 
> Thanks,
> Conor.

Thank you for the reminder.  I don't want to miss the window so I'll
resubmit without the MAINTAINERS patch as it doesn't really matter.

Drew