From: Yunfei Dong <yunfei.dong@mediatek.com>
To: "Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Nicolas Dufresne" <nicolas.dufresne@collabora.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Nathan Hebert" <nhebert@chromium.org>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>,
Daniel Vetter <daniel@ffwll.ch>,
Steve Cho <stevecho@chromium.org>,
Yunfei Dong <yunfei.dong@mediatek.com>,
<linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: [PATCH v7,09/11] media: mediatek: vcodec: fix unreasonable parameter definition and style
Date: Sat, 22 Jul 2023 15:42:28 +0800 [thread overview]
Message-ID: <20230722074230.30558-10-yunfei.dong@mediatek.com> (raw)
In-Reply-To: <20230722074230.30558-1-yunfei.dong@mediatek.com>
Fix unreasonable coding style.
Fix unreasonable parameter definition.
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h | 4 ++--
.../media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h | 8 ++++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
index 533d8d97f704..4122e37aea67 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.h
@@ -19,7 +19,7 @@
#define IS_VDEC_INNER_RACING(capability) ((capability) & MTK_VCODEC_INNER_RACING)
/*
- * struct mtk_vdec_format_types - Structure used to get supported
+ * enum mtk_vdec_format_types - Structure used to get supported
* format types according to decoder capability
*/
enum mtk_vdec_format_types {
@@ -258,7 +258,7 @@ struct mtk_vcodec_dec_dev {
struct regmap *vdecsys_regmap;
struct mtk_vcodec_fw *fw_handler;
- unsigned long id_counter;
+ u64 id_counter;
/* decoder hardware mutex lock */
struct mutex dec_mutex[MTK_VDEC_HW_MAX];
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
index 2f6d0160ff1d..5d410a6b15cc 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.h
@@ -32,13 +32,13 @@
*/
struct mtk_vcodec_enc_pdata {
bool uses_ext;
- unsigned long min_bitrate;
- unsigned long max_bitrate;
+ u64 min_bitrate;
+ u64 max_bitrate;
const struct mtk_video_fmt *capture_formats;
size_t num_capture_formats;
const struct mtk_video_fmt *output_formats;
size_t num_output_formats;
- int core_id;
+ u8 core_id;
bool uses_34bit;
};
@@ -198,7 +198,7 @@ struct mtk_vcodec_enc_dev {
const struct mtk_vcodec_enc_pdata *venc_pdata;
struct mtk_vcodec_fw *fw_handler;
- unsigned long id_counter;
+ u64 id_counter;
/* encoder hardware mutex lock */
struct mutex enc_mutex;
--
2.18.0
next prev parent reply other threads:[~2023-07-22 7:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 7:42 [PATCH v7,0/11] media: mediatek: vcodec: separate encoder and decoder Yunfei Dong
2023-07-22 7:42 ` [PATCH v7,01/11] media: mediatek: vcodec: remove unused parameter Yunfei Dong
2023-07-22 7:42 ` [PATCH v7,02/11] media: mediatek: vcodec: align fw interface Yunfei Dong
2023-07-22 7:42 ` [PATCH v7,03/11] media: mediatek: vcodec: Removing struct 'mtk_vcodec_ctx/dev' for shared interface Yunfei Dong
2023-07-22 7:42 ` [PATCH v7,04/11] media: mediatek: vcodec: Removing useless debug log Yunfei Dong
2023-07-22 7:42 ` [PATCH v7,05/11] media: mediatek: vcodec: remove the dependency of vcodec " Yunfei Dong
2023-07-22 7:42 ` [PATCH v7,06/11] media: mediatek: vcodec: replace pr_* with dev_* for v4l2 debug message Yunfei Dong
2023-07-25 9:37 ` Hans Verkuil
2023-07-22 7:42 ` [PATCH v7,07/11] media: mediatek: vcodec: separate struct 'mtk_vcodec_ctx' Yunfei Dong
2023-07-22 7:42 ` [PATCH v7,08/11] media: mediatek: vcodec: separate struct mtk_vcodec_dev Yunfei Dong
2023-07-22 7:42 ` Yunfei Dong [this message]
2023-07-22 7:42 ` [PATCH v7,10/11] media: mediatek: vcodec: remove unused include header Yunfei Dong
2023-07-22 7:42 ` [PATCH v7,11/11] media: mediatek: vcodec: separate decoder and encoder Yunfei Dong
2023-07-25 9:58 ` [PATCH v7,0/11] media: mediatek: vcodec: separate encoder and decoder Hans Verkuil
2023-07-28 9:25 ` Hans Verkuil
2023-07-29 2:54 ` Yunfei Dong (董云飞)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230722074230.30558-10-yunfei.dong@mediatek.com \
--to=yunfei.dong@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nfraprado@collabora.com \
--cc=nhebert@chromium.org \
--cc=nicolas.dufresne@collabora.com \
--cc=stevecho@chromium.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).