* [PATCH v2] ARM: dts: imx: Set default tuning step for imx7d usdhc
@ 2023-07-23 2:20 Xiaolei Wang
2023-07-23 16:38 ` Fabio Estevam
0 siblings, 1 reply; 2+ messages in thread
From: Xiaolei Wang @ 2023-07-23 2:20 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
festevam, linux-imx, richardcochran
Cc: devicetree, linux-arm-kernel, linux-kernel
If the tuning step is not set, the tuning step is set to 1.
For some sd cards, the following Tuning timeout will occur,
so set the default tuning step. This refers to the NXP vendor's
commit below:
https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/
arch/arm/boot/dts/imx7s.dtsi#L1216-L1217
Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting")
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
v2:
* Refer to https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.dtsi#L1216-L1217
and add the following attributes for all usdhc of imx7:
fsl,tuning-step = <2>;
fsl,tuning-start-tap = <20>;
---
arch/arm/boot/dts/nxp/imx/imx7s.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/nxp/imx/imx7s.dtsi b/arch/arm/boot/dts/nxp/imx/imx7s.dtsi
index 54026c2c93fa..6ffb428dc939 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7s.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx7s.dtsi
@@ -1184,6 +1184,8 @@ usdhc1: mmc@30b40000 {
<&clks IMX7D_USDHC1_ROOT_CLK>;
clock-names = "ipg", "ahb", "per";
bus-width = <4>;
+ fsl,tuning-step = <2>;
+ fsl,tuning-start-tap = <20>;
status = "disabled";
};
@@ -1196,6 +1198,8 @@ usdhc2: mmc@30b50000 {
<&clks IMX7D_USDHC2_ROOT_CLK>;
clock-names = "ipg", "ahb", "per";
bus-width = <4>;
+ fsl,tuning-step = <2>;
+ fsl,tuning-start-tap = <20>;
status = "disabled";
};
@@ -1208,6 +1212,8 @@ usdhc3: mmc@30b60000 {
<&clks IMX7D_USDHC3_ROOT_CLK>;
clock-names = "ipg", "ahb", "per";
bus-width = <4>;
+ fsl,tuning-step = <2>;
+ fsl,tuning-start-tap = <20>;
status = "disabled";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ARM: dts: imx: Set default tuning step for imx7d usdhc
2023-07-23 2:20 [PATCH v2] ARM: dts: imx: Set default tuning step for imx7d usdhc Xiaolei Wang
@ 2023-07-23 16:38 ` Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2023-07-23 16:38 UTC (permalink / raw)
To: Xiaolei Wang
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
linux-imx, richardcochran, devicetree, linux-arm-kernel,
linux-kernel
Hi Xiaolei,
On Sat, Jul 22, 2023 at 11:21 PM Xiaolei Wang
<xiaolei.wang@windriver.com> wrote:
>
> If the tuning step is not set, the tuning step is set to 1.
> For some sd cards, the following Tuning timeout will occur,
You missed putting the timeout message here.
> so set the default tuning step. This refers to the NXP vendor's
> commit below:
>
> https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/
> arch/arm/boot/dts/imx7s.dtsi#L1216-L1217
>
> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
>
> v2:
> * Refer to https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.dtsi#L1216-L1217
> and add the following attributes for all usdhc of imx7:
> fsl,tuning-step = <2>;
> fsl,tuning-start-tap = <20>;
This v2 changelog should be placed below the --- line.
> ---
Put it here.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-23 16:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-23 2:20 [PATCH v2] ARM: dts: imx: Set default tuning step for imx7d usdhc Xiaolei Wang
2023-07-23 16:38 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).