* [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port
@ 2023-07-23 19:54 Rafał Miłecki
2023-07-23 19:54 ` [PATCH 2/3] ARM: dts: BCM53573: Describe BCM53125 switch ports in the main DTS Rafał Miłecki
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rafał Miłecki @ 2023-07-23 19:54 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
Primary Ethernet interface is connected to the port 8 (not 5).
Fixes: 64612828628c ("ARM: dts: BCM53573: Add Tenda AC9 switch ports")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts b/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
index dab2e5f63a72..06b1a582809c 100644
--- a/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
@@ -135,8 +135,8 @@ port@4 {
label = "lan4";
};
- port@5 {
- reg = <5>;
+ port@8 {
+ reg = <8>;
label = "cpu";
ethernet = <&gmac0>;
};
--
2.35.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] ARM: dts: BCM53573: Describe BCM53125 switch ports in the main DTS
2023-07-23 19:54 [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port Rafał Miłecki
@ 2023-07-23 19:54 ` Rafał Miłecki
2023-07-28 17:22 ` Florian Fainelli
2023-07-23 19:54 ` [PATCH 3/3] ARM: dts: BCM53573: Add BCM53125 switch port 5 Rafał Miłecki
2023-07-28 17:21 ` [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port Florian Fainelli
2 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2023-07-23 19:54 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
BCM53125 always has 5 ports with GPHYs (for LAN/WAN ports) and 2 IMP
ports. It seems the best place to describe that in the main .dtsi.
Device specific bits can go to device .dts files. This will help
avoiding some code duplication.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../boot/dts/broadcom/bcm47189-tenda-ac9.dts | 7 -----
arch/arm/boot/dts/broadcom/bcm53573.dtsi | 26 ++++++++++++++++++-
2 files changed, 25 insertions(+), 8 deletions(-)
diff --git a/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts b/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
index 06b1a582809c..3ac6cac541ca 100644
--- a/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47189-tenda-ac9.dts
@@ -111,34 +111,27 @@ &switch {
ports {
port@0 {
- reg = <0>;
label = "wan";
};
port@1 {
- reg = <1>;
label = "lan1";
};
port@2 {
- reg = <2>;
label = "lan2";
};
port@3 {
- reg = <3>;
label = "lan3";
};
port@4 {
- reg = <4>;
label = "lan4";
};
port@8 {
- reg = <8>;
label = "cpu";
- ethernet = <&gmac0>;
};
};
};
diff --git a/arch/arm/boot/dts/broadcom/bcm53573.dtsi b/arch/arm/boot/dts/broadcom/bcm53573.dtsi
index eed1a6147f0b..083304736fb3 100644
--- a/arch/arm/boot/dts/broadcom/bcm53573.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm53573.dtsi
@@ -192,10 +192,34 @@ switch: switch@1e {
status = "disabled";
- /* ports are defined in board DTS */
ports {
#address-cells = <1>;
#size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ };
+
+ port@1 {
+ reg = <1>;
+ };
+
+ port@2 {
+ reg = <2>;
+ };
+
+ port@3 {
+ reg = <3>;
+ };
+
+ port@4 {
+ reg = <4>;
+ };
+
+ port@8 {
+ reg = <8>;
+ ethernet = <&gmac0>;
+ };
};
};
};
--
2.35.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/3] ARM: dts: BCM53573: Describe BCM53125 switch ports in the main DTS
2023-07-23 19:54 ` [PATCH 2/3] ARM: dts: BCM53573: Describe BCM53125 switch ports in the main DTS Rafał Miłecki
@ 2023-07-28 17:22 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2023-07-28 17:22 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-arm-kernel, Rafał Miłecki
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
From: Florian Fainelli <f.fainelli@gmail.com>
On Sun, 23 Jul 2023 21:54:15 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> BCM53125 always has 5 ports with GPHYs (for LAN/WAN ports) and 2 IMP
> ports. It seems the best place to describe that in the main .dtsi.
> Device specific bits can go to device .dts files. This will help
> avoiding some code duplication.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/master, thanks!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] ARM: dts: BCM53573: Add BCM53125 switch port 5
2023-07-23 19:54 [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port Rafał Miłecki
2023-07-23 19:54 ` [PATCH 2/3] ARM: dts: BCM53573: Describe BCM53125 switch ports in the main DTS Rafał Miłecki
@ 2023-07-23 19:54 ` Rafał Miłecki
2023-07-28 17:23 ` Florian Fainelli
2023-07-28 17:21 ` [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port Florian Fainelli
2 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2023-07-23 19:54 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, bcm-kernel-feedback-list,
Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
It's connected to the extra Ethernet interface.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
arch/arm/boot/dts/broadcom/bcm53573.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/broadcom/bcm53573.dtsi b/arch/arm/boot/dts/broadcom/bcm53573.dtsi
index 083304736fb3..10d0fe76ee3c 100644
--- a/arch/arm/boot/dts/broadcom/bcm53573.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm53573.dtsi
@@ -216,6 +216,16 @@ port@4 {
reg = <4>;
};
+ port@5 {
+ reg = <5>;
+ ethernet = <&gmac1>;
+
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+
port@8 {
reg = <8>;
ethernet = <&gmac0>;
--
2.35.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] ARM: dts: BCM53573: Add BCM53125 switch port 5
2023-07-23 19:54 ` [PATCH 3/3] ARM: dts: BCM53573: Add BCM53125 switch port 5 Rafał Miłecki
@ 2023-07-28 17:23 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2023-07-28 17:23 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-arm-kernel, Rafał Miłecki
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
From: Florian Fainelli <f.fainelli@gmail.com>
On Sun, 23 Jul 2023 21:54:16 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> It's connected to the extra Ethernet interface.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/master, thanks!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port
2023-07-23 19:54 [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port Rafał Miłecki
2023-07-23 19:54 ` [PATCH 2/3] ARM: dts: BCM53573: Describe BCM53125 switch ports in the main DTS Rafał Miłecki
2023-07-23 19:54 ` [PATCH 3/3] ARM: dts: BCM53573: Add BCM53125 switch port 5 Rafał Miłecki
@ 2023-07-28 17:21 ` Florian Fainelli
2 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2023-07-28 17:21 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rafał Miłecki
Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-arm-kernel, Rafał Miłecki
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
From: Florian Fainelli <f.fainelli@gmail.com>
On Sun, 23 Jul 2023 21:54:14 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Primary Ethernet interface is connected to the port 8 (not 5).
>
> Fixes: 64612828628c ("ARM: dts: BCM53573: Add Tenda AC9 switch ports")
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/master, thanks!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-28 17:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-23 19:54 [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port Rafał Miłecki
2023-07-23 19:54 ` [PATCH 2/3] ARM: dts: BCM53573: Describe BCM53125 switch ports in the main DTS Rafał Miłecki
2023-07-28 17:22 ` Florian Fainelli
2023-07-23 19:54 ` [PATCH 3/3] ARM: dts: BCM53573: Add BCM53125 switch port 5 Rafał Miłecki
2023-07-28 17:23 ` Florian Fainelli
2023-07-28 17:21 ` [PATCH 1/3] ARM: dts: BCM53573: Fix Tenda AC9 switch CPU port Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).