From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 363B6C001DC for ; Mon, 24 Jul 2023 02:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbjGXCYQ (ORCPT ); Sun, 23 Jul 2023 22:24:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbjGXCYP (ORCPT ); Sun, 23 Jul 2023 22:24:15 -0400 Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7F6F918B; Sun, 23 Jul 2023 19:24:00 -0700 (PDT) X-MailGates: (SIP:2,PASS,NONE)(compute_score:DELIVER,40,3) Received: from 192.168.10.46 by mg.richtek.com with MailGates ESMTPS Server V6.0(1318274:0:AUTH_RELAY) (envelope-from ) (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jul 2023 10:23:42 +0800 (CST) Received: from ex4.rt.l (192.168.10.47) by ex3.rt.l (192.168.10.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Mon, 24 Jul 2023 10:23:42 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex4.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Mon, 24 Jul 2023 10:23:42 +0800 Date: Mon, 24 Jul 2023 10:23:42 +0800 From: Alina Yu To: Krzysztof Kozlowski CC: , , , , , , , Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC Message-ID: <20230724022342.GA17679@linuxcarl2.richtek.com> References: <1689758686-14409-1-git-send-email-alina_yu@richtek.com> <1689758686-14409-2-git-send-email-alina_yu@richtek.com> <44b50616-a6ee-76e4-21b8-3e39b1a2ccd1@linaro.org> <20230720080728.GA10433@linuxcarl2.richtek.com> <20230721062735.GA9068@linuxcarl2.richtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230721062735.GA9068@linuxcarl2.richtek.com> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, Krzysztof: > > > ... > > > > > >>> + > > >>> + regulator-mode: > > >>> + enum: [0, 1] > > >>> + description: > > >>> + describe buck initial operating mode in suspend state. > > >> > > >> There is no such property on this level. Aren't you mixing initial one? > > > > > > It's the initial mode in suspend-mem state, should I modify that like this ? > > > patternProperties: > > > "^regulator-state-(standby|mem|disk)$": > > > type: object > > > $ref: regulator.yaml# > > > properties: > > > regulator-mode: > > > enum: [0, 1] > > > description: > > > describe byck initial operating mode in suspend state. > > > > Please check how other bindings do it. > > > > If I modify that like this, will it be correct ? > > > ... > regulator-state-mem: > type: object > $ref: regulator.yaml# > properties: > regulator-mode: > description: > describe buck initial operating mode in suspend state. > 0 - Auto mode > 1 - FCCM > Sorry, I think I didn't explain well why to add "regulator-mode". I just want to add description for this property, for people can get its meaning when they see the yaml. If it's optional and it's already a general property in regulator.yaml. May I remove it from my yaml ? Best regards, Alina