From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jejb@linux.ibm.com,
martin.petersen@oracle.com, alim.akhtar@samsung.com,
avri.altman@wdc.com, bvanassche@acm.org,
linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
quic_asutoshd@quicinc.com, quic_cang@quicinc.com,
quic_nitirawa@quicinc.com, quic_narepall@quicinc.com,
quic_bhaskarv@quicinc.com, quic_richardp@quicinc.com,
quic_nguyenb@quicinc.com, quic_ziqichen@quicinc.com,
bmasney@redhat.com, krzysztof.kozlowski@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 04/15] arm64: dts: qcom: sdm845: Fix the min frequency of "ice_core_clk"
Date: Mon, 24 Jul 2023 11:18:31 +0530 [thread overview]
Message-ID: <20230724054831.GB2370@thinkpad> (raw)
In-Reply-To: <q36uuwhjmolgf3kjn3rrtw5fgfobatav334fez4cofzmrvge2h@cgwfhhhy6b6s>
On Fri, Jul 21, 2023 at 08:15:36PM -0700, Bjorn Andersson wrote:
> On Fri, Jul 21, 2023 at 05:27:31PM +0530, Manivannan Sadhasivam wrote:
> > On Fri, Jul 21, 2023 at 12:48:01PM +0530, Viresh Kumar wrote:
> > > On 20-07-23, 11:10, Manivannan Sadhasivam wrote:
> > > > Minimum frequency of the "ice_core_clk" should be 75MHz as specified in the
> > > > downstream vendor devicetree. So fix it!
> > > >
> > > > https://git.codelinaro.org/clo/la/kernel/msm-4.9/-/blob/LA.UM.7.3.r1-09300-sdm845.0/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > > >
> > > > Fixes: 433f9a57298f ("arm64: dts: sdm845: add Inline Crypto Engine registers and clock")
> > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > ---
> > > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > > > index 9ed74bf72d05..89520a9fe1e3 100644
> > > > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > > > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > > > @@ -2614,7 +2614,7 @@ ufs_mem_hc: ufshc@1d84000 {
> > > > <0 0>,
> > > > <0 0>,
> > > > <0 0>,
> > > > - <0 300000000>;
> > > > + <75000000 300000000>;
> > > >
> > > > status = "disabled";
> > > > };
> > >
> > > Please keep new feature and fixes like this in separate series. This
> > > could be merged directly in the currently ongoing kernel rc and
> > > doesn't need to wait for this series.
> > >
> > > Or at least keep the commit at the top, so another maintainer can
> > > simply pick it.
> > >
> >
> > That's what I did. This patch and previous patch are the fixes patches, so they
> > are posted on top of other dts patches to be merged separately if required.
> >
>
> I agree with Viresh, this is patch 4 in a series where 1-2, 7- are new
> things.
>
> I can pick this from here, but I think it would have been better to send
> this as 3-4 different series; 1 with DeviceTree fixes, 1 with driver
> fixes, one that adds interconnect support and one that adds opp support
> - the latter two with dts changes last...
>
>
> And, the freq-table-hz -> opp transition in dts files must be merged
> after the driver changes, so this will likely have to wait until 1
> release after the driver changes.
>
Hmm, Ok. Let me resend the series as you suggested (excluding the patches
already merged).
- Mani
> Regards,
> Bjorn
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2023-07-24 5:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 5:40 [PATCH v2 00/15] UFS: Add OPP and interconnect support Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 01/15] dt-bindings: ufs: common: add OPP table Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 02/15] dt-bindings: opp: Increase maxItems for opp-hz property Manivannan Sadhasivam
2023-07-24 15:51 ` Rob Herring
2023-07-25 4:11 ` Viresh Kumar
2023-07-20 5:40 ` [PATCH v2 03/15] arm64: dts: qcom: sdm845: Add missing RPMh power domain to GCC Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 04/15] arm64: dts: qcom: sdm845: Fix the min frequency of "ice_core_clk" Manivannan Sadhasivam
2023-07-21 7:18 ` Viresh Kumar
2023-07-21 11:57 ` Manivannan Sadhasivam
2023-07-22 3:15 ` Bjorn Andersson
2023-07-24 5:48 ` Manivannan Sadhasivam [this message]
2023-07-20 5:40 ` [PATCH v2 05/15] arm64: dts: qcom: sdm845: Add OPP table support to UFSHC Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 06/15] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 07/15] OPP: Introduce dev_pm_opp_find_freq_{ceil/floor}_indexed() APIs Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 08/15] OPP: Introduce dev_pm_opp_get_freq_indexed() API Manivannan Sadhasivam
2023-07-21 5:54 ` Dan Carpenter
2023-07-20 5:40 ` [PATCH v2 09/15] PM / devfreq: Switch to dev_pm_opp_find_freq_{ceil/floor}_indexed() APIs Manivannan Sadhasivam
2023-07-23 20:06 ` Chanwoo Choi
2023-07-24 5:46 ` Manivannan Sadhasivam
2023-07-24 21:57 ` Chanwoo Choi
2023-07-20 5:40 ` [PATCH v2 10/15] scsi: ufs: core: Add OPP support for scaling clocks and regulators Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 11/15] scsi: ufs: host: Add support for parsing OPP Manivannan Sadhasivam
2023-07-20 21:32 ` kernel test robot
2023-07-20 23:26 ` kernel test robot
2023-07-20 5:40 ` [PATCH v2 12/15] arm64: dts: qcom: sdm845: Add interconnect paths to UFSHC Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 13/15] arm64: dts: qcom: sm8250: " Manivannan Sadhasivam
2023-07-20 5:40 ` [PATCH v2 14/15] scsi: ufs: core: Add enums for UFS lanes Manivannan Sadhasivam
2023-07-20 5:41 ` [PATCH v2 15/15] scsi: ufs: qcom: Add support for scaling interconnects Manivannan Sadhasivam
2023-07-20 16:44 ` [PATCH v2 00/15] UFS: Add OPP and interconnect support Bart Van Assche
2023-07-20 16:57 ` Manivannan Sadhasivam
2023-07-21 9:42 ` Viresh Kumar
2023-07-21 11:54 ` Manivannan Sadhasivam
2023-07-24 7:52 ` Viresh Kumar
2023-07-22 5:17 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230724054831.GB2370@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bmasney@redhat.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jejb@linux.ibm.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).