From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4A7C001DF for ; Mon, 24 Jul 2023 11:36:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229441AbjGXLgw (ORCPT ); Mon, 24 Jul 2023 07:36:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbjGXLgv (ORCPT ); Mon, 24 Jul 2023 07:36:51 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DC5F106 for ; Mon, 24 Jul 2023 04:36:50 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-262cc036fa4so1678852a91.3 for ; Mon, 24 Jul 2023 04:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690198609; x=1690803409; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=OTTO3SuefGHXFKOC7d9wUAk5B36x3nPdZybKoY8w/RA=; b=I0yJQHOg9bG3JbzeT8b0UCspH7hw8DYNtxCCur48lOHUBpd3Yu2JwUykNq0bGSybsw 6g/eJrbyjNYJLHTXQtgSWg/1xO11TDHwBXUR/7i8Pb75+aHqKC9wkmkty15GvhmKHDwF tO6JsW7FmoZbSy4w/pgHKf6KlwlYzNMSiRBlPlmVsNin5sDFguGNK9j2C48+kksXSmWK IUuo0EXgHL4mr0Zw+jUgGPQCnFy3MCJVJUg+I+ZCxTH/ICdHuZa1eGdiyHQDIU0XbEQi zw26xjz93NRkUWYrTKhN/Z1qQ+t9fCHCFLcwDAHyFBHwfWkn33+32vGVxqeKJJdg4pq2 rH7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690198609; x=1690803409; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OTTO3SuefGHXFKOC7d9wUAk5B36x3nPdZybKoY8w/RA=; b=HpXMA6qFNJBbEcs4e5BrI5w2bdsq3Ygwg7suCsYCrdSOLavtA0uZcrkiusplWPDLPt C0x/KnWz2c2PJXZ0c4885BkafJ/+wNlz8xYM5wr45C0JNQrLMGEqMnYhHPFE7tw5hvNr J6qjCR/9l0G+VhpqufZlT7YRE/EHNCornDmhx5E2ZI5irJLQmRAXui1kI7N7cmCM5GTA yIpwJHoIR7pV9HiELyg5fjd4ShNtfe84y7zhVfyUpaKg94RxnlVGXfNo1q459Db+7S5M mZnSkx2FfHFtpQ2E8qyIHFIvWgIbV8iWUQ9i1sPW2yVzLDAwmMXYRha4rfXLtd5ujuO7 wUqA== X-Gm-Message-State: ABy/qLbVTjP0/6ktFxv72MOigSPkhTY2Y+qtIddegsasIW08mhS69isN pcM//eK2/lPEMYemhnsUBT7f X-Google-Smtp-Source: APBJJlFt6vBWIk6eu6n72lQIAIYxA/NfGYO0MpQrgJEd+5NqR8NAaJ272WrHr5nKC7B4Jw7Ffak32A== X-Received: by 2002:a17:90a:fc85:b0:267:f329:947d with SMTP id ci5-20020a17090afc8500b00267f329947dmr3234191pjb.33.1690198609593; Mon, 24 Jul 2023 04:36:49 -0700 (PDT) Received: from thinkpad ([117.206.118.29]) by smtp.gmail.com with ESMTPSA id mj8-20020a17090b368800b00268136571fasm1917619pjb.27.2023.07.24.04.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jul 2023 04:36:49 -0700 (PDT) Date: Mon, 24 Jul 2023 17:06:42 +0530 From: Manivannan Sadhasivam To: Yoshihiro Shimoda Cc: jingoohan1@gmail.com, gustavo.pimentel@synopsys.com, lpieralisi@kernel.org, robh+dt@kernel.org, kw@linux.com, bhelgaas@google.com, kishon@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, marek.vasut+renesas@gmail.com, fancer.lancer@gmail.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v18 12/20] PCI: dwc: Expose dw_pcie_ep_exit() to module Message-ID: <20230724113642.GK6291@thinkpad> References: <20230721074452.65545-1-yoshihiro.shimoda.uh@renesas.com> <20230721074452.65545-13-yoshihiro.shimoda.uh@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230721074452.65545-13-yoshihiro.shimoda.uh@renesas.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jul 21, 2023 at 04:44:44PM +0900, Yoshihiro Shimoda wrote: > Since no PCIe controller drivers call this, this change is not required > for now. But, Renesas R-Car Gen4 PCIe controller driver will call this > and if the controller driver is built as a kernel module, the following > build error happens. So, expose dw_pcie_ep_exit() for it. > > ERROR: modpost: "dw_pcie_ep_exit" [drivers/pci/controller/dwc/pcie-rcar-gen4-ep-drv.ko] undefined! > > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Serge Semin Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pcie-designware-ep.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > index bd57516d5313..14c641395c3b 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > @@ -695,6 +695,7 @@ void dw_pcie_ep_exit(struct dw_pcie_ep *ep) > > pci_epc_mem_exit(epc); > } > +EXPORT_SYMBOL_GPL(dw_pcie_ep_exit); > > static unsigned int dw_pcie_ep_find_ext_capability(struct dw_pcie *pci, int cap) > { > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்