From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 609D3C04A6A for ; Mon, 24 Jul 2023 14:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231245AbjGXOb6 (ORCPT ); Mon, 24 Jul 2023 10:31:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230223AbjGXOb4 (ORCPT ); Mon, 24 Jul 2023 10:31:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42CDDA4; Mon, 24 Jul 2023 07:31:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBDE6611AB; Mon, 24 Jul 2023 14:31:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E419C433C8; Mon, 24 Jul 2023 14:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690209114; bh=dksxXLhwSPe4BRdGB7wqMekFr7I5vTyPJlU/kSDu0ZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BuB5PeayfbKDQdYIOdkQ+l8yPS/3V7cliz69ztIy4uV4GUk12s1+he55o+Mgv7pT3 OiRCD6Xuqz+tg7z9bS9F3z4v4a+2uX/oIgIu9W7GkumIWtHQLJM+bf2+f+FJuaymGA anIUtwF7K+UVaA2vlV8QnYF4cdypZQx13x7fpxc1HBuZNuXPHkF8bP+kacyo/Sy5A2 Gl/4ceGLKE7PBQ1rORZ7ELXUj+FapLowpiV86RFZ+hvmQxudrMK5r99Dk98Pajx311 ivFYuuCqmxzJ+Z6kWT8bM7ES0pkT8HAXkpwnIP4n9BzXOqb/TLQO4gME6jonIVn9dY xDQTtIc7f7UIQ== Received: (nullmailer pid 3432565 invoked by uid 1000); Mon, 24 Jul 2023 14:31:52 -0000 Date: Mon, 24 Jul 2023 08:31:52 -0600 From: Rob Herring To: Luca Ceresoli Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Conor Dooley , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Paul Kocialkowski Subject: Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E Message-ID: <20230724143152.GA3430423-robh@kernel.org> References: <20230719152147.355486-1-luca.ceresoli@bootlin.com> <20230719152147.355486-2-luca.ceresoli@bootlin.com> <20230719190254.GA578754-robh@kernel.org> <20230720155238.6fb8ac8c@booty> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230720155238.6fb8ac8c@booty> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Jul 20, 2023 at 03:52:38PM +0200, Luca Ceresoli wrote: > Hello Rob, > > thanks for reviewing. > > On Wed, 19 Jul 2023 13:02:54 -0600 > Rob Herring wrote: > > > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > > > 480x800 panel based on it. > > > > > > Signed-off-by: Luca Ceresoli > > > --- > > > .../display/panel/ilitek,ili9806e.yaml | 69 +++++++++++++++++++ > > > MAINTAINERS | 6 ++ > > > 2 files changed, 75 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > new file mode 100644 > > > index 000000000000..42abc6923065 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili9806e.yaml > > > @@ -0,0 +1,69 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/panel/ilitek,ili9806e.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Ilitek ILI9806E display panels > > > + > > > +maintainers: > > > + - Luca Ceresoli > > > + > > > +description: > > > + This binding is for display panels using an Ilitek ILI9806E controller in > > > + SPI mode. > > > + > > > +allOf: > > > + - $ref: panel-common.yaml# > > > > A SPI device should reference spi-peripheral-props.yaml as well. > > > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > + # ShenZhen New Display Co 3.97" 480x800 RGB a-SI TFT LCD > > > + - newdisplay,nds040480800-v3 > > > + - const: ilitek,ili9806e > > > + > > > + reg: true > > > > maxItems: 1 > > > > > + spi-max-frequency: true > > > + reset-gpios: true > > > + backlight: true > > > + port: true > > > > Drop all these and ... > > > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - port > > > + > > > +additionalProperties: false > > > > ... use "unevaluatedProperties" instead. > > > > > + > > > +examples: > > > + - | > > > + #include > > > + > > > + backlight: backlight { > > > + compatible = "gpio-backlight"; > > > + gpios = <&gpio 22 GPIO_ACTIVE_HIGH>; > > > + }; > > > > The exact backlight is outside the scope of this binding and should be > > dropped from the example. > > As this comes from copy-pasting from the bindings yaml for another > panel, would it be useful if I send a patch to remove it? Yes. Rob