From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA77C0015E for ; Mon, 24 Jul 2023 16:26:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231317AbjGXQ0o (ORCPT ); Mon, 24 Jul 2023 12:26:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230113AbjGXQ0n (ORCPT ); Mon, 24 Jul 2023 12:26:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D084BFF; Mon, 24 Jul 2023 09:26:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 603B961261; Mon, 24 Jul 2023 16:26:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 804F9C433C8; Mon, 24 Jul 2023 16:26:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690216000; bh=NnhraS8BL5Ulb0entmVSGXe3OMU1B/0GaHabwEyEAqU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BO7H22sbEac8N0hk1Xfc94utPCZxOSeEAM9ndel6gZBAiG60AnLS8mftvn57mQXzc yc4oE1Y51O8MxBEN2ArPLcNQoaV2p4e/4K+7LGmv+wX1G9cdba/+z6xshhHEUPvn0o kPITafT4aArXOv8nOhPO2Tjyp0irsZkovf+dkQNATOlxJFNQAoFPQ/2hjJN3noLMW0 ysMf+5w4wZoFK3qqc7wtnwyuPAyQ/jOBT3IYOucfZigRbGBX/BuOvCbp19lQyiNjk/ k5ExV/uCqu9c+SFVjLhrZyvMESYWMbPFghVc1coNq3aWPmEl7OkulX5nvLSFsgUDkc HxRs5zjTRBQGQ== Received: (nullmailer pid 3786398 invoked by uid 1000); Mon, 24 Jul 2023 16:26:38 -0000 Date: Mon, 24 Jul 2023 10:26:38 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Jagan Sridharan , ChiYuan Huang , Min Guo , Gene Chen , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] dt-bindings: usb: add missing unevaluatedProperties on USB connector Message-ID: <20230724162638.GA3784203-robh@kernel.org> References: <20230723071105.40157-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230723071105.40157-1-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Jul 23, 2023 at 09:11:05AM +0200, Krzysztof Kozlowski wrote: > The usb-connector.yaml schema allows any additional properties, thus its > usage should finish with unevaluatedProperties: false. Is it problematic if usb-connector.yaml is restricted? > > Signed-off-by: Krzysztof Kozlowski > --- > Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 1 + > Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml | 1 + > Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 1 + > Documentation/devicetree/bindings/usb/mediatek,musb.yaml | 1 + > Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml | 1 + > Documentation/devicetree/bindings/usb/richtek,rt1719.yaml | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > index 276bf7554215..45e093978b82 100644 > --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml > @@ -25,6 +25,7 @@ properties: > connector: > type: object > $ref: ../connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Properties for usb c connector. > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > index 053264e60583..42b9d3a35c67 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml > @@ -29,6 +29,7 @@ properties: > connector: > type: object > $ref: ../connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Properties for usb c connector. > > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml > index a59d91243ac8..7eb880e4a270 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml > @@ -144,6 +144,7 @@ properties: > > connector: > $ref: /schemas/connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Connector for dual role switch, especially for "gpio-usb-b-connector" > type: object > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.yaml b/Documentation/devicetree/bindings/usb/mediatek,musb.yaml > index a39d38db7714..924f74d45baa 100644 > --- a/Documentation/devicetree/bindings/usb/mediatek,musb.yaml > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.yaml > @@ -66,6 +66,7 @@ properties: > $ref: /schemas/connector/usb-connector.yaml# > description: Connector for dual role switch > type: object > + unevaluatedProperties: false > > dependencies: > usb-role-switch: [ connector ] > diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > index 8da4d2ad1a91..980235e27a7f 100644 > --- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > @@ -36,6 +36,7 @@ properties: > connector: > type: object > $ref: /schemas/connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Properties for usb c connector. > > diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml > index 4ced2f68e2a9..27978580b234 100644 > --- a/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml > +++ b/Documentation/devicetree/bindings/usb/richtek,rt1719.yaml > @@ -34,6 +34,7 @@ properties: > connector: > type: object > $ref: ../connector/usb-connector.yaml# > + unevaluatedProperties: false > description: > Properties for usb c connector. > > -- > 2.34.1 >