From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E820C41513 for ; Tue, 25 Jul 2023 19:14:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbjGYTOL (ORCPT ); Tue, 25 Jul 2023 15:14:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbjGYTOL (ORCPT ); Tue, 25 Jul 2023 15:14:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E3911B8; Tue, 25 Jul 2023 12:14:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE98E61884; Tue, 25 Jul 2023 19:14:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FE35C433C7; Tue, 25 Jul 2023 19:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690312448; bh=o+O/Jk71dzlERNjmO1aGiXrhRze1SOzo9ZcDuG2HzRI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=txQoh0Xv0YRWkHlNo1ZViUjjr40HJHDtEl+xS+rJzK92bEbyR6O5cqzhN4K+6gHtl zYiyfc3a/8rVD8bGT3fK+C3t+qtzj6/6uyT9GLzqATSjFGNqll8XOi622i8sh5zdPO ujWY/5TfNDKJfkntyj4MSP2k5C6T5CHGVOtBch5FU8BaVf+0//7XBIu6vuKY4fmvYd FSxyaNugucGnKRKjYXizjw+Fdi8y4jun72+tARmcE7OElGyZqhakBbQJNAb8qAhq/B 4ShRMaJXRt/gj1wTH1Ta9XB0q7JfNZ7RWCulPFtDwhEj8rtHjQ5bjwID0vBpdf3OWk AfefvidnnxEyA== Date: Tue, 25 Jul 2023 20:14:02 +0100 From: Conor Dooley To: Alexander Stein Cc: Mirela Rabulea , Rob Herring , Ming Qian , Shijie Qin , Zhou Peng , Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Mark Brown , Anson Huang , NXP Linux Team , Pengutronix Kernel Team , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org Subject: Re: [PATCH v2 3/3] dt-bindings: media: imx-jpeg: Add clocks property Message-ID: <20230725-catwalk-reviver-ed7611a15f54@spud> References: <20230724122101.2903318-1-alexander.stein@ew.tq-group.com> <20230724122101.2903318-3-alexander.stein@ew.tq-group.com> <20230724-unscrew-bonnet-3c86da806df3@spud> <1908243.taCxCBeP46@steina-w> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lbf0SnNYlJcLd10g" Content-Disposition: inline In-Reply-To: <1908243.taCxCBeP46@steina-w> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --Lbf0SnNYlJcLd10g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 25, 2023 at 07:31:55AM +0200, Alexander Stein wrote: > Am Montag, 24. Juli 2023, 20:26:15 CEST schrieb Conor Dooley: > > On Mon, Jul 24, 2023 at 02:21:00PM +0200, Alexander Stein wrote: > > > i.MX8 and i.MX8X both use two clocks for accessing the periphery. > > > Add clocks and clock-names properties accordingly. > > >=20 > > > Signed-off-by: Alexander Stein > > > --- > > > Changes in v2: > > > * None > > >=20 > > > .../devicetree/bindings/media/nxp,imx8-jpeg.yaml | 8 ++++++= ++ > > > 1 file changed, 8 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.ya= ml > > > b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml index > > > 3d9d1db37040..2533e16720f2 100644 > > > --- a/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > > > +++ b/Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml > > >=20 > > > @@ -46,6 +46,14 @@ properties: > > > minItems: 2 # Wrapper and 1 slot > > > maxItems: 5 # Wrapper and 4 slots > > >=20 > > > + clocks: > > > + maxItems: 2 > > > + > > > + clock-names: > > > + items: > > > + - const: per > > > + - const: ipg > >=20 > > What do "per" and "ipg" mean? I assume "per" is peripheral? >=20 > Actually I don't know what "ipg" stands for. It's a quite common name on = i.MX=20 > platforms though. I opted for the names currently used in the DT. The dri= ver=20 > doesn't care for the names currently. FWIW, my motivation was wondering how someone would know which clock to put in which. > But cross-checking the reference manual these clocks seems to be called "= jpeg"=20 > and "ips", individually for both jpeg encoder and decoder. Hm, that seems confusing TBH. The reference manual is where I would be going to try and figure out the numbers. > Mirela (added to recipients): As the original author of the DT nodes, cou= ld=20 > you provide additional information regarding the clock names? That'd be great, thanks. --Lbf0SnNYlJcLd10g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZMAe+gAKCRB4tDGHoIJi 0o1UAQC1cnVwXp98JS4HvqzNrw9c8F55gRCUOnjji9asmPeD5AD/WfP3b0aAYSf5 0s/cT0K7cT5JAZnGFpCHwNLOPy1h2g0= =IYFs -----END PGP SIGNATURE----- --Lbf0SnNYlJcLd10g--