Re: [PATCH v3] dt-bindings: clock: tegra124-dfll: Convert to json-schema

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]

Hey,

On Tue, Jul 25, 2023 at 06:20:46PM +0200, Thierry Reding wrote:
> +  nvidia,pwm-to-pmic:
> +    description: Use PWM to control regulator rather then I2C.
> +    $ref: /schemas/types.yaml#/definitions/flag

> +  # required properties for PWM mode
> +  nvidia,pwm-period-nanoseconds:
> +    description: period of PWM square wave in nanoseconds.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 1000
> +    maximum: 1000000000
> +
> +  nvidia,pwm-tristate-microvolts:
> +    description: Regulator voltage in micro volts when PWM control is
> +      disabled and the PWM output is tristated. Note that this voltage
> +      is configured in hardware, typically via a resistor divider.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 3300000
> +
> +  nvidia,pwm-min-microvolts:
> +    description: Regulator voltage in micro volts when PWM control is
> +      enabled and PWM output is low. Hence, this is the minimum output
> +      voltage that the regulator supports when PWM control is enabled.
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 3300000
> +
> +  nvidia,pwm-voltage-step-microvolts:
> +    description: |
> +      Voltage increase in micro volts corresponding to a 1/33th increase
> +      in duty cycle. Eg the voltage for 2/33th duty cycle would be:
> +
> +        nvidia,pwm-min-microvolts + nvidia,pwm-voltage-step-microvolts * 2
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    minimum: 0
> +    maximum: 1000000
> +
> +  pinctrl-names:
> +    items:
> +      # I/O pad configuration when PWM control is enabled
> +      - const: dvfs_pwm_enable
> +      # I/O pad configuration when PWM control is disabled
> +      - const: dvfs_pwm_disable

Should "nvidia,pwm-to-pmic" not have a dependencies thing like:
"nvidia,suspend-mode": ["nvidia,core-pwr-off-time", "nvidia,cpu-pwr-off-time"]
to ensure that the required properties are set?

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]