devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	dan.scally@ideasonboard.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] arm64: dts: imx8mp-debix: remove unused fec pinctrl node
Date: Tue, 25 Jul 2023 15:51:40 +0300	[thread overview]
Message-ID: <20230725125140.GC21640@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230717165127.2882535-1-m.felsch@pengutronix.de>

Hi Marco,

Thank you for the patch.

On Mon, Jul 17, 2023 at 06:51:24PM +0200, Marco Felsch wrote:
> The SoM A make use of the EQOS ethernet interface and not the FEC, so
> drop the FEC pinctrl node from the devicetree.
> 
> Fixes: c86d350aae68 ("arm64: dts: Add device tree for the Debix Model A Board")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

I think the I/O board uses the FEC for its ethernet interface. It would
be nice to eventually move this to an I/O board overlay, but for now,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Changelog:
> 
> v2:
> - new patch
> 
>  .../dts/freescale/imx8mp-debix-model-a.dts    | 22 -------------------
>  1 file changed, 22 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> index b4409349eb3f6..1004ab0abb131 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-model-a.dts
> @@ -355,28 +355,6 @@ MX8MP_IOMUXC_SAI1_TXD6__GPIO4_IO18				0x19
>  		>;
>  	};
>  
> -	pinctrl_fec: fecgrp {
> -		fsl,pins = <
> -			MX8MP_IOMUXC_SAI1_RXD2__ENET1_MDC				0x3
> -			MX8MP_IOMUXC_SAI1_RXD3__ENET1_MDIO				0x3
> -			MX8MP_IOMUXC_SAI1_RXD4__ENET1_RGMII_RD0				0x91
> -			MX8MP_IOMUXC_SAI1_RXD5__ENET1_RGMII_RD1				0x91
> -			MX8MP_IOMUXC_SAI1_RXD6__ENET1_RGMII_RD2				0x91
> -			MX8MP_IOMUXC_SAI1_RXD7__ENET1_RGMII_RD3				0x91
> -			MX8MP_IOMUXC_SAI1_TXC__ENET1_RGMII_RXC				0x91
> -			MX8MP_IOMUXC_SAI1_TXFS__ENET1_RGMII_RX_CTL			0x91
> -			MX8MP_IOMUXC_SAI1_TXD0__ENET1_RGMII_TD0				0x1f
> -			MX8MP_IOMUXC_SAI1_TXD1__ENET1_RGMII_TD1				0x1f
> -			MX8MP_IOMUXC_SAI1_TXD2__ENET1_RGMII_TD2				0x1f
> -			MX8MP_IOMUXC_SAI1_TXD3__ENET1_RGMII_TD3				0x1f
> -			MX8MP_IOMUXC_SAI1_TXD4__ENET1_RGMII_TX_CTL			0x1f
> -			MX8MP_IOMUXC_SAI1_TXD5__ENET1_RGMII_TXC				0x1f
> -			MX8MP_IOMUXC_SAI1_RXD1__ENET1_1588_EVENT1_OUT			0x1f
> -			MX8MP_IOMUXC_SAI1_RXD0__ENET1_1588_EVENT1_IN			0x1f
> -			MX8MP_IOMUXC_SAI1_TXD7__GPIO4_IO19				0x19
> -		>;
> -	};
> -
>  	pinctrl_gpio_led: gpioledgrp {
>  		fsl,pins = <
>  			MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16				0x19

-- 
Regards,

Laurent Pinchart

      parent reply	other threads:[~2023-07-25 12:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 16:51 [PATCH v2 1/4] arm64: dts: imx8mp-debix: remove unused fec pinctrl node Marco Felsch
2023-07-17 16:51 ` [PATCH v2 2/4] dt-bindings: arm: fsl: fix DEBIX binding Marco Felsch
2023-07-17 16:59   ` Krzysztof Kozlowski
2023-07-17 17:14     ` Marco Felsch
2023-07-17 19:45       ` Krzysztof Kozlowski
2023-07-17 17:00   ` Krzysztof Kozlowski
2023-07-17 17:12     ` Marco Felsch
2023-07-17 19:51       ` Krzysztof Kozlowski
2023-07-17 17:17   ` Ahmad Fatoum
2023-07-17 17:24     ` Marco Felsch
2023-07-17 17:38       ` Ahmad Fatoum
2023-07-19  9:34         ` Marco Felsch
2023-07-17 16:51 ` [PATCH v2 3/4] dt-bindings: arm: Add Polyhex DEBIX SOM A based boards Marco Felsch
2023-07-25 12:54   ` Laurent Pinchart
2023-07-17 16:51 ` [PATCH v2 4/4] arm64: dts: freescale: Add DEBIX SOM A and SOM A I/O Board support Marco Felsch
2023-07-18 14:06   ` Fabio Estevam
2023-07-19  8:16   ` Shawn Guo
2023-07-19  9:18     ` Marco Felsch
2023-07-25 13:26   ` Laurent Pinchart
2023-07-31  8:51     ` Marco Felsch
2023-07-25 12:51 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230725125140.GC21640@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=conor+dt@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).