From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23539C001B0 for ; Wed, 26 Jul 2023 11:13:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231838AbjGZLNU (ORCPT ); Wed, 26 Jul 2023 07:13:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233273AbjGZLNT (ORCPT ); Wed, 26 Jul 2023 07:13:19 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BD182696 for ; Wed, 26 Jul 2023 04:13:17 -0700 (PDT) Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOcRv-0001BM-7s; Wed, 26 Jul 2023 13:12:59 +0200 Received: from pengutronix.de (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 0D3BE1FB27F; Wed, 26 Jul 2023 11:12:57 +0000 (UTC) Date: Wed, 26 Jul 2023 13:12:56 +0200 From: Marc Kleine-Budde To: Bough Chen Cc: "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "wg@grandegger.com" , "kernel@pengutronix.de" , dl-linux-imx , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "devicetree@vger.kernel.org" , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: RE: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by GPR Message-ID: <20230726-expedited-clinking-3e7f212352f7-mkl@pengutronix.de> References: <20230726090909.3417030-1-haibo.chen@nxp.com> <20230726-moocher-managing-5a5352a4266a-mkl@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="glv2skkv3tf7s5b2" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:b01:1d::7b X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --glv2skkv3tf7s5b2 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 26.07.2023 11:10:10, Bough Chen wrote: > > > arch/arm64/boot/dts/freescale/imx93.dtsi | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > > > b/arch/arm64/boot/dts/freescale/imx93.dtsi > > > index 4ec9df78f205..d2040019e9c7 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > > > @@ -319,6 +319,7 @@ flexcan1: can@443a0000 { > > > assigned-clock-parents =3D <&clk > > IMX93_CLK_SYS_PLL_PFD1_DIV2>; > > > assigned-clock-rates =3D <40000000>; > > > fsl,clk-source =3D /bits/ 8 <0>; > > > + fsl,stop-mode =3D <&anomix_ns_gpr 0x14 0>; > >=20 > > I think there's a typo in the mainline imx93.dtsi. AFAICS it's supposed= to be > > "aonmix_ns_gpr", not "anomix_ns_gpr". But that's a different problem to > > patch :) >=20 > Yes, this is a typo. > >=20 > > AFAICS, according to imx93, rev2 data sheet, offset 0x14 is 76.6.1.3 QC= HANNEL > > DISABLE (QCH_DIS) and bit 0 is "GPIO1". Are you sure this is the correc= t reg? > >=20 >=20 > Imx93 A1 doc has some update, I double confirm with the internal doc and = IC team, the setting is correct. > I also test on imx93-9x9 qsb board, system can be wakeup by this setting. Thanks for double checking. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --glv2skkv3tf7s5b2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmTA/7UACgkQvlAcSiqK BOj8HAf/ad3k8d8Ns6FEeuNcOzdNMPToWeyL2H6xN/1lD88jnF7pCPAsVt9xajCp lQNb6Y4Nv0av+B2Q1qzdypwz4IIxPdzkkFWA7L3c1+59tO+SKxsJEBU9K9PYEw3b jrR84W40irP0bpSDJIP3VcIfLMa5U8c7LkjNIaZHv73E74GmF1zwGGMasxTYbzNi Hzcqqyg5vXPp0Lyb/PI6Rp+tT/DlelupD3R3BMhhmhBhJ8cWXVVFldPB8G7kys49 CqXRSzvg/X+oKs4didIPKPhUF0ay/HkcY+KuitVm/pi42qYNNKKTaRYKFoTLBAGn Dtxq//ja6lLqhS/+bgOm/7g4F0kTjw== =YycX -----END PGP SIGNATURE----- --glv2skkv3tf7s5b2--