[PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by GPR

[PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by GPR

[haibo.chen]

From: Haibo Chen <haibo.chen@nxp.com>

imx93 A0 chip use the internal q-channel handshake signal in LPCG
and CCM to automatically handle the Flex-CAN stop mode. But this
method meet issue when do the system PM stress test. IC can't fix
it easily. So in the new imx93 A1 chip, IC drop this method, and
involve back the old way，use the GPR method to trigger the Flex-CAN
stop mode signal. Now NXP claim to drop imx93 A0, and only support
imx93 A1. So here add the stop mode through GPR.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx93.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 4ec9df78f205..d2040019e9c7 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -319,6 +319,7 @@ flexcan1: can@443a0000 {
 				assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>;
 				assigned-clock-rates = <40000000>;
 				fsl,clk-source = /bits/ 8 <0>;
+				fsl,stop-mode = <&anomix_ns_gpr 0x14 0>;
 				status = "disabled";
 			};
 
@@ -591,6 +592,7 @@ flexcan2: can@425b0000 {
 				assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>;
 				assigned-clock-rates = <40000000>;
 				fsl,clk-source = /bits/ 8 <0>;
+				fsl,stop-mode = <&wakeupmix_gpr 0x0C 2>;
 				status = "disabled";
 			};
 
-- 
2.34.1

[PATCH v2 2/3] can: flexcan: remove the auto stop mode for IMX93

[haibo.chen]

From: Haibo Chen <haibo.chen@nxp.com>

IMX93 A0 chip involve the internal q-channel handshake in LPCG and
CCM to automatically handle the Flex-CAN IPG STOP signal. Only after
FLEX-CAN enter stop mode then can support the self-wakeup feature.
But meet issue when do the continue system PM stress test. When config
the CAN as wakeup source, the first time after system suspend, any data
on CAN bus can wakeup the system, this is as expect. But the second time
when system suspend, data on CAN bus can't wakeup the system. If continue
this test, we find in odd time system enter suspend, CAN can wakeup the
system, but in even number system enter suspend, CAN can't wakeup the
system. IC find a bug in the auto stop mode logic, and can't fix it easily.
So for the new imx93 A1, IC drop the auto stop mode and involve the
GPR to support stop mode (used before). IC define a bit in GPR which can
trigger the IPG STOP signal to Flex-CAN, let it go into stop mode.
And NXP claim to drop IMX93 A0, and only support IMX93 A1. So this patch
remove the auto stop mode, and add flag FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR
to imx93.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 drivers/net/can/flexcan/flexcan-core.c | 37 ++++----------------------
 drivers/net/can/flexcan/flexcan.h      |  2 --
 2 files changed, 5 insertions(+), 34 deletions(-)

diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
index ff0fc18baf13..a3f3a9c909be 100644
--- a/drivers/net/can/flexcan/flexcan-core.c
+++ b/drivers/net/can/flexcan/flexcan-core.c
@@ -348,7 +348,7 @@ static struct flexcan_devtype_data fsl_imx8mp_devtype_data = {
 static struct flexcan_devtype_data fsl_imx93_devtype_data = {
 	.quirks = FLEXCAN_QUIRK_DISABLE_RXFG | FLEXCAN_QUIRK_ENABLE_EACEN_RRS |
 		FLEXCAN_QUIRK_DISABLE_MECR | FLEXCAN_QUIRK_USE_RX_MAILBOX |
-		FLEXCAN_QUIRK_BROKEN_PERR_STATE | FLEXCAN_QUIRK_AUTO_STOP_MODE |
+		FLEXCAN_QUIRK_BROKEN_PERR_STATE | FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR |
 		FLEXCAN_QUIRK_SUPPORT_FD | FLEXCAN_QUIRK_SUPPORT_ECC |
 		FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX |
 		FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX_RTR,
@@ -544,11 +544,6 @@ static inline int flexcan_enter_stop_mode(struct flexcan_priv *priv)
 	} else if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR) {
 		regmap_update_bits(priv->stm.gpr, priv->stm.req_gpr,
 				   1 << priv->stm.req_bit, 1 << priv->stm.req_bit);
-	} else if (priv->devtype_data.quirks & FLEXCAN_QUIRK_AUTO_STOP_MODE) {
-		/* For the auto stop mode, software do nothing, hardware will cover
-		 * all the operation automatically after system go into low power mode.
-		 */
-		return 0;
 	}
 
 	return flexcan_low_power_enter_ack(priv);
@@ -574,12 +569,6 @@ static inline int flexcan_exit_stop_mode(struct flexcan_priv *priv)
 	reg_mcr &= ~FLEXCAN_MCR_SLF_WAK;
 	priv->write(reg_mcr, &regs->mcr);
 
-	/* For the auto stop mode, hardware will exist stop mode
-	 * automatically after system go out of low power mode.
-	 */
-	if (priv->devtype_data.quirks & FLEXCAN_QUIRK_AUTO_STOP_MODE)
-		return 0;
-
 	return flexcan_low_power_exit_ack(priv);
 }
 
@@ -1994,8 +1983,6 @@ static int flexcan_setup_stop_mode(struct platform_device *pdev)
 		ret = flexcan_setup_stop_mode_scfw(pdev);
 	else if (priv->devtype_data.quirks & FLEXCAN_QUIRK_SETUP_STOP_MODE_GPR)
 		ret = flexcan_setup_stop_mode_gpr(pdev);
-	else if (priv->devtype_data.quirks & FLEXCAN_QUIRK_AUTO_STOP_MODE)
-		ret = 0;
 	else
 		/* return 0 directly if doesn't support stop mode feature */
 		return 0;
@@ -2320,16 +2307,8 @@ static int __maybe_unused flexcan_noirq_suspend(struct device *device)
 	if (netif_running(dev)) {
 		int err;
 
-		if (device_may_wakeup(device)) {
+		if (device_may_wakeup(device))
 			flexcan_enable_wakeup_irq(priv, true);
-			/* For auto stop mode, need to keep the clock on before
-			 * system go into low power mode. After system go into
-			 * low power mode, hardware will config the flexcan into
-			 * stop mode, and gate off the clock automatically.
-			 */
-			if (priv->devtype_data.quirks & FLEXCAN_QUIRK_AUTO_STOP_MODE)
-				return 0;
-		}
 
 		err = pm_runtime_force_suspend(device);
 		if (err)
@@ -2347,15 +2326,9 @@ static int __maybe_unused flexcan_noirq_resume(struct device *device)
 	if (netif_running(dev)) {
 		int err;
 
-		/* For the wakeup in auto stop mode, no need to gate on the
-		 * clock here, hardware will do this automatically.
-		 */
-		if (!(device_may_wakeup(device) &&
-		      priv->devtype_data.quirks & FLEXCAN_QUIRK_AUTO_STOP_MODE)) {
-			err = pm_runtime_force_resume(device);
-			if (err)
-				return err;
-		}
+		err = pm_runtime_force_resume(device);
+		if (err)
+			return err;
 
 		if (device_may_wakeup(device))
 			flexcan_enable_wakeup_irq(priv, false);
diff --git a/drivers/net/can/flexcan/flexcan.h b/drivers/net/can/flexcan/flexcan.h
index 91402977780b..025c3417031f 100644
--- a/drivers/net/can/flexcan/flexcan.h
+++ b/drivers/net/can/flexcan/flexcan.h
@@ -68,8 +68,6 @@
 #define FLEXCAN_QUIRK_SUPPORT_RX_MAILBOX_RTR BIT(15)
 /* Device supports RX via FIFO */
 #define FLEXCAN_QUIRK_SUPPORT_RX_FIFO BIT(16)
-/* auto enter stop mode to support wakeup */
-#define FLEXCAN_QUIRK_AUTO_STOP_MODE BIT(17)
 
 struct flexcan_devtype_data {
 	u32 quirks;		/* quirks needed for different IP cores */
-- 
2.34.1

[PATCH v2 3/3] can: flexcan: lack of stop mode dts properity should not block driver probe

[haibo.chen]

From: Haibo Chen <haibo.chen@nxp.com>

If SoC claim to support stop mode, but dts file do not contain the stop
mode properity, this should not block the driver probe. For this case,
the driver only need to skip the wakeup capable setting which means this
device do not support the feature to wakeup system.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 drivers/net/can/flexcan/flexcan-core.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
index a3f3a9c909be..d8be69f4a0c3 100644
--- a/drivers/net/can/flexcan/flexcan-core.c
+++ b/drivers/net/can/flexcan/flexcan-core.c
@@ -1987,7 +1987,14 @@ static int flexcan_setup_stop_mode(struct platform_device *pdev)
 		/* return 0 directly if doesn't support stop mode feature */
 		return 0;
 
-	if (ret)
+	/* If ret is -EINVAL, this means SoC claim to support stop mode, but
+	 * dts file lack the stop mode property definition. For this case,
+	 * directly return 0, this will skip the wakeup capable setting and
+	 * will not block the driver probe.
+	 */
+	if (ret == -EINVAL)
+		return 0;
+	else if (ret)
 		return ret;
 
 	device_set_wakeup_capable(&pdev->dev, true);
-- 
2.34.1

Re: [PATCH v2 3/3] can: flexcan: lack of stop mode dts properity should not block driver probe

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1793 bytes --]

On 26.07.2023 17:09:09, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> If SoC claim to support stop mode, but dts file do not contain the stop
> mode properity, this should not block the driver probe. For this case,
> the driver only need to skip the wakeup capable setting which means this
> device do not support the feature to wakeup system.

This still breaks old DTS on kernels with patch 2 applied, but not 3.
Please squash this into 2.

> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  drivers/net/can/flexcan/flexcan-core.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/flexcan/flexcan-core.c b/drivers/net/can/flexcan/flexcan-core.c
> index a3f3a9c909be..d8be69f4a0c3 100644
> --- a/drivers/net/can/flexcan/flexcan-core.c
> +++ b/drivers/net/can/flexcan/flexcan-core.c
> @@ -1987,7 +1987,14 @@ static int flexcan_setup_stop_mode(struct platform_device *pdev)
>  		/* return 0 directly if doesn't support stop mode feature */
>  		return 0;
>  
> -	if (ret)
> +	/* If ret is -EINVAL, this means SoC claim to support stop mode, but
> +	 * dts file lack the stop mode property definition. For this case,
> +	 * directly return 0, this will skip the wakeup capable setting and
> +	 * will not block the driver probe.
> +	 */
> +	if (ret == -EINVAL)
> +		return 0;
> +	else if (ret)
>  		return ret;
>  
>  	device_set_wakeup_capable(&pdev->dev, true);
> -- 
> 2.34.1
> 
> 

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [PATCH v2 3/3] can: flexcan: lack of stop mode dts properity should not block driver probe

[Bough Chen]

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 2023年7月26日 18:17
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> wg@grandegger.com; kernel@pengutronix.de; dl-linux-imx
> <linux-imx@nxp.com>; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; devicetree@vger.kernel.org;
> linux-can@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [PATCH v2 3/3] can: flexcan: lack of stop mode dts properity should
> not block driver probe
> 
> On 26.07.2023 17:09:09, haibo.chen@nxp.com wrote:
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > If SoC claim to support stop mode, but dts file do not contain the
> > stop mode properity, this should not block the driver probe. For this
> > case, the driver only need to skip the wakeup capable setting which
> > means this device do not support the feature to wakeup system.
> 
> This still breaks old DTS on kernels with patch 2 applied, but not 3.
> Please squash this into 2.

Okay.

> 
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> >  drivers/net/can/flexcan/flexcan-core.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/can/flexcan/flexcan-core.c
> > b/drivers/net/can/flexcan/flexcan-core.c
> > index a3f3a9c909be..d8be69f4a0c3 100644
> > --- a/drivers/net/can/flexcan/flexcan-core.c
> > +++ b/drivers/net/can/flexcan/flexcan-core.c
> > @@ -1987,7 +1987,14 @@ static int flexcan_setup_stop_mode(struct
> platform_device *pdev)
> >  		/* return 0 directly if doesn't support stop mode feature */
> >  		return 0;
> >
> > -	if (ret)
> > +	/* If ret is -EINVAL, this means SoC claim to support stop mode, but
> > +	 * dts file lack the stop mode property definition. For this case,
> > +	 * directly return 0, this will skip the wakeup capable setting and
> > +	 * will not block the driver probe.
> > +	 */
> > +	if (ret == -EINVAL)
> > +		return 0;
> > +	else if (ret)
> >  		return ret;
> >
> >  	device_set_wakeup_capable(&pdev->dev, true);
> > --
> > 2.34.1
> >
> >
> 
> regards,
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Re: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by GPR

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 2245 bytes --]

On 26.07.2023 17:09:07, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> imx93 A0 chip use the internal q-channel handshake signal in LPCG
> and CCM to automatically handle the Flex-CAN stop mode. But this
> method meet issue when do the system PM stress test. IC can't fix
> it easily. So in the new imx93 A1 chip, IC drop this method, and
> involve back the old way，use the GPR method to trigger the Flex-CAN
> stop mode signal. Now NXP claim to drop imx93 A0, and only support
> imx93 A1. So here add the stop mode through GPR.
> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 4ec9df78f205..d2040019e9c7 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -319,6 +319,7 @@ flexcan1: can@443a0000 {
>  				assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>;
>  				assigned-clock-rates = <40000000>;
>  				fsl,clk-source = /bits/ 8 <0>;
> +				fsl,stop-mode = <&anomix_ns_gpr 0x14 0>;

I think there's a typo in the mainline imx93.dtsi. AFAICS it's supposed
to be "aonmix_ns_gpr", not "anomix_ns_gpr". But that's a different
problem to patch :)

AFAICS, according to imx93, rev2 data sheet, offset 0x14 is 76.6.1.3
QCHANNEL DISABLE (QCH_DIS) and bit 0 is "GPIO1". Are you sure this is
the correct reg?

>  				status = "disabled";
>  			};
>  
> @@ -591,6 +592,7 @@ flexcan2: can@425b0000 {
>  				assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>;
>  				assigned-clock-rates = <40000000>;
>  				fsl,clk-source = /bits/ 8 <0>;
> +				fsl,stop-mode = <&wakeupmix_gpr 0x0C 2>;

looks plausible, please use lower case for hex addresses.

>  				status = "disabled";
>  			};
>  
> -- 
> 2.34.1
> 
>

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by GPR

[Bough Chen]

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: 2023年7月26日 17:57
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> wg@grandegger.com; kernel@pengutronix.de; dl-linux-imx
> <linux-imx@nxp.com>; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; devicetree@vger.kernel.org;
> linux-can@vger.kernel.org; netdev@vger.kernel.org
> Subject: Re: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by
> GPR
> 
> On 26.07.2023 17:09:07, haibo.chen@nxp.com wrote:
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > imx93 A0 chip use the internal q-channel handshake signal in LPCG and
> > CCM to automatically handle the Flex-CAN stop mode. But this method
> > meet issue when do the system PM stress test. IC can't fix it easily.
> > So in the new imx93 A1 chip, IC drop this method, and involve back the
> > old way，use the GPR method to trigger the Flex-CAN stop mode signal.
> > Now NXP claim to drop imx93 A0, and only support
> > imx93 A1. So here add the stop mode through GPR.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx93.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > index 4ec9df78f205..d2040019e9c7 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > @@ -319,6 +319,7 @@ flexcan1: can@443a0000 {
> >  				assigned-clock-parents = <&clk
> IMX93_CLK_SYS_PLL_PFD1_DIV2>;
> >  				assigned-clock-rates = <40000000>;
> >  				fsl,clk-source = /bits/ 8 <0>;
> > +				fsl,stop-mode = <&anomix_ns_gpr 0x14 0>;
> 
> I think there's a typo in the mainline imx93.dtsi. AFAICS it's supposed to be
> "aonmix_ns_gpr", not "anomix_ns_gpr". But that's a different problem to
> patch :)

Yes, this is a typo.
> 
> AFAICS, according to imx93, rev2 data sheet, offset 0x14 is 76.6.1.3 QCHANNEL
> DISABLE (QCH_DIS) and bit 0 is "GPIO1". Are you sure this is the correct reg?
> 

Imx93 A1 doc has some update, I double confirm with the internal doc and IC team, the setting is correct.
I also test on imx93-9x9 qsb board, system can be wakeup by this setting.

> >  				status = "disabled";
> >  			};
> >
> > @@ -591,6 +592,7 @@ flexcan2: can@425b0000 {
> >  				assigned-clock-parents = <&clk
> IMX93_CLK_SYS_PLL_PFD1_DIV2>;
> >  				assigned-clock-rates = <40000000>;
> >  				fsl,clk-source = /bits/ 8 <0>;
> > +				fsl,stop-mode = <&wakeupmix_gpr 0x0C 2>;
> 
> looks plausible, please use lower case for hex addresses.

My bad, will fix.

Best Regards
Haibo Chen

> 
> >  				status = "disabled";
> >  			};
> >
> > --
> > 2.34.1
> >
> >
> 
> regards,
> Marc
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Re: RE: [PATCH v2 1/3] arm64: dts: imx93: add the Flex-CAN stop mode by GPR

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]

On 26.07.2023 11:10:10, Bough Chen wrote:
> > >  arch/arm64/boot/dts/freescale/imx93.dtsi | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > > b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > > index 4ec9df78f205..d2040019e9c7 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > > @@ -319,6 +319,7 @@ flexcan1: can@443a0000 {
> > >  				assigned-clock-parents = <&clk
> > IMX93_CLK_SYS_PLL_PFD1_DIV2>;
> > >  				assigned-clock-rates = <40000000>;
> > >  				fsl,clk-source = /bits/ 8 <0>;
> > > +				fsl,stop-mode = <&anomix_ns_gpr 0x14 0>;
> > 
> > I think there's a typo in the mainline imx93.dtsi. AFAICS it's supposed to be
> > "aonmix_ns_gpr", not "anomix_ns_gpr". But that's a different problem to
> > patch :)
> 
> Yes, this is a typo.
> > 
> > AFAICS, according to imx93, rev2 data sheet, offset 0x14 is 76.6.1.3 QCHANNEL
> > DISABLE (QCH_DIS) and bit 0 is "GPIO1". Are you sure this is the correct reg?
> > 
> 
> Imx93 A1 doc has some update, I double confirm with the internal doc and IC team, the setting is correct.
> I also test on imx93-9x9 qsb board, system can be wakeup by this setting.

Thanks for double checking.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]