devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes
@ 2023-07-12 15:21 Lukasz Majewski
  2023-07-26  8:19 ` Lukasz Majewski
  0 siblings, 1 reply; 5+ messages in thread
From: Lukasz Majewski @ 2023-07-12 15:21 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
	devicetree, linux-arm-kernel, linux-kernel, Lukasz Majewski

Without this change the KSZ9477-EVB board hangs just after passing
execution flow from u-boot to Linux kernel.

This code has been copied from at91-sama5d3_xplained.dts.

Test setup: Linux 6.5-rc1
Config:     arch/arm/configs/sama5_defconfig
Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts  | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
index 14af1fd6d247..99cd6d15998b 100644
--- a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
@@ -162,6 +162,18 @@
 	};
 };
 
+&tcb0 {
+	timer0: timer@0 {
+		compatible = "atmel,tcb-timer";
+		reg = <0>;
+	};
+
+	timer1: timer@1 {
+		compatible = "atmel,tcb-timer";
+		reg = <1>;
+	};
+};
+
 &usb0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usba_vbus>;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes
  2023-07-12 15:21 [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes Lukasz Majewski
@ 2023-07-26  8:19 ` Lukasz Majewski
  2023-07-26 18:33   ` Conor Dooley
  2023-08-02  4:50   ` claudiu beznea
  0 siblings, 2 replies; 5+ messages in thread
From: Lukasz Majewski @ 2023-07-26  8:19 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski
  Cc: Conor Dooley, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
	devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

Dear Community,

> Without this change the KSZ9477-EVB board hangs just after passing
> execution flow from u-boot to Linux kernel.
> 
> This code has been copied from at91-sama5d3_xplained.dts.
> 
> Test setup: Linux 6.5-rc1
> Config:     arch/arm/configs/sama5_defconfig
> Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
>  .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts  | 12
> ++++++++++++ 1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
> 14af1fd6d247..99cd6d15998b 100644 ---
> a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
> +162,18 @@ };
>  };
>  
> +&tcb0 {
> +	timer0: timer@0 {
> +		compatible = "atmel,tcb-timer";
> +		reg = <0>;
> +	};
> +
> +	timer1: timer@1 {
> +		compatible = "atmel,tcb-timer";
> +		reg = <1>;
> +	};
> +};
> +
>  &usb0 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usba_vbus>;

Gentle ping on this fix ...


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes
  2023-07-26  8:19 ` Lukasz Majewski
@ 2023-07-26 18:33   ` Conor Dooley
  2023-07-27  5:37     ` claudiu beznea
  2023-08-02  4:50   ` claudiu beznea
  1 sibling, 1 reply; 5+ messages in thread
From: Conor Dooley @ 2023-07-26 18:33 UTC (permalink / raw)
  To: Lukasz Majewski
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Nicolas Ferre,
	Alexandre Belloni, Claudiu Beznea, devicetree, linux-arm-kernel,
	linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

On Wed, Jul 26, 2023 at 10:19:02AM +0200, Lukasz Majewski wrote:
> Dear Community,
> 
> > Without this change the KSZ9477-EVB board hangs just after passing
> > execution flow from u-boot to Linux kernel.
> > 
> > This code has been copied from at91-sama5d3_xplained.dts.
> > 
> > Test setup: Linux 6.5-rc1
> > Config:     arch/arm/configs/sama5_defconfig
> > Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >  .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts  | 12
> > ++++++++++++ 1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
> > b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
> > 14af1fd6d247..99cd6d15998b 100644 ---
> > a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
> > b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
> > +162,18 @@ };
> >  };
> >  
> > +&tcb0 {
> > +	timer0: timer@0 {
> > +		compatible = "atmel,tcb-timer";
> > +		reg = <0>;
> > +	};
> > +
> > +	timer1: timer@1 {
> > +		compatible = "atmel,tcb-timer";
> > +		reg = <1>;
> > +	};
> > +};
> > +
> >  &usb0 {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_usba_vbus>;
> 
> Gentle ping on this fix ...

Claudiu has left Microchip, so things might've got a bit lost on the
way. I've added his new address, Claudiu, will you take a look/pick this
up please? I can also do it if that is easier for you.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes
  2023-07-26 18:33   ` Conor Dooley
@ 2023-07-27  5:37     ` claudiu beznea
  0 siblings, 0 replies; 5+ messages in thread
From: claudiu beznea @ 2023-07-27  5:37 UTC (permalink / raw)
  To: Conor Dooley, Lukasz Majewski
  Cc: devicetree, Alexandre Belloni, linux-kernel, Conor Dooley,
	Rob Herring, Krzysztof Kozlowski, Claudiu Beznea,
	linux-arm-kernel



On 26.07.2023 21:33, Conor Dooley wrote:
> On Wed, Jul 26, 2023 at 10:19:02AM +0200, Lukasz Majewski wrote:
>> Dear Community,
>>
>>> Without this change the KSZ9477-EVB board hangs just after passing
>>> execution flow from u-boot to Linux kernel.
>>>
>>> This code has been copied from at91-sama5d3_xplained.dts.
>>>
>>> Test setup: Linux 6.5-rc1
>>> Config:     arch/arm/configs/sama5_defconfig
>>> Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
>>>
>>> Signed-off-by: Lukasz Majewski <lukma@denx.de>
>>> ---
>>>   .../boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts  | 12
>>> ++++++++++++ 1 file changed, 12 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
>>> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
>>> 14af1fd6d247..99cd6d15998b 100644 ---
>>> a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
>>> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -162,6
>>> +162,18 @@ };
>>>   };
>>>   
>>> +&tcb0 {
>>> +	timer0: timer@0 {
>>> +		compatible = "atmel,tcb-timer";
>>> +		reg = <0>;
>>> +	};
>>> +
>>> +	timer1: timer@1 {
>>> +		compatible = "atmel,tcb-timer";
>>> +		reg = <1>;
>>> +	};
>>> +};
>>> +
>>>   &usb0 {
>>>   	pinctrl-names = "default";
>>>   	pinctrl-0 = <&pinctrl_usba_vbus>;
>>
>> Gentle ping on this fix ...
> 
> Claudiu has left Microchip, so things might've got a bit lost on the
> way. I've added his new address, Claudiu, will you take a look/pick this
> up please? I can also do it if that is easier for you.

It's on my list.

Thanks,
Claudiu

> 
> Thanks,
> Conor.
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes
  2023-07-26  8:19 ` Lukasz Majewski
  2023-07-26 18:33   ` Conor Dooley
@ 2023-08-02  4:50   ` claudiu beznea
  1 sibling, 0 replies; 5+ messages in thread
From: claudiu beznea @ 2023-08-02  4:50 UTC (permalink / raw)
  To: Lukasz Majewski, Rob Herring, Krzysztof Kozlowski
  Cc: devicetree, Conor Dooley, Alexandre Belloni, linux-kernel,
	Claudiu Beznea, linux-arm-kernel



On 26.07.2023 11:19, Lukasz Majewski wrote:
> Dear Community,
> 
>> Without this change the KSZ9477-EVB board hangs just after passing
>> execution flow from u-boot to Linux kernel.
>>
>> This code has been copied from at91-sama5d3_xplained.dts.
>>
>> Test setup: Linux 6.5-rc1
>> Config:     arch/arm/configs/sama5_defconfig
>> Toolchain:  gcc-linaro-7.3.1-2018.05-x86_64_arm-linux-gnueabi
>>
>> Signed-off-by: Lukasz Majewski <lukma@denx.de>

Applied to at91-dt, thanks!

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-08-02  4:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-12 15:21 [PATCH] ARM: dts: at91: ksz9477_evb: Add missing timer nodes Lukasz Majewski
2023-07-26  8:19 ` Lukasz Majewski
2023-07-26 18:33   ` Conor Dooley
2023-07-27  5:37     ` claudiu beznea
2023-08-02  4:50   ` claudiu beznea

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).