* [PATCH 2/3] drm/panel: Relax porches for HannStar HSD101PWW2
2023-07-26 18:48 [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS Thierry Reding
@ 2023-07-26 18:48 ` Thierry Reding
2023-07-26 18:48 ` [PATCH 3/3] ARM: tegra: Use Hannstar HSD101PWW2 on Pegatron Chagall Thierry Reding
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2023-07-26 18:48 UTC (permalink / raw)
To: Laurent Pinchart, Neil Armstrong, Sam Ravnborg, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding
Cc: Jon Hunter, Svyatoslav Ryhel, dri-devel, devicetree, linux-tegra
From: Thierry Reding <treding@nvidia.com>
The porch maximum values for the HannStar HSD101PWW2 are unusually
small. Make them a bit larger to allow a more flexibility when
overriding the timings in device tree. Unfortunately the datasheet
doesn't list porch limits in detail, so this is a bit of guesswork.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/panel/panel-simple.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 4badda6570d5..4bab181e9d4b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2104,13 +2104,13 @@ static const struct panel_desc hannstar_hsd100pxn1 = {
static const struct display_timing hannstar_hsd101pww2_timing = {
.pixelclock = { 64300000, 71100000, 82000000 },
.hactive = { 1280, 1280, 1280 },
- .hfront_porch = { 1, 1, 10 },
- .hback_porch = { 1, 1, 10 },
- .hsync_len = { 58, 158, 661 },
+ .hfront_porch = { 1, 1, 64 },
+ .hback_porch = { 1, 1, 64 },
+ .hsync_len = { 58, 158, 553 },
.vactive = { 800, 800, 800 },
- .vfront_porch = { 1, 1, 10 },
- .vback_porch = { 1, 1, 10 },
- .vsync_len = { 1, 21, 203 },
+ .vfront_porch = { 1, 1, 32 },
+ .vback_porch = { 1, 1, 32 },
+ .vsync_len = { 1, 21, 159 },
.flags = DISPLAY_FLAGS_DE_HIGH,
};
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/3] ARM: tegra: Use Hannstar HSD101PWW2 on Pegatron Chagall
2023-07-26 18:48 [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS Thierry Reding
2023-07-26 18:48 ` [PATCH 2/3] drm/panel: Relax porches for HannStar HSD101PWW2 Thierry Reding
@ 2023-07-26 18:48 ` Thierry Reding
2023-07-27 7:12 ` [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS Krzysztof Kozlowski
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2023-07-26 18:48 UTC (permalink / raw)
To: Laurent Pinchart, Neil Armstrong, Sam Ravnborg, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding
Cc: Jon Hunter, Svyatoslav Ryhel, dri-devel, devicetree, linux-tegra
From: Thierry Reding <treding@nvidia.com>
The LVDS bindings require a specific compatible string in addition to
the generic "panel-lvds". Add the HannStar HSD101PWW2 which is used on
a similar device (ASUS TF201) and seems to work fine with slightly
modified timings in DT.
Suggested-by: Svyatoslav Ryhel <clamor95@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
arch/arm/boot/dts/nvidia/tegra30-pegatron-chagall.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nvidia/tegra30-pegatron-chagall.dts b/arch/arm/boot/dts/nvidia/tegra30-pegatron-chagall.dts
index c81d5875c31c..4012f9c799a8 100644
--- a/arch/arm/boot/dts/nvidia/tegra30-pegatron-chagall.dts
+++ b/arch/arm/boot/dts/nvidia/tegra30-pegatron-chagall.dts
@@ -2628,7 +2628,7 @@ cpu3: cpu@3 {
};
display-panel {
- compatible = "panel-lvds";
+ compatible = "hannstar,hsd101pww2", "panel-lvds";
width-mm = <217>;
height-mm = <136>;
--
2.41.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS
2023-07-26 18:48 [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS Thierry Reding
2023-07-26 18:48 ` [PATCH 2/3] drm/panel: Relax porches for HannStar HSD101PWW2 Thierry Reding
2023-07-26 18:48 ` [PATCH 3/3] ARM: tegra: Use Hannstar HSD101PWW2 on Pegatron Chagall Thierry Reding
@ 2023-07-27 7:12 ` Krzysztof Kozlowski
2023-07-27 7:52 ` Laurent Pinchart
2023-07-27 15:18 ` (subset) " Thierry Reding
4 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-27 7:12 UTC (permalink / raw)
To: Thierry Reding, Laurent Pinchart, Neil Armstrong, Sam Ravnborg,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Jon Hunter, Svyatoslav Ryhel, dri-devel, devicetree, linux-tegra
On 26/07/2023 20:48, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct
> bindings file.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS
2023-07-26 18:48 [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS Thierry Reding
` (2 preceding siblings ...)
2023-07-27 7:12 ` [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS Krzysztof Kozlowski
@ 2023-07-27 7:52 ` Laurent Pinchart
2023-07-27 15:18 ` (subset) " Thierry Reding
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2023-07-27 7:52 UTC (permalink / raw)
To: Thierry Reding
Cc: Neil Armstrong, Sam Ravnborg, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jon Hunter, Svyatoslav Ryhel, dri-devel, devicetree,
linux-tegra
Hi Thierry,
Thank you for the patch.
On Wed, Jul 26, 2023 at 08:48:55PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct
> bindings file.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 ++
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 --
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> index 929fe046d1e7..344e5df40c2f 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> @@ -40,6 +40,8 @@ properties:
> items:
> - enum:
> - auo,b101ew05
> + # HannStar Display Corp. HSD101PWW2 10.1" WXGA (1280x800) LVDS panel
> + - hannstar,hsd101pww2
> - tbs,a711-panel
>
> - const: panel-lvds
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index df1cec8fd21b..f4d9da4afefd 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -168,8 +168,6 @@ properties:
> - hannstar,hsd070pww1
> # HannStar Display Corp. HSD100PXN1 10.1" XGA LVDS panel
> - hannstar,hsd100pxn1
I'm wondering if it would make sense to move them all in one go ?
Regardless, this patch is OK, so
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> - # HannStar Display Corp. HSD101PWW2 10.1" WXGA (1280x800) LVDS panel
> - - hannstar,hsd101pww2
> # Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel
> - hit,tx23d38vm0caa
> # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: (subset) [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS
2023-07-26 18:48 [PATCH 1/3] dt-bindings: display: panel: Move HannStar HSD101PWW2 to LVDS Thierry Reding
` (3 preceding siblings ...)
2023-07-27 7:52 ` Laurent Pinchart
@ 2023-07-27 15:18 ` Thierry Reding
4 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2023-07-27 15:18 UTC (permalink / raw)
To: Laurent Pinchart, Neil Armstrong, Sam Ravnborg, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Thierry Reding
Cc: Jon Hunter, Svyatoslav Ryhel, dri-devel, devicetree, linux-tegra
From: Thierry Reding <treding@nvidia.com>
On Wed, 26 Jul 2023 20:48:55 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The HannStar HSD101PWW2 is an LVDS panel, so move it to the correct
> bindings file.
>
>
Applied, thanks!
[3/3] ARM: tegra: Use Hannstar HSD101PWW2 on Pegatron Chagall
commit: b28d3af99ac4885f136f6330fec6499b15ad5b25
Best regards,
--
Thierry Reding <treding@nvidia.com>
^ permalink raw reply [flat|nested] 6+ messages in thread