* [PATCH v3 27/50] dt-bindings: usb: atmel: add sam9x7
@ 2023-07-28 10:27 Varshini Rajendran
2023-07-28 16:42 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Varshini Rajendran @ 2023-07-28 10:27 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, conor+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, linux-usb, devicetree,
linux-arm-kernel, linux-kernel
Cc: varshini.rajendran
Add sam9x7 bindings.
Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
Documentation/devicetree/bindings/usb/atmel-usb.txt | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
index 12183ef47ee4..82bd0dbc2a48 100644
--- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
+++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
@@ -3,8 +3,9 @@ Atmel SOC USB controllers
OHCI
Required properties:
- - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers
- used in host mode.
+ - compatible: Should be "atmel,at91rm9200-ohci" or
+ "microchip,sam9x7-ohci", "atmel,at91rm9200-ohci"
+ for USB controllers used in host mode.
- reg: Address and length of the register set for the device
- interrupts: Should contain ohci interrupt
- clocks: Should reference the peripheral, host and system clocks
@@ -30,8 +31,9 @@ usb0: ohci@500000 {
EHCI
Required properties:
- - compatible: Should be "atmel,at91sam9g45-ehci" for USB controllers
- used in host mode.
+ - compatible: Should be "atmel,at91sam9g45-ehci" or
+ "microchip,sam9x7-ehci", "atmel,at91sam9g45-ehci"
+ for USB controllers used in host mode.
- reg: Address and length of the register set for the device
- interrupts: Should contain ehci interrupt
- clocks: Should reference the peripheral and the UTMI clocks
@@ -87,6 +89,7 @@ Required properties:
"atmel,at91sam9g45-udc"
"atmel,sama5d3-udc"
"microchip,sam9x60-udc"
+ "microchip,sam9x7-udc", "microchip,sam9x60-udc"
"microchip,lan9662-udc"
For "microchip,lan9662-udc" the fallback "atmel,sama5d3-udc"
is required.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3 27/50] dt-bindings: usb: atmel: add sam9x7
2023-07-28 10:27 [PATCH v3 27/50] dt-bindings: usb: atmel: add sam9x7 Varshini Rajendran
@ 2023-07-28 16:42 ` Krzysztof Kozlowski
2023-07-28 19:15 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 16:42 UTC (permalink / raw)
To: Varshini Rajendran, gregkh, robh+dt, krzysztof.kozlowski+dt,
conor+dt, nicolas.ferre, alexandre.belloni, claudiu.beznea,
linux-usb, devicetree, linux-arm-kernel, linux-kernel
On 28/07/2023 12:27, Varshini Rajendran wrote:
> Add sam9x7 bindings.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
> Documentation/devicetree/bindings/usb/atmel-usb.txt | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> index 12183ef47ee4..82bd0dbc2a48 100644
> --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> @@ -3,8 +3,9 @@ Atmel SOC USB controllers
> OHCI
>
> Required properties:
> - - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers
> - used in host mode.
> + - compatible: Should be "atmel,at91rm9200-ohci" or
> + "microchip,sam9x7-ohci", "atmel,at91rm9200-ohci"
> + for USB controllers used in host mode.
> - reg: Address and length of the register set for the device
> - interrupts: Should contain ohci interrupt
> - clocks: Should reference the peripheral, host and system clocks
> @@ -30,8 +31,9 @@ usb0: ohci@500000 {
> EHCI
>
> Required properties:
> - - compatible: Should be "atmel,at91sam9g45-ehci" for USB controllers
> - used in host mode.
> + - compatible: Should be "atmel,at91sam9g45-ehci" or
> + "microchip,sam9x7-ehci", "atmel,at91sam9g45-ehci"
This confuses me. Isn't microchip,sam9x7-ehci already described in EHCI
bindings?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3 27/50] dt-bindings: usb: atmel: add sam9x7
2023-07-28 16:42 ` Krzysztof Kozlowski
@ 2023-07-28 19:15 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-07-28 19:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Varshini Rajendran, gregkh, krzysztof.kozlowski+dt, conor+dt,
nicolas.ferre, alexandre.belloni, claudiu.beznea, linux-usb,
devicetree, linux-arm-kernel, linux-kernel
On Fri, Jul 28, 2023 at 06:42:53PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:27, Varshini Rajendran wrote:
> > Add sam9x7 bindings.
> >
> > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> > ---
> > Documentation/devicetree/bindings/usb/atmel-usb.txt | 11 +++++++----
> > 1 file changed, 7 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > index 12183ef47ee4..82bd0dbc2a48 100644
> > --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > @@ -3,8 +3,9 @@ Atmel SOC USB controllers
> > OHCI
> >
> > Required properties:
> > - - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers
> > - used in host mode.
> > + - compatible: Should be "atmel,at91rm9200-ohci" or
> > + "microchip,sam9x7-ohci", "atmel,at91rm9200-ohci"
> > + for USB controllers used in host mode.
> > - reg: Address and length of the register set for the device
> > - interrupts: Should contain ohci interrupt
> > - clocks: Should reference the peripheral, host and system clocks
> > @@ -30,8 +31,9 @@ usb0: ohci@500000 {
> > EHCI
> >
> > Required properties:
> > - - compatible: Should be "atmel,at91sam9g45-ehci" for USB controllers
> > - used in host mode.
> > + - compatible: Should be "atmel,at91sam9g45-ehci" or
> > + "microchip,sam9x7-ehci", "atmel,at91sam9g45-ehci"
>
> This confuses me. Isn't microchip,sam9x7-ehci already described in EHCI
> bindings?
The Atmel .dts (including the one in this series) files use usb-ohci and
usb-ehci compatibles, but they have extra properties (and clocks are
different IIRC). So they aren't 'generic' and should drop those
compatibles. There's already warnings generated for this, but obviously
no one is paying attention.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-28 19:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 10:27 [PATCH v3 27/50] dt-bindings: usb: atmel: add sam9x7 Varshini Rajendran
2023-07-28 16:42 ` Krzysztof Kozlowski
2023-07-28 19:15 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).