devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 28/50] dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt
@ 2023-07-28 10:28 Varshini Rajendran
  2023-07-28 12:39 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Varshini Rajendran @ 2023-07-28 10:28 UTC (permalink / raw)
  To: wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt,
	nicolas.ferre, alexandre.belloni, claudiu.beznea, eugen.hristev,
	linux-watchdog, devicetree, linux-arm-kernel, linux-kernel
  Cc: varshini.rajendran

Add compatible microchip,sam9x7-wdt to DT bindings documentation.

Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
 .../bindings/watchdog/atmel,sama5d4-wdt.yaml      | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
index 816f85ee2c77..ce3d046e7244 100644
--- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
@@ -14,10 +14,17 @@ allOf:
 
 properties:
   compatible:
-    enum:
-      - atmel,sama5d4-wdt
-      - microchip,sam9x60-wdt
-      - microchip,sama7g5-wdt
+    oneOf:
+      - items:
+          - enum:
+              - atmel,sama5d4-wdt
+              - microchip,sam9x60-wdt
+              - microchip,sama7g5-wdt
+      - items:
+          - enum:
+              - microchip,sam9x7-wdt
+          - enum:
+              - microchip,sam9x60-wdt
 
   reg:
     maxItems: 1
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 28/50] dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt
  2023-07-28 10:28 [PATCH v3 28/50] dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt Varshini Rajendran
@ 2023-07-28 12:39 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 12:39 UTC (permalink / raw)
  To: Varshini Rajendran, wim, linux, robh+dt, krzysztof.kozlowski+dt,
	conor+dt, nicolas.ferre, alexandre.belloni, claudiu.beznea,
	eugen.hristev, linux-watchdog, devicetree, linux-arm-kernel,
	linux-kernel

On 28/07/2023 12:28, Varshini Rajendran wrote:
> Add compatible microchip,sam9x7-wdt to DT bindings documentation.
> 
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
>  .../bindings/watchdog/atmel,sama5d4-wdt.yaml      | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> index 816f85ee2c77..ce3d046e7244 100644
> --- a/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/atmel,sama5d4-wdt.yaml
> @@ -14,10 +14,17 @@ allOf:
>  
>  properties:
>    compatible:
> -    enum:
> -      - atmel,sama5d4-wdt
> -      - microchip,sam9x60-wdt
> -      - microchip,sama7g5-wdt
> +    oneOf:
> +      - items:

Drop items.

> +          - enum:
> +              - atmel,sama5d4-wdt
> +              - microchip,sam9x60-wdt
> +              - microchip,sama7g5-wdt
> +      - items:
> +          - enum:
> +              - microchip,sam9x7-wdt
> +          - enum:

Not an enum.

It is surprising how the same change look different between two of your
patches.


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-28 12:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 10:28 [PATCH v3 28/50] dt-bindings: watchdog: sama5d4-wdt: add compatible for sam9x7-wdt Varshini Rajendran
2023-07-28 12:39 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).