devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: BCM53573: Add Ethernet interfaces links
@ 2023-07-24 10:12 Rafał Miłecki
  2023-07-28 17:28 ` Florian Fainelli
  0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2023-07-24 10:12 UTC (permalink / raw)
  To: Florian Fainelli
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
	linux-arm-kernel, bcm-kernel-feedback-list,
	Rafał Miłecki

From: Rafał Miłecki <rafal@milecki.pl>

BCM53573 has 2 Ethernet interfaces each connected to one of switch ports
in the default design. They both use fixed links.

An exception are Luxul XAP devices that have switch replaced by a single
PHY.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 .../boot/dts/broadcom/bcm47189-luxul-xap-1440.dts    |  2 ++
 .../arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts |  2 ++
 arch/arm/boot/dts/broadcom/bcm53573.dtsi             | 12 ++++++++++++
 3 files changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
index e86e82be3c0e..ac44c745bdf8 100644
--- a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts
@@ -50,6 +50,8 @@ &gmac0 {
 	phy-mode = "rgmii";
 	phy-handle = <&bcm54210e>;
 
+	/delete-node/ fixed-link;
+
 	mdio {
 		/delete-node/ switch@1e;
 
diff --git a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts
index d0bbc01f1806..fd071da26cfa 100644
--- a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts
+++ b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts
@@ -86,6 +86,8 @@ &gmac0 {
 	phy-mode = "rgmii";
 	phy-handle = <&bcm54210e>;
 
+	/delete-node/ fixed-link;
+
 	mdio {
 		/delete-node/ switch@1e;
 
diff --git a/arch/arm/boot/dts/broadcom/bcm53573.dtsi b/arch/arm/boot/dts/broadcom/bcm53573.dtsi
index 10d0fe76ee3c..2df80740d181 100644
--- a/arch/arm/boot/dts/broadcom/bcm53573.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm53573.dtsi
@@ -181,6 +181,12 @@ ohci_port2: port@2 {
 
 		gmac0: ethernet@5000 {
 			reg = <0x5000 0x1000>;
+			phy-mode = "internal";
+
+			fixed-link {
+				speed = <1000>;
+				full-duplex;
+			};
 
 			mdio {
 				#address-cells = <1>;
@@ -237,6 +243,12 @@ port@8 {
 
 		gmac1: ethernet@b000 {
 			reg = <0xb000 0x1000>;
+			phy-mode = "internal";
+
+			fixed-link {
+				speed = <1000>;
+				full-duplex;
+			};
 		};
 
 		pmu@12000 {
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: BCM53573: Add Ethernet interfaces links
  2023-07-24 10:12 [PATCH] ARM: dts: BCM53573: Add Ethernet interfaces links Rafał Miłecki
@ 2023-07-28 17:28 ` Florian Fainelli
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2023-07-28 17:28 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Rafał Miłecki
  Cc: Florian Fainelli, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	devicetree, linux-arm-kernel, Rafał Miłecki

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

From: Florian Fainelli <f.fainelli@gmail.com>

On Mon, 24 Jul 2023 12:12:27 +0200, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> BCM53573 has 2 Ethernet interfaces each connected to one of switch ports
> in the default design. They both use fixed links.
> 
> An exception are Luxul XAP devices that have switch replaced by a single
> PHY.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-28 17:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-24 10:12 [PATCH] ARM: dts: BCM53573: Add Ethernet interfaces links Rafał Miłecki
2023-07-28 17:28 ` Florian Fainelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).