From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Varshini Rajendran <varshini.rajendran@microchip.com>,
gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7
Date: Fri, 28 Jul 2023 13:22:59 -0600 [thread overview]
Message-ID: <20230728192259.GA1164895-robh@kernel.org> (raw)
In-Reply-To: <c03f4364-3d97-531a-8acc-aae68de39562@linaro.org>
On Fri, Jul 28, 2023 at 01:48:01PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:28, Varshini Rajendran wrote:
> > Document sam9x7 compatible for usb ohci.
> >
> > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> > ---
> > Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > index be268e23ca79..a2490759f694 100644
> > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > @@ -57,6 +57,12 @@ properties:
> > - nxp,ohci-nxp
> > - st,spear600-ohci
> > - const: usb-ohci
> > + - items:
> > + - enum:
> > + - microchip,sam9x7-ohci
> > + - enum:
>
> That's not an enum. You cannot have here different compatibles.
>
> > + - atmel,at91rm9200-ohci
> > + - const: usb-ohci
As mentioned elsewhere, you aren't really compatible having custom
properties. If you are adding this here, then stuff should be removed
from the .txt binding. You need to sort out this mess and the existing
warnings with 'usb-ohci' in Atmel dts files before adding on to it.
Rob
prev parent reply other threads:[~2023-07-28 19:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 10:28 [PATCH v3 33/50] dt-bindings: usb: add sam9x7 Varshini Rajendran
2023-07-28 11:48 ` Krzysztof Kozlowski
2023-07-28 19:22 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728192259.GA1164895-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=varshini.rajendran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).