* [PATCH v3 33/50] dt-bindings: usb: add sam9x7
@ 2023-07-28 10:28 Varshini Rajendran
2023-07-28 11:48 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Varshini Rajendran @ 2023-07-28 10:28 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, conor+dt, linux-usb,
devicetree, linux-kernel
Cc: varshini.rajendran
Document sam9x7 compatible for usb ohci.
Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
---
Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index be268e23ca79..a2490759f694 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -57,6 +57,12 @@ properties:
- nxp,ohci-nxp
- st,spear600-ohci
- const: usb-ohci
+ - items:
+ - enum:
+ - microchip,sam9x7-ohci
+ - enum:
+ - atmel,at91rm9200-ohci
+ - const: usb-ohci
reg:
maxItems: 1
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7
2023-07-28 10:28 [PATCH v3 33/50] dt-bindings: usb: add sam9x7 Varshini Rajendran
@ 2023-07-28 11:48 ` Krzysztof Kozlowski
2023-07-28 19:22 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-28 11:48 UTC (permalink / raw)
To: Varshini Rajendran, gregkh, robh+dt, krzysztof.kozlowski+dt,
conor+dt, linux-usb, devicetree, linux-kernel
On 28/07/2023 12:28, Varshini Rajendran wrote:
> Document sam9x7 compatible for usb ohci.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> ---
> Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index be268e23ca79..a2490759f694 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -57,6 +57,12 @@ properties:
> - nxp,ohci-nxp
> - st,spear600-ohci
> - const: usb-ohci
> + - items:
> + - enum:
> + - microchip,sam9x7-ohci
> + - enum:
That's not an enum. You cannot have here different compatibles.
> + - atmel,at91rm9200-ohci
> + - const: usb-ohci
>
> reg:
> maxItems: 1
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7
2023-07-28 11:48 ` Krzysztof Kozlowski
@ 2023-07-28 19:22 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2023-07-28 19:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Varshini Rajendran, gregkh, krzysztof.kozlowski+dt, conor+dt,
linux-usb, devicetree, linux-kernel
On Fri, Jul 28, 2023 at 01:48:01PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:28, Varshini Rajendran wrote:
> > Document sam9x7 compatible for usb ohci.
> >
> > Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> > ---
> > Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > index be268e23ca79..a2490759f694 100644
> > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > @@ -57,6 +57,12 @@ properties:
> > - nxp,ohci-nxp
> > - st,spear600-ohci
> > - const: usb-ohci
> > + - items:
> > + - enum:
> > + - microchip,sam9x7-ohci
> > + - enum:
>
> That's not an enum. You cannot have here different compatibles.
>
> > + - atmel,at91rm9200-ohci
> > + - const: usb-ohci
As mentioned elsewhere, you aren't really compatible having custom
properties. If you are adding this here, then stuff should be removed
from the .txt binding. You need to sort out this mess and the existing
warnings with 'usb-ohci' in Atmel dts files before adding on to it.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-28 19:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 10:28 [PATCH v3 33/50] dt-bindings: usb: add sam9x7 Varshini Rajendran
2023-07-28 11:48 ` Krzysztof Kozlowski
2023-07-28 19:22 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).