devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Svyatoslav Ryhel <clamor95@gmail.com>
To: "Andi Shyti" <andi.shyti@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Wolfram Sang" <wsa@kernel.org>,
	"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
	"Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 0/2] GPIO-based hotplug i2c bus
Date: Sat, 29 Jul 2023 19:08:55 +0300	[thread overview]
Message-ID: <20230729160857.6332-1-clamor95@gmail.com> (raw)

ASUS Transformers require this driver for proper work with their dock.
Dock is controlled by EC and its presence is detected by a GPIO.

The Transformers have a connector that's used for USB, charging or
for attaching a keyboard (called a dock; it also has a battery and
a touchpad). This connector probably (I don't have the means to verify
that) has an I2C bus lines and a "detect" line (pulled low on the dock
side) among the pins. I guess there is either no additional chip or
a transparent bridge/buffer chip, but nothing that could be controlled
by software. For DT this setup could be modelled like an I2C gate or
a 2-port mux with enable joining two I2C buses (one "closer" to the
CPU as a parent).

In this case it's hard to tell the difference if this is real or virtual
hardware.

This patchset is a predecessor of a possible larger patchset which
should bring support for a asus-ec, an i2c mfd device programmed by
Asus for their Transformers tablet line. Similar approach is used in
Microsoft Surface RT for attachable Type Cover.

> What is this actually doing?
Basically it duplicates the parent i2c bus once detection GPIO triggers
and probes all hot-pluggable devices which are connected to it. Once
GPIO triggers a detach signal all hot-pluggable devices are unprobed and
bus removed.

> Is the GPIO an irq line for signalling hoplugging and can be used by
> any driver or just this one?
It can be shared if necessary but usually all hot-pluggable devices
are gathered in one container and are plugged simultaneously.

---
Changes from v2:
- expanded descryption of driver implementation commit
- expanded descryption in patchset cover
- no changes to code or yaml from v2

Changes from v1:
- documentation changes:
  - dropped | from description
  - dropped nodename
  - unified use of quotes
  - used GPIO_ACTIVE_LOW define
  - used phandle instead of path
---

Michał Mirosław (1):
  i2c: Add GPIO-based hotplug gate

Svyatoslav Ryhel (1):
  dt-bindings: i2c: add binding for i2c-hotplug-gpio

 .../bindings/i2c/i2c-hotplug-gpio.yaml        |  65 +++++
 drivers/i2c/Kconfig                           |  11 +
 drivers/i2c/Makefile                          |   1 +
 drivers/i2c/i2c-hotplug-gpio.c                | 266 ++++++++++++++++++
 4 files changed, 343 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-hotplug-gpio.yaml
 create mode 100644 drivers/i2c/i2c-hotplug-gpio.c

-- 
2.39.2


             reply	other threads:[~2023-07-29 16:09 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29 16:08 Svyatoslav Ryhel [this message]
2023-07-29 16:08 ` [PATCH v3 1/2] dt-bindings: i2c: add binding for i2c-hotplug-gpio Svyatoslav Ryhel
2023-08-05 19:23   ` Krzysztof Kozlowski
2023-08-11 17:37   ` Rob Herring
2023-08-12 21:46     ` Michał Mirosław
2023-08-15 20:00       ` Wolfram Sang
2023-07-29 16:08 ` [PATCH v3 2/2] i2c: Add GPIO-based hotplug gate Svyatoslav Ryhel
2023-07-30 20:25   ` Andi Shyti
2023-07-30 22:11     ` Michał Mirosław
2023-07-31 23:01       ` Michał Mirosław
2023-08-04 23:45         ` Andi Shyti
2023-08-10 22:55           ` Michał Mirosław
2023-07-30 20:30   ` Krzysztof Kozlowski
2023-07-30 21:55     ` Michał Mirosław
2023-07-31  6:58       ` Krzysztof Kozlowski
2023-07-31  8:49         ` Michał Mirosław
2023-07-31 12:59           ` Krzysztof Kozlowski
2023-07-31 22:50             ` Michał Mirosław
2023-08-05 19:17               ` Krzysztof Kozlowski
2023-08-10 21:52                 ` Michał Mirosław
2023-08-15  5:20                   ` Krzysztof Kozlowski
2023-07-30 17:49 ` [PATCH v3 0/2] GPIO-based hotplug i2c bus Andi Shyti
2023-07-30 18:21   ` Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230729160857.6332-1-clamor95@gmail.com \
    --to=clamor95@gmail.com \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=robh+dt@kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).