* [PATCH v2 2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler
2023-07-19 11:43 [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level Andrej Picej
@ 2023-07-19 11:43 ` Andrej Picej
2023-07-19 11:50 ` Stefan Riedmüller
2023-07-30 6:41 ` Shawn Guo
2023-07-19 11:43 ` [PATCH v2 3/3] ARM: dts: imx6: phycore: " Andrej Picej
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Andrej Picej @ 2023-07-19 11:43 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, linux-imx
Cc: devicetree, linux-arm-kernel, linux-kernel, S.Riedmueller,
S.Mueller-Klieser, upstream
Due to the missing signal connection between i.MX6 WDOG_B pin and the
PMICs external reset, the internal i.MX6 watchdog is not able to reset
the phyFLEX SoM properly. Thus disable the internal i.MX6 watchdog to
prevent unexpected PMIC settings after reset.
NOTE: This patch should not be backported as it might break existing
uses and fixes in bootloaders.
Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
Changes in v2:
- this is a substitute patch with a proper fix.
---
arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
index 80adb2a02cc9..65fd7b4a6f27 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
@@ -464,3 +464,11 @@ &usdhc3 {
vmmc-supply = <&vdd_sd0_reg>;
status = "disabled";
};
+
+&wdog1 {
+ /*
+ * Rely on PMIC reboot handler. Internal i.MX6 watchdog, that is also
+ * used for reboot, does not reset all external PMIC voltages on reset.
+ */
+ status = "disabled";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler
2023-07-19 11:43 ` [PATCH v2 2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler Andrej Picej
@ 2023-07-19 11:50 ` Stefan Riedmüller
2023-07-30 6:41 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Stefan Riedmüller @ 2023-07-19 11:50 UTC (permalink / raw)
To: kernel@pengutronix.de, linux-imx@nxp.com, andrej.picej@norik.com,
s.hauer@pengutronix.de, shawnguo@kernel.org, festevam@gmail.com,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Stefan Müller-Klieser,
upstream@phytec.de
Hi Andrej,
On Wed, 2023-07-19 at 13:43 +0200, Andrej Picej wrote:
> Due to the missing signal connection between i.MX6 WDOG_B pin and the
> PMICs external reset, the internal i.MX6 watchdog is not able to reset
> the phyFLEX SoM properly. Thus disable the internal i.MX6 watchdog to
> prevent unexpected PMIC settings after reset.
>
> NOTE: This patch should not be backported as it might break existing
> uses and fixes in bootloaders.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Reviewed-by: Stefan Riedmüller <s.riedmueller@phytec.de>
> ---
> Changes in v2:
> - this is a substitute patch with a proper fix.
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
> index 80adb2a02cc9..65fd7b4a6f27 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
> @@ -464,3 +464,11 @@ &usdhc3 {
> vmmc-supply = <&vdd_sd0_reg>;
> status = "disabled";
> };
> +
> +&wdog1 {
> + /*
> + * Rely on PMIC reboot handler. Internal i.MX6 watchdog, that is
> also
> + * used for reboot, does not reset all external PMIC voltages on
> reset.
> + */
> + status = "disabled";
> +};
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler
2023-07-19 11:43 ` [PATCH v2 2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler Andrej Picej
2023-07-19 11:50 ` Stefan Riedmüller
@ 2023-07-30 6:41 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2023-07-30 6:41 UTC (permalink / raw)
To: Andrej Picej
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, s.hauer, kernel,
festevam, linux-imx, devicetree, linux-arm-kernel, linux-kernel,
S.Riedmueller, S.Mueller-Klieser, upstream
On Wed, Jul 19, 2023 at 01:43:27PM +0200, Andrej Picej wrote:
> Due to the missing signal connection between i.MX6 WDOG_B pin and the
> PMICs external reset, the internal i.MX6 watchdog is not able to reset
> the phyFLEX SoM properly. Thus disable the internal i.MX6 watchdog to
> prevent unexpected PMIC settings after reset.
>
> NOTE: This patch should not be backported as it might break existing
> uses and fixes in bootloaders.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] ARM: dts: imx6: phycore: Rely on PMIC reboot/reset handler
2023-07-19 11:43 [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level Andrej Picej
2023-07-19 11:43 ` [PATCH v2 2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler Andrej Picej
@ 2023-07-19 11:43 ` Andrej Picej
2023-07-19 11:50 ` Stefan Riedmüller
2023-07-30 6:42 ` Shawn Guo
2023-07-19 11:49 ` [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level Stefan Riedmüller
2023-07-30 6:34 ` Shawn Guo
3 siblings, 2 replies; 9+ messages in thread
From: Andrej Picej @ 2023-07-19 11:43 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, conor+dt, shawnguo, s.hauer,
kernel, festevam, linux-imx
Cc: devicetree, linux-arm-kernel, linux-kernel, S.Riedmueller,
S.Mueller-Klieser, upstream
Due to the missing signal connection between i.MX6 WDOG_B pin and the
PMICs external reset, the internal i.MX6 watchdog is not able to reset
the phyCORE i.MX6 SoM properly. Thus disable the internal i.MX6 watchdog
to prevent unexpected PMIC settings after reset.
NOTE: This patch should not be backported as it might break existing
uses and fixes in bootloaders.
Signed-off-by: Andrej Picej <andrej.picej@norik.com>
---
Changes in v2:
- new patch
- i.MX6 phyCOREs have the same problem as phyFLEX devices.
---
arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
index 28a805384668..86b4269e0e01 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
@@ -309,3 +309,11 @@ MX6QDL_PAD_SD4_DAT7__SD4_DATA7 0x17059
>;
};
};
+
+&wdog1 {
+ /*
+ * Rely on PMIC reboot handler. Internal i.MX6 watchdog, that is also
+ * used for reboot, does not reset all external PMIC voltages on reset.
+ */
+ status = "disabled";
+};
--
2.25.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 3/3] ARM: dts: imx6: phycore: Rely on PMIC reboot/reset handler
2023-07-19 11:43 ` [PATCH v2 3/3] ARM: dts: imx6: phycore: " Andrej Picej
@ 2023-07-19 11:50 ` Stefan Riedmüller
2023-07-30 6:42 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Stefan Riedmüller @ 2023-07-19 11:50 UTC (permalink / raw)
To: kernel@pengutronix.de, linux-imx@nxp.com, andrej.picej@norik.com,
s.hauer@pengutronix.de, shawnguo@kernel.org, festevam@gmail.com,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Stefan Müller-Klieser,
upstream@phytec.de
Hi Andrej,
On Wed, 2023-07-19 at 13:43 +0200, Andrej Picej wrote:
> Due to the missing signal connection between i.MX6 WDOG_B pin and the
> PMICs external reset, the internal i.MX6 watchdog is not able to reset
> the phyCORE i.MX6 SoM properly. Thus disable the internal i.MX6 watchdog
> to prevent unexpected PMIC settings after reset.
>
> NOTE: This patch should not be backported as it might break existing
> uses and fixes in bootloaders.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Reviewed-by: Stefan Riedmüller <s.riedmueller@phytec.de>
> ---
> Changes in v2:
> - new patch
> - i.MX6 phyCOREs have the same problem as phyFLEX devices.
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
> index 28a805384668..86b4269e0e01 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
> @@ -309,3 +309,11 @@ MX6QDL_PAD_SD4_DAT7__SD4_DATA7 0x17059
> >;
> };
> };
> +
> +&wdog1 {
> + /*
> + * Rely on PMIC reboot handler. Internal i.MX6 watchdog, that is
> also
> + * used for reboot, does not reset all external PMIC voltages on
> reset.
> + */
> + status = "disabled";
> +};
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 3/3] ARM: dts: imx6: phycore: Rely on PMIC reboot/reset handler
2023-07-19 11:43 ` [PATCH v2 3/3] ARM: dts: imx6: phycore: " Andrej Picej
2023-07-19 11:50 ` Stefan Riedmüller
@ 2023-07-30 6:42 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2023-07-30 6:42 UTC (permalink / raw)
To: Andrej Picej
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, s.hauer, kernel,
festevam, linux-imx, devicetree, linux-arm-kernel, linux-kernel,
S.Riedmueller, S.Mueller-Klieser, upstream
On Wed, Jul 19, 2023 at 01:43:28PM +0200, Andrej Picej wrote:
> Due to the missing signal connection between i.MX6 WDOG_B pin and the
> PMICs external reset, the internal i.MX6 watchdog is not able to reset
> the phyCORE i.MX6 SoM properly. Thus disable the internal i.MX6 watchdog
> to prevent unexpected PMIC settings after reset.
>
> NOTE: This patch should not be backported as it might break existing
> uses and fixes in bootloaders.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level
2023-07-19 11:43 [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level Andrej Picej
2023-07-19 11:43 ` [PATCH v2 2/3] ARM: dts: imx6: pfla02: Rely on PMIC reboot/reset handler Andrej Picej
2023-07-19 11:43 ` [PATCH v2 3/3] ARM: dts: imx6: phycore: " Andrej Picej
@ 2023-07-19 11:49 ` Stefan Riedmüller
2023-07-30 6:34 ` Shawn Guo
3 siblings, 0 replies; 9+ messages in thread
From: Stefan Riedmüller @ 2023-07-19 11:49 UTC (permalink / raw)
To: kernel@pengutronix.de, linux-imx@nxp.com, andrej.picej@norik.com,
s.hauer@pengutronix.de, shawnguo@kernel.org, festevam@gmail.com,
conor+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Stefan Müller-Klieser,
upstream@phytec.de
Hi Andrej,
On Wed, 2023-07-19 at 13:43 +0200, Andrej Picej wrote:
> RTC interrupt level should be set to "LOW". This was revealed by the
> introduction of commit:
>
> f181987ef477 ("rtc: m41t80: use IRQ flags obtained from fwnode")
>
> which changed the way IRQ type is obtained.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Reviewed-by: Stefan Riedmüller <s.riedmueller@phytec.de>
> ---
> Changes in v2:
> - no changes
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
> index 1a599c294ab8..1ca4d219609f 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-mira.dtsi
> @@ -182,7 +182,7 @@ i2c_rtc: rtc@68 {
> pinctrl-0 = <&pinctrl_rtc_int>;
> reg = <0x68>;
> interrupt-parent = <&gpio7>;
> - interrupts = <8 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
> status = "disabled";
> };
> };
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level
2023-07-19 11:43 [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level Andrej Picej
` (2 preceding siblings ...)
2023-07-19 11:49 ` [PATCH v2 1/3] ARM: dts: imx6: phytec: fix RTC interrupt level Stefan Riedmüller
@ 2023-07-30 6:34 ` Shawn Guo
3 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2023-07-30 6:34 UTC (permalink / raw)
To: Andrej Picej
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, s.hauer, kernel,
festevam, linux-imx, devicetree, linux-arm-kernel, linux-kernel,
S.Riedmueller, S.Mueller-Klieser, upstream
On Wed, Jul 19, 2023 at 01:43:26PM +0200, Andrej Picej wrote:
> RTC interrupt level should be set to "LOW". This was revealed by the
> introduction of commit:
>
> f181987ef477 ("rtc: m41t80: use IRQ flags obtained from fwnode")
>
> which changed the way IRQ type is obtained.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
Applied as a fix with tag:
Fixes: 800d595151bb ("ARM: dts: imx6: Add initial support for phyBOARD-Mira")
Shawn
^ permalink raw reply [flat|nested] 9+ messages in thread