[PATCH v1 0/1] Transformers: switch from paths to labels in device tree

[PATCH v1 0/1] Transformers: switch from paths to labels in device tree

[Svyatoslav Ryhel]

Use phandles in aliases instead of paths to ease device tree comprehension.

Svyatoslav Ryhel (1):
  ARM: tegra: transformer: use labels for mmc in aliases

 arch/arm/boot/dts/tegra114-asus-tf701t.dts           | 12 ++++++------
 .../boot/dts/tegra30-asus-transformer-common.dtsi    | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

-- 
2.39.2

[PATCH v1 1/1] ARM: tegra: transformer: use labels for mmc in aliases

[Svyatoslav Ryhel]

Use phandle references for mmc instead of path in aliases.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 arch/arm/boot/dts/tegra114-asus-tf701t.dts           | 12 ++++++------
 .../boot/dts/tegra30-asus-transformer-common.dtsi    | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/arch/arm/boot/dts/tegra114-asus-tf701t.dts b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
index 84a3eb38e71d..3a420ac969ff 100644
--- a/arch/arm/boot/dts/tegra114-asus-tf701t.dts
+++ b/arch/arm/boot/dts/tegra114-asus-tf701t.dts
@@ -13,9 +13,9 @@ / {
 	chassis-type = "convertible";
 
 	aliases {
-		mmc0 = "/mmc@78000600"; /* eMMC */
-		mmc1 = "/mmc@78000400"; /* uSD slot */
-		mmc2 = "/mmc@78000000"; /* WiFi */
+		mmc0 = &sdmmc4; /* eMMC */
+		mmc1 = &sdmmc3; /* uSD slot */
+		mmc2 = &sdmmc1; /* WiFi */
 
 		rtc0 = &palmas;
 		rtc1 = "/rtc@7000e000";
@@ -605,12 +605,12 @@ i2s@70080300 {
 		};
 	};
 
-	mmc@78000000 {
+	sdmmc1: mmc@78000000 {
 		/* WiFi */
 	};
 
 	/* MicroSD card */
-	mmc@78000400 {
+	sdmmc3: mmc@78000400 {
 		status = "okay";
 
 		bus-width = <4>;
@@ -626,7 +626,7 @@ mmc@78000400 {
 		pinctrl-0 = <&sdmmc3_default>;
 	};
 
-	mmc@78000600 {
+	sdmmc4: mmc@78000600 {
 		/* eMMC */
 	};
 
diff --git a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
index bdb898ad6262..b0ca56e611e8 100644
--- a/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
+++ b/arch/arm/boot/dts/tegra30-asus-transformer-common.dtsi
@@ -12,9 +12,9 @@ / {
 	chassis-type = "convertible";
 
 	aliases {
-		mmc0 = "/mmc@78000600"; /* eMMC */
-		mmc1 = "/mmc@78000000"; /* uSD slot */
-		mmc2 = "/mmc@78000400"; /* WiFi */
+		mmc0 = &sdmmc4; /* eMMC */
+		mmc1 = &sdmmc1; /* uSD slot */
+		mmc2 = &sdmmc3; /* WiFi */
 
 		rtc0 = &pmic;
 		rtc1 = "/rtc@7000e000";
@@ -1388,7 +1388,7 @@ i2s@70080600 {		/* i2s3 */
 		};
 	};
 
-	mmc@78000000 {
+	sdmmc1: mmc@78000000 {
 		status = "okay";
 
 		/* FIXME: Full 208Mhz clock rate doesn't work reliably */
@@ -1401,7 +1401,7 @@ mmc@78000000 {
 		vqmmc-supply = <&vddio_usd>;	/* ldo3 */
 	};
 
-	mmc@78000400 {
+	sdmmc3: mmc@78000400 {
 		status = "okay";
 
 		#address-cells = <1>;
@@ -1431,7 +1431,7 @@ wifi@1 {
 		};
 	};
 
-	mmc@78000600 {
+	sdmmc4: mmc@78000600 {
 		status = "okay";
 		bus-width = <8>;
 		vmmc-supply = <&vcore_emmc>;
-- 
2.39.2

Re: [PATCH v1 1/1] ARM: tegra: transformer: use labels for mmc in aliases

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Sun, Jul 30, 2023 at 03:51:50PM +0300, Svyatoslav Ryhel wrote:
> Use phandle references for mmc instead of path in aliases.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> ---
>  arch/arm/boot/dts/tegra114-asus-tf701t.dts           | 12 ++++++------
>  .../boot/dts/tegra30-asus-transformer-common.dtsi    | 12 ++++++------
>  2 files changed, 12 insertions(+), 12 deletions(-)

The commit message doesn't describe why this is useful and without any
clarification I don't see any benefit in doing this.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v1 1/1] ARM: tegra: transformer: use labels for mmc in aliases

[Svyatoslav Ryhel]

16 серпня 2023 р. 19:33:27 GMT+03:00, Thierry Reding <thierry.reding@gmail.com> написав(-ла):
>On Sun, Jul 30, 2023 at 03:51:50PM +0300, Svyatoslav Ryhel wrote:
>> Use phandle references for mmc instead of path in aliases.
>> 
>> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
>> ---
>>  arch/arm/boot/dts/tegra114-asus-tf701t.dts           | 12 ++++++------
>>  .../boot/dts/tegra30-asus-transformer-common.dtsi    | 12 ++++++------
>>  2 files changed, 12 insertions(+), 12 deletions(-)
>
>The commit message doesn't describe why this is useful and without any
>clarification I don't see any benefit in doing this.

1. Simplify comprehension of aliases, path is harder to read then a label
2. Unify with other t20 and t30 trees (paz00, tf101, grouper, picasso etc)

>Thierry