devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jai Luthra <j-luthra@ti.com>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	<niklas.soderlund+renesas@ragnatech.se>,
	Benoit Parrot <bparrot@ti.com>,
	Vaishnav Achath <vaishnav.a@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>, <nm@ti.com>,
	<devarsht@ti.com>, <j-luthra@ti.com>
Subject: [PATCH v8 09/16] media: cadence: csi2rx: Soft reset the streams before starting capture
Date: Mon, 31 Jul 2023 13:59:27 +0530	[thread overview]
Message-ID: <20230731-upstream_csi-v8-9-fb7d3661c2c9@ti.com> (raw)
In-Reply-To: <20230731-upstream_csi-v8-0-fb7d3661c2c9@ti.com>

From: Pratyush Yadav <p.yadav@ti.com>

This resets the stream state machines and FIFOs, giving them a clean
slate. On J721E if the streams are not reset before starting the
capture, the captured frame gets wrapped around vertically on every run
after the first.

Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
Signed-off-by: Jai Luthra <j-luthra@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v7->v8: No change

 drivers/media/platform/cadence/cdns-csi2rx.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
index 2a80c66fb547..30cdc260b46a 100644
--- a/drivers/media/platform/cadence/cdns-csi2rx.c
+++ b/drivers/media/platform/cadence/cdns-csi2rx.c
@@ -40,6 +40,7 @@
 #define CSI2RX_STREAM_BASE(n)		(((n) + 1) * 0x100)
 
 #define CSI2RX_STREAM_CTRL_REG(n)		(CSI2RX_STREAM_BASE(n) + 0x000)
+#define CSI2RX_STREAM_CTRL_SOFT_RST			BIT(4)
 #define CSI2RX_STREAM_CTRL_START			BIT(0)
 
 #define CSI2RX_STREAM_DATA_CFG_REG(n)		(CSI2RX_STREAM_BASE(n) + 0x008)
@@ -138,12 +139,22 @@ struct csi2rx_priv *v4l2_subdev_to_csi2rx(struct v4l2_subdev *subdev)
 
 static void csi2rx_reset(struct csi2rx_priv *csi2rx)
 {
+	unsigned int i;
+
 	writel(CSI2RX_SOFT_RESET_PROTOCOL | CSI2RX_SOFT_RESET_FRONT,
 	       csi2rx->base + CSI2RX_SOFT_RESET_REG);
 
 	udelay(10);
 
 	writel(0, csi2rx->base + CSI2RX_SOFT_RESET_REG);
+
+	/* Reset individual streams. */
+	for (i = 0; i < csi2rx->max_streams; i++) {
+		writel(CSI2RX_STREAM_CTRL_SOFT_RST,
+		       csi2rx->base + CSI2RX_STREAM_CTRL_REG(i));
+		usleep_range(10, 20);
+		writel(0, csi2rx->base + CSI2RX_STREAM_CTRL_REG(i));
+	}
 }
 
 static int csi2rx_configure_ext_dphy(struct csi2rx_priv *csi2rx)

-- 
2.41.0

  parent reply	other threads:[~2023-07-31  8:30 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  8:29 [PATCH v8 00/16] CSI2RX support on J721E and AM62 Jai Luthra
2023-07-31  8:29 ` [PATCH v8 01/16] media: subdev: Export get_format helper for link validation Jai Luthra
2023-08-01 14:09   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 02/16] media: dt-bindings: Make sure items in data-lanes are unique Jai Luthra
2023-08-01 14:09   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 03/16] media: dt-bindings: cadence-csi2rx: Add TI compatible string Jai Luthra
2023-08-05 21:06   ` Krzysztof Kozlowski
2023-07-31  8:29 ` [PATCH v8 04/16] media: cadence: Add support for TI SoCs Jai Luthra
2023-08-05 21:06   ` Krzysztof Kozlowski
2023-08-07  7:58     ` Jai Luthra
2023-07-31  8:29 ` [PATCH v8 05/16] media: cadence: csi2rx: Unregister v4l2 async notifier Jai Luthra
2023-08-01 14:11   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 06/16] media: cadence: csi2rx: Cleanup media entity properly Jai Luthra
2023-08-01 14:11   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 07/16] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops Jai Luthra
2023-08-02  8:48   ` Tomi Valkeinen
2023-08-03 11:18     ` Jai Luthra
2023-07-31  8:29 ` [PATCH v8 08/16] media: cadence: csi2rx: Configure DPHY using link freq Jai Luthra
2023-08-02  9:41   ` Tomi Valkeinen
2023-07-31  8:29 ` Jai Luthra [this message]
2023-08-01 14:16   ` [PATCH v8 09/16] media: cadence: csi2rx: Soft reset the streams before starting capture Tomi Valkeinen
2023-08-03 11:19     ` Jai Luthra
2023-07-31  8:29 ` [PATCH v8 10/16] media: cadence: csi2rx: Set the STOP bit when stopping a stream Jai Luthra
2023-08-02  9:45   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 11/16] media: cadence: csi2rx: Fix stream data configuration Jai Luthra
2023-08-01 14:17   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 12/16] media: cadence: csi2rx: Populate subdev devnode Jai Luthra
2023-08-01 14:18   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 13/16] media: cadence: csi2rx: Add link validation Jai Luthra
2023-08-01 14:19   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 14/16] media: cadence: csi2rx: Support RAW8 and RAW10 formats Jai Luthra
2023-08-02  9:46   ` Tomi Valkeinen
2023-07-31  8:29 ` [PATCH v8 15/16] media: dt-bindings: Add TI J721E CSI2RX Jai Luthra
2023-07-31  9:31   ` Rob Herring
2023-07-31  9:54     ` Jai Luthra
2023-07-31  8:29 ` [PATCH v8 16/16] media: ti: Add CSI2RX support for J721E Jai Luthra
2023-08-02 11:04   ` Tomi Valkeinen
2023-08-02 11:14     ` Sakari Ailus
2023-08-02 12:09       ` Tomi Valkeinen
2023-08-03 11:51     ` Jai Luthra
2023-07-31 12:11 ` [PATCH v8 00/16] CSI2RX support on J721E and AM62 Maxime Ripard
2023-08-08 22:55 ` Vaishnav Achath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230731-upstream_csi-v8-9-fb7d3661c2c9@ti.com \
    --to=j-luthra@ti.com \
    --cc=bparrot@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mripard@kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=vaishnav.a@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).