From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 935AAC001E0 for ; Mon, 31 Jul 2023 15:58:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230413AbjGaP6r (ORCPT ); Mon, 31 Jul 2023 11:58:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbjGaP6q (ORCPT ); Mon, 31 Jul 2023 11:58:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9342511B; Mon, 31 Jul 2023 08:58:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 27E19611FC; Mon, 31 Jul 2023 15:58:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 075BBC433C7; Mon, 31 Jul 2023 15:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690819124; bh=R1G04hta+saztdfdrFiAoSHpGKl0V0AP6qVL7ELtNro=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OP8BfhoEG5YnNRPnRTDoXNpryf59JCNmvEbP/jVRlE+we9YGAZNCDAB/FslU1Yy9s FhD1ATE37t/1vfHy/Bg9Ez9+mB8wrrATlEH1pAk5odqQNyQrZxv2PwBPLvrVZGoMy7 Tncwhoi0jOhtm+VDWY/NJxve7zq5s+CmRUQ8Wmmg= Date: Mon, 31 Jul 2023 17:58:41 +0200 From: Greg KH To: Hugo Villeneuve Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, isaac.true@canonical.com, jesse.sung@canonical.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Hugo Villeneuve , stable@vger.kernel.org, Andy Shevchenko , Lech Perczak Subject: Re: [PATCH v9 06/10] serial: sc16is7xx: fix regression with GPIO configuration Message-ID: <2023073105-elevation-canister-2777@gregkh> References: <20230725142343.1724130-1-hugo@hugovil.com> <20230725142343.1724130-7-hugo@hugovil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230725142343.1724130-7-hugo@hugovil.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jul 25, 2023 at 10:23:38AM -0400, Hugo Villeneuve wrote: > From: Hugo Villeneuve > > Commit 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines") > and commit 21144bab4f11 ("sc16is7xx: Handle modem status lines") > changed the function of the GPIOs pins to act as modem control > lines without any possibility of selecting GPIO function. > > As a consequence, applications that depends on GPIO lines configured > by default as GPIO pins no longer work as expected. > > Also, the change to select modem control lines function was done only > for channel A of dual UART variants (752/762). This was not documented > in the log message. > > Allow to specify GPIO or modem control line function in the device > tree, and for each of the ports (A or B). > > Do so by using the new device-tree property named > "nxp,modem-control-line-ports" (property added in separate patch). > > When registering GPIO chip controller, mask-out GPIO pins declared as > modem control lines according to this new DT property. > > Fixes: 679875d1d880 ("sc16is7xx: Separate GPIOs from modem control lines") > Fixes: 21144bab4f11 ("sc16is7xx: Handle modem status lines") > Cc: # 6.1.x: 95982fad dt-bindings: sc16is7xx: Add property to change GPIO function > Cc: # 6.1.x: 1584d572 serial: sc16is7xx: refactor GPIO controller registration > Cc: # 6.1.x: ac2caa5a serial: sc16is7xx: remove obsolete out_thread label > Cc: # 6.1.x: d90961ad serial: sc16is7xx: mark IOCONTROL register as volatile > Cc: # 6.1.x: 6dae3bad serial: sc16is7xx: fix broken port 0 uart init Where are these git commit ids from? I don't see them in Linus's tree, how are they supposed to be picked up by the stable developers if they are not valid ones? confused, greg k-h