[PATCH 00/13] arm64: rockchip: Add more RV1126 DT nodes

[PATCH 00/13] arm64: rockchip: Add more RV1126 DT nodes

[Jagan Teki]

Patchset adds more DT nodes for Rockchip RV1126.

Jagan Teki (12):
  dt-bindings: pwm: rockchip: Document rv1126-pwm
  ARM: dts: rockchip: rv1126: Add pwm2m0 pins
  ARM: dts: rockchip: rv1126: Add pwm2 node
  ARM: dts: rockchip: rv1126: Add pwm11m0 pins
  ARM: dts: rockchip: rv1126: Add pwm11 node
  ARM: dts: rockchip: rv1126: Add SFC node
  ARM: dts: rockchip: rv1126: Add FSPI pins
  ARM: dts: rockchip: rv1126: Add uart5m2_xfer pins
  ARM: dts: rv1126: Enable pwm fan for edgeble-neu2
  ARM: dts: rv1126: Drop EMMC_RSTN for edgeble-neu2
  ARM: dts: rv1126: Add 3V3_SYS regulator for edgeble-neu2
  ARM: dts: rv1126: Add 12V main supply for edgeble-neu2

Stephen Chen (1):
  ARM: dts: rv1126: Enable SFC for edgeble-neu2

 .../devicetree/bindings/pwm/pwm-rockchip.yaml |  1 +
 .../dts/rockchip/rv1126-edgeble-neu2-io.dts   | 33 +++++++++++++++
 .../dts/rockchip/rv1126-edgeble-neu2.dtsi     | 27 +++++++-----
 .../arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 42 +++++++++++++++++++
 arch/arm/boot/dts/rockchip/rv1126.dtsi        | 34 +++++++++++++++
 5 files changed, 127 insertions(+), 10 deletions(-)

-- 
2.25.1

[PATCH 01/13] dt-bindings: pwm: rockchip: Document rv1126-pwm

[Jagan Teki]

Document pwm compatible for rv1126 which is fallback compatible
of rk3328-pwm group.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
Cc: linux-pwm@vger.kernel.org
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>

 Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
index f2d1dc7e7b3f..65bfb492b3a4 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
@@ -32,6 +32,7 @@ properties:
               - rockchip,rk3308-pwm
               - rockchip,rk3568-pwm
               - rockchip,rk3588-pwm
+              - rockchip,rv1126-pwm
           - const: rockchip,rk3328-pwm
 
   reg:
-- 
2.25.1

[PATCH 02/13] ARM: dts: rockchip: rv1126: Add pwm2m0 pins

[Jagan Teki]

Add pwm2m0 pins for Rockchip RV1126 PWM2.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
index b77021772781..239a1dd9360f 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
@@ -69,6 +69,14 @@ i2c0_xfer: i2c0-xfer {
 				<0 RK_PB5 1 &pcfg_pull_none_drv_level_0_smt>;
 		};
 	};
+	pwm2 {
+		/omit-if-no-ref/
+		pwm2m0_pins: pwm2m0-pins {
+			rockchip,pins =
+				/* pwm2_pin_m0 */
+				<0 RK_PC0 3 &pcfg_pull_none>;
+		};
+	};
 	rgmii {
 		/omit-if-no-ref/
 		rgmiim1_pins: rgmiim1-pins {
-- 
2.25.1

[PATCH 03/13] ARM: dts: rockchip: rv1126: Add pwm2 node

[Jagan Teki]

Add PWM2 node for Rockchip RV1126.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
index 1f07d0a4fa73..931a1ffc22e8 100644
--- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
@@ -203,6 +203,17 @@ uart1: serial@ff410000 {
 		status = "disabled";
 	};
 
+	pwm2: pwm@ff430020 {
+		compatible = "rockchip,rv1126-pwm", "rockchip,rk3328-pwm";
+		reg = <0xff430020 0x10>;
+		clock-names = "pwm", "pclk";
+		clocks = <&pmucru CLK_PWM0>, <&pmucru PCLK_PWM0>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&pwm2m0_pins>;
+		#pwm-cells = <3>;
+		status = "disabled";
+	};
+
 	pmucru: clock-controller@ff480000 {
 		compatible = "rockchip,rv1126-pmucru";
 		reg = <0xff480000 0x1000>;
-- 
2.25.1

[PATCH 04/13] ARM: dts: rockchip: rv1126: Add pwm11m0 pins

[Jagan Teki]

Add pwm11m0 pins for Rockchip RV1126 PWM11.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
index 239a1dd9360f..891e5fb72056 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
@@ -77,6 +77,14 @@ pwm2m0_pins: pwm2m0-pins {
 				<0 RK_PC0 3 &pcfg_pull_none>;
 		};
 	};
+	pwm11 {
+		/omit-if-no-ref/
+		pwm11m0_pins: pwm11m0-pins {
+			rockchip,pins =
+				/* pwm11_pin_m0 */
+				<3 RK_PA7 6 &pcfg_pull_none>;
+		};
+	};
 	rgmii {
 		/omit-if-no-ref/
 		rgmiim1_pins: rgmiim1-pins {
-- 
2.25.1

[PATCH 05/13] ARM: dts: rockchip: rv1126: Add pwm11 node

[Jagan Teki]

Add pwm11 node for Rockchip RV1126.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
index 931a1ffc22e8..86b560dc3b64 100644
--- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
@@ -243,6 +243,17 @@ dmac: dma-controller@ff4e0000 {
 		clock-names = "apb_pclk";
 	};
 
+	pwm11: pwm@ff550030 {
+		compatible = "rockchip,rv1126-pwm", "rockchip,rk3328-pwm";
+		reg = <0xff550030 0x10>;
+		clock-names = "pwm", "pclk";
+		clocks = <&cru CLK_PWM2>, <&cru PCLK_PWM2>;
+		pinctrl-0 = <&pwm11m0_pins>;
+		pinctrl-names = "default";
+		#pwm-cells = <3>;
+		status = "disabled";
+	};
+
 	uart0: serial@ff560000 {
 		compatible = "rockchip,rv1126-uart", "snps,dw-apb-uart";
 		reg = <0xff560000 0x100>;
-- 
2.25.1

[PATCH 06/13] ARM: dts: rockchip: rv1126: Add SFC node

[Jagan Teki]

Add Rockchip SFC controller node for rv1126.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
index 86b560dc3b64..afa5a68f766f 100644
--- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
@@ -441,6 +441,18 @@ sdio: mmc@ffc70000 {
 		status = "disabled";
 	};
 
+	sfc: spi@ffc90000  {
+		compatible = "rockchip,sfc";
+		reg = <0xffc90000 0x4000>;
+		interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
+		assigned-clocks = <&cru SCLK_SFC>;
+		assigned-clock-rates = <80000000>;
+		clock-names = "clk_sfc", "hclk_sfc";
+		clocks = <&cru SCLK_SFC>, <&cru HCLK_SFC>;
+		power-domains = <&power RV1126_PD_NVM>;
+		status = "disabled";
+	};
+
 	pinctrl: pinctrl {
 		compatible = "rockchip,rv1126-pinctrl";
 		rockchip,grf = <&grf>;
-- 
2.25.1

[PATCH 07/13] ARM: dts: rockchip: rv1126: Add FSPI pins

[Jagan Teki]

Add fspi pins for rv1126 sfc controller.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
index 891e5fb72056..cb31e6bebcec 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
@@ -59,6 +59,24 @@ emmc_cmd: emmc-cmd {
 				<0 RK_PD5 2 &pcfg_pull_up_drv_level_2>;
 		};
 	};
+	fspi {
+		/omit-if-no-ref/
+		fspi_pins: fspi-pins {
+			rockchip,pins =
+				/* fspi_clk */
+				<1 RK_PA3 3 &pcfg_pull_down>,
+				/* fspi_cs0n */
+				<0 RK_PD4 3 &pcfg_pull_up>,
+				/* fspi_d0 */
+				<1 RK_PA0 3 &pcfg_pull_up>,
+				/* fspi_d1 */
+				<1 RK_PA1 3 &pcfg_pull_up>,
+				/* fspi_d2 */
+				<0 RK_PD6 3 &pcfg_pull_up>,
+				/* fspi_d3 */
+				<1 RK_PA2 3 &pcfg_pull_up>;
+		};
+	};
 	i2c0 {
 		/omit-if-no-ref/
 		i2c0_xfer: i2c0-xfer {
-- 
2.25.1

[PATCH 08/13] ARM: dts: rockchip: rv1126: Add uart5m2_xfer pins

[Jagan Teki]

Add uart5m2_xfer pins for Rockchip RV1126 uart5.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
index cb31e6bebcec..bb34b0c9cb4a 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126-pinctrl.dtsi
@@ -283,5 +283,13 @@ uart5m0_xfer: uart5m0-xfer {
 				/* uart5_tx_m0 */
 				<3 RK_PA6 4 &pcfg_pull_up>;
 		};
+		/omit-if-no-ref/
+		uart5m2_xfer: uart5m2-xfer {
+			rockchip,pins =
+				/* uart5_rx_m2 */
+				<2 RK_PA1 3 &pcfg_pull_up>,
+				/* uart5_tx_m2 */
+				<2 RK_PA0 3 &pcfg_pull_up>;
+		};
 	};
 };
-- 
2.25.1

[PATCH 09/13] ARM: dts: rv1126: Enable pwm fan for edgeble-neu2

[Jagan Teki]

Edgeble Neu2 IO board Fan connected to PWM11.

Enable the pwm fan for it.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
index 3340fc3f0739..bbc1cd50a1f6 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
+++ b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
@@ -59,6 +59,10 @@ eth_phy_rst: eth-phy-rst {
 	};
 };
 
+&pwm11 {
+	status = "okay";
+};
+
 &sdmmc {
 	bus-width = <4>;
 	cap-mmc-highspeed;
-- 
2.25.1

[PATCH 10/13] ARM: dts: rv1126: Drop EMMC_RSTN for edgeble-neu2

[Jagan Teki]

EMMC_RSTN GPIO1_A3 is connected to FSPI_CLK in Edgeble Neu2
board.

So, drop the same GPIO pin from eMMC.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
index cc64ba4be344..e3e5752fd6b7 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
@@ -52,7 +52,7 @@ &emmc {
 	bus-width = <8>;
 	non-removable;
 	pinctrl-names = "default";
-	pinctrl-0 = <&emmc_bus8 &emmc_cmd &emmc_clk &emmc_rstnout>;
+	pinctrl-0 = <&emmc_bus8 &emmc_cmd &emmc_clk>;
 	rockchip,default-sample-phase = <90>;
 	vmmc-supply = <&vcc_3v3>;
 	vqmmc-supply = <&vccio_flash>;
-- 
2.25.1

[PATCH 11/13] ARM: dts: rv1126: Enable SFC for edgeble-neu2

[Jagan Teki]

From: Stephen Chen <stephen@radxa.com>

Enable on module SPI Flash present in Edgeble Neu2.

Tested-by: Jagan Teki <jagan@edgeble.ai>
Signed-off-by: Stephen Chen <stephen@radxa.com>
---
 .../boot/dts/rockchip/rv1126-edgeble-neu2.dtsi   | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
index e3e5752fd6b7..6bbaf6da6545 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
@@ -301,6 +301,22 @@ &saradc {
 	status = "okay";
 };
 
+&sfc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&fspi_pins>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <50000000>;
+		spi-rx-bus-width = <4>;
+		spi-tx-bus-width = <1>;
+	};
+};
+
 &sdio {
 	bus-width = <4>;
 	cap-sd-highspeed;
-- 
2.25.1

[PATCH 12/13] ARM: dts: rv1126: Add 3V3_SYS regulator for edgeble-neu2

[Jagan Teki]

Edgeble Neu2 IO board has 3V3_SYS regulator to power Audio, RS485,
and 4G Module.

Add regulator for it.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
index bbc1cd50a1f6..1c6a6a134131 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
+++ b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
@@ -20,6 +20,16 @@ aliases {
 	chosen {
 		stdout-path = "serial2:1500000n8";
 	};
+
+	v3v3_sys: v3v3-sys-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "v3v3_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		vin-supply = <&vcc5v0_sys>;
+	};
 };
 
 &gmac {
-- 
2.25.1

[PATCH 13/13] ARM: dts: rv1126: Add 12V main supply for edgeble-neu2

[Jagan Teki]

The Main supply volatge for Edgeble Neu2 IO board is 12V DC.

Add the 12v supply regulator for it and input to vcc5v0_sys.

Since the power regulator is part of IO board circuit, move the
regulator in IO dts file.

Signed-off-by: Jagan Teki <jagan@edgeble.ai>
---
 .../dts/rockchip/rv1126-edgeble-neu2-io.dts   | 19 +++++++++++++++++++
 .../dts/rockchip/rv1126-edgeble-neu2.dtsi     |  9 ---------
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
index 1c6a6a134131..f09be8405964 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
+++ b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2-io.dts
@@ -21,6 +21,25 @@ chosen {
 		stdout-path = "serial2:1500000n8";
 	};
 
+	vcc12v_dcin: vcc12v-dcin-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc12v_dcin";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <12000000>;
+		regulator-max-microvolt = <12000000>;
+	};
+
+	vcc5v0_sys: vcc5v0-sys-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "vcc5v0_sys";
+		regulator-always-on;
+		regulator-boot-on;
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		vin-supply = <&vcc12v_dcin>;
+	};
+
 	v3v3_sys: v3v3-sys-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "v3v3_sys";
diff --git a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
index 6bbaf6da6545..7ea8d7d16f5f 100644
--- a/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126-edgeble-neu2.dtsi
@@ -11,15 +11,6 @@ aliases {
 		mmc0 = &emmc;
 	};
 
-	vcc5v0_sys: vcc5v0-sys-regulator {
-		compatible = "regulator-fixed";
-		regulator-name = "vcc5v0_sys";
-		regulator-always-on;
-		regulator-boot-on;
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-	};
-
 	vccio_flash: vccio-flash-regulator {
 		compatible = "regulator-fixed";
 		enable-active-high;
-- 
2.25.1

Re: [PATCH 01/13] dt-bindings: pwm: rockchip: Document rv1126-pwm

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
> Document pwm compatible for rv1126 which is fallback compatible
> of rk3328-pwm group.
> 
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Should this go in via the pwm tree, or together with the other patches
via rockchip?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 01/13] dt-bindings: pwm: rockchip: Document rv1126-pwm

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1109 bytes --]

On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
> Document pwm compatible for rv1126 which is fallback compatible
> of rk3328-pwm group.
> 
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
> Cc: linux-pwm@vger.kernel.org
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
> 
>  Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> index f2d1dc7e7b3f..65bfb492b3a4 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml
> @@ -32,6 +32,7 @@ properties:
>                - rockchip,rk3308-pwm
>                - rockchip,rk3568-pwm
>                - rockchip,rk3588-pwm
> +              - rockchip,rv1126-pwm
>            - const: rockchip,rk3328-pwm
>  
>    reg:
> -- 
> 2.25.1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 01/13] dt-bindings: pwm: rockchip: Document rv1126-pwm

[Heiko Stuebner]

Am Montag, 31. Juli 2023, 16:51:29 CEST schrieb Uwe Kleine-König:
> On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
> > Document pwm compatible for rv1126 which is fallback compatible
> > of rk3328-pwm group.
> > 
> > Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Should this go in via the pwm tree, or together with the other patches
> via rockchip?

I have no clue, sadly. I _can_ pick it up, but I guess that would
require an Ack from Thierry? Otherwise I guess we'll need to wait
for him.


Heiko

Re: (subset) [PATCH 00/13] arm64: rockchip: Add more RV1126 DT nodes

[Heiko Stuebner]

On Mon, 31 Jul 2023 16:05:05 +0530, Jagan Teki wrote:
> Patchset adds more DT nodes for Rockchip RV1126.
> 
> Jagan Teki (12):
>   dt-bindings: pwm: rockchip: Document rv1126-pwm
>   ARM: dts: rockchip: rv1126: Add pwm2m0 pins
>   ARM: dts: rockchip: rv1126: Add pwm2 node
>   ARM: dts: rockchip: rv1126: Add pwm11m0 pins
>   ARM: dts: rockchip: rv1126: Add pwm11 node
>   ARM: dts: rockchip: rv1126: Add SFC node
>   ARM: dts: rockchip: rv1126: Add FSPI pins
>   ARM: dts: rockchip: rv1126: Add uart5m2_xfer pins
>   ARM: dts: rv1126: Enable pwm fan for edgeble-neu2
>   ARM: dts: rv1126: Drop EMMC_RSTN for edgeble-neu2
>   ARM: dts: rv1126: Add 3V3_SYS regulator for edgeble-neu2
>   ARM: dts: rv1126: Add 12V main supply for edgeble-neu2
> 
> [...]

Applied, thanks!

I've picked the patches not depending on the pwm binding change.
We'll see about the rest once the binding gets somewhere.


[06/13] ARM: dts: rockchip: rv1126: Add SFC node
        commit: c3ae1484e112343dc5d9fc33ca0cc83c994939c1
[07/13] ARM: dts: rockchip: rv1126: Add FSPI pins
        commit: d91d25b1db47fd5d91782298ac6e6e418aa2da46
[08/13] ARM: dts: rockchip: rv1126: Add uart5m2_xfer pins
        commit: 753c8a7d8bbda86811943b62f8d33c2e0d5e7046
[10/13] ARM: dts: rv1126: Drop EMMC_RSTN for edgeble-neu2
        commit: 012f90c31babdbd94f3e7bc80400f3d4ae5035bf
[11/13] ARM: dts: rv1126: Enable SFC for edgeble-neu2
        commit: f544630dc4967fc58cc995d0d2dd3940d9848c39
[12/13] ARM: dts: rv1126: Add 3V3_SYS regulator for edgeble-neu2
        commit: 5d1d164da4df3c744cf32cb1dae9fcd5837a0240
[13/13] ARM: dts: rv1126: Add 12V main supply for edgeble-neu2
        commit: c991ed9f57c8025b248e284545c5310e67dc44cf

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

Re: [PATCH 01/13] dt-bindings: pwm: rockchip: Document rv1126-pwm

[Krzysztof Kozlowski]

On 09/08/2023 16:02, Heiko Stuebner wrote:
> Am Montag, 31. Juli 2023, 16:51:29 CEST schrieb Uwe Kleine-König:
>> On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
>>> Document pwm compatible for rv1126 which is fallback compatible
>>> of rk3328-pwm group.
>>>
>>> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
>>
>> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>
>> Should this go in via the pwm tree, or together with the other patches
>> via rockchip?
> 
> I have no clue, sadly. I _can_ pick it up, but I guess that would
> require an Ack from Thierry? Otherwise I guess we'll need to wait
> for him.

General preference is that binding goes via subsystem (so Thierry), but
there are no driver changes here and your DTS branch would benefit from
it (less dtbs_check warnings). Therefore I propose - just grab it -
unless Thierry wants other way.

Best regards,
Krzysztof

Re: [PATCH 01/13] dt-bindings: pwm: rockchip: Document rv1126-pwm

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1427 bytes --]

Hello Heiko,

On Tue, Aug 15, 2023 at 10:59:57PM +0200, Krzysztof Kozlowski wrote:
> On 09/08/2023 16:02, Heiko Stuebner wrote:
> > Am Montag, 31. Juli 2023, 16:51:29 CEST schrieb Uwe Kleine-König:
> >> On Mon, Jul 31, 2023 at 04:05:06PM +0530, Jagan Teki wrote:
> >>> Document pwm compatible for rv1126 which is fallback compatible
> >>> of rk3328-pwm group.
> >>>
> >>> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> >>
> >> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >>
> >> Should this go in via the pwm tree, or together with the other patches
> >> via rockchip?
> > 
> > I have no clue, sadly. I _can_ pick it up, but I guess that would
> > require an Ack from Thierry? Otherwise I guess we'll need to wait
> > for him.
> 
> General preference is that binding goes via subsystem (so Thierry), but
> there are no driver changes here and your DTS branch would benefit from
> it (less dtbs_check warnings). Therefore I propose - just grab it -
> unless Thierry wants other way.

There are no other changes on the list to that file, so I don't think
we'll run into conflicts. I guess Thierry doesn't feel strong here, so
I'm with Krzysztof here: Pick up this patch together with patches #2 to
#5.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: (subset) [PATCH 00/13] arm64: rockchip: Add more RV1126 DT nodes

[Heiko Stuebner]

On Mon, 31 Jul 2023 16:05:05 +0530, Jagan Teki wrote:
> Patchset adds more DT nodes for Rockchip RV1126.
> 
> Jagan Teki (12):
>   dt-bindings: pwm: rockchip: Document rv1126-pwm
>   ARM: dts: rockchip: rv1126: Add pwm2m0 pins
>   ARM: dts: rockchip: rv1126: Add pwm2 node
>   ARM: dts: rockchip: rv1126: Add pwm11m0 pins
>   ARM: dts: rockchip: rv1126: Add pwm11 node
>   ARM: dts: rockchip: rv1126: Add SFC node
>   ARM: dts: rockchip: rv1126: Add FSPI pins
>   ARM: dts: rockchip: rv1126: Add uart5m2_xfer pins
>   ARM: dts: rv1126: Enable pwm fan for edgeble-neu2
>   ARM: dts: rv1126: Drop EMMC_RSTN for edgeble-neu2
>   ARM: dts: rv1126: Add 3V3_SYS regulator for edgeble-neu2
>   ARM: dts: rv1126: Add 12V main supply for edgeble-neu2
> 
> [...]

Applied, thanks!

[01/13] dt-bindings: pwm: rockchip: Document rv1126-pwm
        commit: b0d587be2407ae7319098339034296370a851939
[02/13] ARM: dts: rockchip: rv1126: Add pwm2m0 pins
        commit: 32cd0ebf1f7961ef049cf9e286568f8e2dfbb88b
[03/13] ARM: dts: rockchip: rv1126: Add pwm2 node
        commit: 8625206d7c3811dfdaef1df9a0bd134f17098b5f
[04/13] ARM: dts: rockchip: rv1126: Add pwm11m0 pins
        commit: 19d79ef9faad6cc15315c3bb0d5fc3594c869d71
[05/13] ARM: dts: rockchip: rv1126: Add pwm11 node
        commit: 8cc85fa1b7640a5de02a3697aaaef4491cf8dba3
[09/13] ARM: dts: rv1126: Enable pwm fan for edgeble-neu2
        commit: 9b201229814fd8d77cc069962b43c4f451592217

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>